Legacy check migration: arris_cmts_cpu I

Change-Id: I30aac32fbbf8fab159df7655a49bddadfbccccff

Author: mo-ki

cmk/base/legacy_checks/arris_cmts_cpu.py

@@ -3,27 +3,35 @@
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
 
-# mypy: disable-error-code="no-untyped-def"
-
 import time
+from collections.abc import Mapping
+from typing import Any
 
-from cmk.agent_based.legacy.v0_unstable import LegacyCheckDefinition
-from cmk.agent_based.v2 import equals, get_value_store, OIDEnd, SNMPTree, StringTable
+from cmk.agent_based.v2 import (
+    CheckPlugin,
+    CheckResult,
+    DiscoveryResult,
+    equals,
+    get_value_store,
+    OIDEnd,
+    Service,
+    SimpleSNMPSection,
+    SNMPTree,
+    StringTable,
+)
 from cmk.plugins.lib.cpu_util import check_cpu_util
 
-check_info = {}
-
 
-def discover_arris_cmts_cpu(info):
-    for oid_id, cpu_id, _cpu_idle_util in info:
+def discover_arris_cmts_cpu(section: StringTable) -> DiscoveryResult:
+    for oid_id, cpu_id, _cpu_idle_util in section:
         # Sadly the cpu_id seams empty. Referring to
         # the MIB, its slot id
         # Fallback to the oid end
-        yield cpu_id or str(int(oid_id) - 1), {}
+        yield Service(item=cpu_id or str(int(oid_id) - 1))
 
 
-def check_arris_cmts_cpu(item, params, info):
-    for oid_id, cpu_id, cpu_idle_util in info:
+def check_arris_cmts_cpu(item: str, params: Mapping[str, Any], section: StringTable) -> CheckResult:
+    for oid_id, cpu_id, cpu_idle_util in section:
         # see inventory function
         if cpu_id:
             citem = cpu_id
@@ -46,14 +54,19 @@ def parse_arris_cmts_cpu(string_table: StringTable) -> StringTable:
     return string_table
 
 
-check_info["arris_cmts_cpu"] = LegacyCheckDefinition(
+snmp_section_arris_cmts_cpu = SimpleSNMPSection(
     name="arris_cmts_cpu",
-    parse_function=parse_arris_cmts_cpu,
     detect=equals(".1.3.6.1.2.1.1.2.0", ".1.3.6.1.4.1.4998.2.1"),
     fetch=SNMPTree(
         base=".1.3.6.1.4.1.4998.1.1.5.3.1.1.1",
         oids=[OIDEnd(), "1", "8"],
     ),
+    parse_function=parse_arris_cmts_cpu,
+)
+
+
+check_plugin_arris_cmts_cpu = CheckPlugin(
+    name="arris_cmts_cpu",
     service_name="CPU utilization Module %s",
     discovery_function=discover_arris_cmts_cpu,
     check_function=check_arris_cmts_cpu,