19303 checkmk_agent check: Allow customizing the maximum time allowed since last update check

The check "Check_MK Agent" now allows for customizing the thresholds for the
maximum time elapsed since the last update check was performed. This was
previously internally set to warn after 2 days and was not able to be
customized.

As a result of this change, by default the check will continue to warn after 2
days, as before, but will now additionally go to critical state after 30 days.

This can be customized via the rule set "Checkmk agent installation
auditing".

-- End of Werk text --

SUP-27488

Change-Id: I3264a194c9233a88fdb7bbe455b69e630b2f83ea

Author: relrod

.werks/19303.md

@@ -0,0 +1,23 @@
+[//]: # (werk v2)
+# checkmk_agent check: Allow customizing the maximum time allowed since last update check
+
+key        | value
+---------- | ---
+date       | 2026-02-11T13:03:09+00:00
+version    | 2.4.0p22
+class      | feature
+edition    | cre
+component  | checks
+level      | 1
+compatible | no
+
+The check "Check_MK Agent" now allows for customizing the thresholds for the
+maximum time elapsed since the last update check was performed. This was
+previously internally set to warn after 2 days and was not able to be
+customized.
+
+As a result of this change, by default the check will continue to warn after 2
+days, as before, but will now additionally go to critical state after 30 days.
+
+This can now be customized via the rule set "Checkmk agent installation
+auditing".

cmk/gui/plugins/wato/check_parameters/checkmk_agent.py

@@ -13,7 +13,9 @@
     rulespec_registry,
     RulespecGroupCheckParametersApplications,
 )
+from cmk.gui.plugins.wato.utils.simple_levels import SimpleLevels
 from cmk.gui.valuespec import (
+    Age,
     CascadingDropdown,
     Dictionary,
     FixedValue,
@@ -286,6 +288,15 @@ def _parameter_valuespec_checkmk_agent():
                     % _("Local checks: versions"),
                 ),
             ),
+            (
+                "max_time_since_last_update_check",
+                SimpleLevels(
+                    Age,
+                    title=_("Maximum time since last update check"),
+                    help=_("Choose the maximum time to allow between last-update checks"),
+                    default_levels=(2 * 3600 * 24, 30 * 3600 * 24),
+                ),
+            ),
         ],
     )
 

cmk/plugins/collection/agent_based/checkmk_agent.py

@@ -384,7 +384,7 @@ def _check_cmk_agent_update(
         if (age := time.time() - last_check) >= 0:
             yield from check_levels_v1(
                 age,
-                levels_upper=(2 * 3600 * 24, None),  # type: ignore[arg-type]
+                levels_upper=params["max_time_since_last_update_check"],
                 render_func=render.timespan,
                 label="Time since last update check",
                 notice_only=True,
@@ -633,5 +633,6 @@ def check_checkmk_agent(
         # We want to use that very setting to check whether it is deployed correctly.
         # Don't try this hack at home, we are trained professionals.
         "only_from": ("cmk_postprocessed", "only_from", None),
+        "max_time_since_last_update_check": (2 * 3600 * 24, 30 * 3600 * 24),
     },
 )

tests/unit/cmk/plugins/collection/agent_based/test_checkmk_agent.py

@@ -484,7 +484,15 @@ def test_certificate_results(
     )
 
     with time_machine.travel(datetime(2001, 5, 25, 13, 13, 13, tzinfo=ZoneInfo("UTC"))):
-        assert [*_check_cmk_agent_update({}, None, section)] == [
+        assert [
+            *_check_cmk_agent_update(
+                {
+                    "max_time_since_last_update_check": (2 * 3600 * 24, 7 * 3600 * 24),
+                },
+                None,
+                section,
+            )
+        ] == [
             Result(state=State.OK, notice="Time since last update check: 2 hours 0 minutes"),
             Result(state=State.OK, notice="Last update check: 2001-05-25 11:13:00"),
             Result(state=State.OK, notice="Update URL: foo"),
@@ -497,7 +505,9 @@ def test_check_warn_upon_old_update_check(duplicate: bool) -> None:
     with time_machine.travel(datetime.fromtimestamp(1645800081.5039608, tz=ZoneInfo("UTC"))):
         actual = list(
             _check_cmk_agent_update(
-                {},
+                {
+                    "max_time_since_last_update_check": (2 * 3600 * 24, 7 * 3600 * 24),
+                },
                 {
                     "agentupdate": " ".join(
                         (1 + duplicate)
@@ -522,8 +532,8 @@ def test_check_warn_upon_old_update_check(duplicate: bool) -> None:
             details="503 Server Error: Service Unavailable\nSomething for second line",
         ),
         Result(
-            state=State.WARN,
-            summary="Time since last update check: 9 days 6 hours (warn/crit at 2 days 0 hours/never)",
+            state=State.CRIT,
+            summary="Time since last update check: 9 days 6 hours (warn/crit at 2 days 0 hours/7 days 0 hours)",
         ),
         Result(state=State.OK, notice="Last update check: 2022-02-16 08:28:01"),
         Result(state=State.OK, summary="Last update: 2022-02-16 08:29:41"),