drop abilitly to parse werk v3

this branch should not be able to parse v3 werks. with the previous
implementation it was possible to create a v3 werk, specify the v2
edition enumeration and still the validation would not complain.

the new implementation only allows parsing v3 werks when picking a werk
v3 werk.

this fix was verified by:

1) picking it on top of a8003a4
   and executing `./scripts/run-uvenv python -m cmk.werks.validate`
   which then shows "cmk.werks.error.WerkError: Markdown formatted werks
   need to start with header: '[//]: # (werk v2)\n'"
   this makes sure that the change validation of said commit would have
   failed.

2) reverting commit `a8003a4ce195c9dd3efe8863b803b1a462d01328` and
   executing `werk pick 8687b20` (the
   same commit on the master branch) to make sure picking werks from
   master still works, and the edition and werk version is adapted
   correctly.

CMK-31445

Change-Id: I60dd37e6040eba45a70b9a2d3a7211709e083f22

Author: BenediktSeidl

packages/cmk-werks/cmk/werks/__init__.py

@@ -7,20 +7,12 @@
 from .convert import werkv1_to_werkv2
 from .load import load_werk_v2
 from .models import Werk
-from .parse import (
-    parse_werk_v2,
-    parse_werk_v3,
-    WerkV2ParseResult,
-    WerkV3ParseResult,
-    WERK_V2_START,
-)
+from .parse import parse_werk_v2, WerkV2ParseResult
 
 
-def parse_werk(file_content: str, file_name: str) -> WerkV2ParseResult | WerkV3ParseResult:
+def parse_werk(file_content: str, file_name: str) -> WerkV2ParseResult:
     if file_name.endswith(".md"):
-        if file_content.startswith(WERK_V2_START):
-            return parse_werk_v2(file_content, file_name.removesuffix(".md"))
-        return parse_werk_v3(file_content, file_name.removesuffix(".md"))
+        return parse_werk_v2(file_content, file_name.removesuffix(".md"))
     file_content, werk_id = werkv1_to_werkv2(file_content, int(file_name))
     return parse_werk_v2(file_content, str(werk_id))  # TODO: str does not make sense!
 

packages/cmk-werks/cmk/werks/cli.py

@@ -30,7 +30,7 @@
 from .convert import werkv1_metadata_to_werkv2_metadata
 from .format import format_as_werk_v1, format_as_werk_v2
 from .models import EditionV3
-from .parse import WerkV2ParseResult, WerkV3ParseResult
+from .parse import parse_werk_v3, WERK_V3_START, WerkV2ParseResult, WerkV3ParseResult
 from .utils import edition_v3_to_v2
 
 T = TypeVar("T", bound="Stash")
@@ -478,24 +478,20 @@ def change_werk_version(werk_path: Path, new_version: str, werk_version: WerkVer
     git_add(werk)
 
 
-def adapt_werk_for_target_branch(werk_path: Path, werk_version: WerkVersion) -> None:
+def adapt_werk_for_target_branch(werk_path: Path) -> None:
     """Adapt a V3 werk to V2 format if the target branch uses V2 editions."""
-    werk = load_werk(werk_path)
-
-    if not isinstance(werk.content, WerkV3ParseResult):
-        return
 
-    # Check if target branch uses V2 editions
-    editions = get_config().editions
-    if editions and editions[0][0] in {e.value for e in EditionV3}:
+    if not werk_path.read_text().startswith(WERK_V3_START):
+        # not sure what werk this is, but it's not a werk v3
         return
 
-    werk.content.metadata["edition"] = edition_v3_to_v2(
-        EditionV3(werk.content.metadata["edition"])
+    parsed_werk = parse_werk_v3(werk_path.read_text(), werk_path.name)
+    parsed_werk.metadata["edition"] = edition_v3_to_v2(
+        EditionV3(parsed_werk.metadata["edition"])
     ).value
 
-    save_werk(werk, werk_version)
-    git_add(werk)
+    werk_path.write_text(format_as_werk_v2(parsed_werk))
+    git_add(load_werk(werk_path))
     sys.stdout.write(f"Adapted Werk {werk_path} from v3 to v2 format (converted edition names).\n")
 
 
@@ -1038,7 +1034,7 @@ def werk_cherry_pick(commit_id: str, no_commit: bool, werk_version: WerkVersion)
 
     if found_werk_path is not None:
         # Adapt V3 werks to V2 format if necessary (e.g., when picking from master to 2.4)
-        adapt_werk_for_target_branch(found_werk_path.source, werk_version)
+        adapt_werk_for_target_branch(found_werk_path.source)
 
         # Find werks that have been cherry-picked and change their version
         # to our current checkmk version.

packages/cmk-werks/cmk/werks/parse.py

@@ -103,7 +103,7 @@ def parse_werk_v3(content: str, werk_id: str) -> WerkV3ParseResult:
         raise WerkError(
             "Markdown formatted werks need to start with header: '[//]: # (werk v3)\\n'"
         )
-    # V3 has the same format as V2, just different header
+    # V3 has the same layout as V2, just different header
     v2_content = content.replace(WERK_V3_START, WERK_V2_START, 1)
     result = parse_werk_v2(v2_content, werk_id)
     return WerkV3ParseResult(result.metadata, result.description)