Skip to content

Commit 191ec2c

Browse files
refactor(dart): remove commented out bypass code
1 parent a75af48 commit 191ec2c

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

hw/arm/apple-silicon/dart.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ struct AppleDARTState {
206206
uint32_t l_shift[3];
207207
uint64_t sid_mask;
208208
uint32_t bypass_mask;
209-
// uint64_t bypass_address;
210209
uint32_t dart_options;
211210
};
212211

@@ -530,10 +529,7 @@ static IOMMUTLBEntry apple_dart_mapper_translate(IOMMUMemoryRegion *mr,
530529
TRANSLATION_ENABLE) == 0 ||
531530
FIELD_EX32(mapper->regs.sid_config[sid], DART_SID_CONFIG,
532531
FULL_BYPASS) != 0) {
533-
// if (s->bypass_address != 0) {
534-
// entry.translated_addr = s->bypass_address + addr,
535-
// entry.perm = IOMMU_RW;
536-
// }
532+
// TODO
537533
goto end;
538534
}
539535

@@ -706,8 +702,6 @@ AppleDARTState *apple_dart_from_node(AppleDTNode *node)
706702
apple_dt_get_prop_u32_or(node, "sids", 0xFFFF, &error_fatal);
707703
dart->bypass_mask =
708704
apple_dt_get_prop_u32_or(node, "bypass", 0, &error_fatal);
709-
// s->bypass_address =
710-
// apple_dt_get_prop_u64_or(node, "bypass-address", 0, &error_warn);
711705
dart->dart_options =
712706
apple_dt_get_prop_u32_or(node, "dart-options", 0, &error_fatal);
713707

0 commit comments

Comments
 (0)