Skip to content

Commit 37a33ce

Browse files
refactor(sep): remove some repetitive unnecessary comments
1 parent 4048196 commit 37a33ce

1 file changed

Lines changed: 13 additions & 18 deletions

File tree

  • hw/arm/apple-silicon

hw/arm/apple-silicon/sep.c

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3359,55 +3359,50 @@ AppleSEPState *apple_sep_create(DTBNode *node, MemoryRegion *ool_mr, vaddr base,
33593359
// AKF_MBOX reg is handled using the device tree
33603360
// XPRT_{PMSC,FUSE,MISC} regs are handled in t8030.c
33613361
memory_region_init_io(&s->pmgr_base_mr, OBJECT(dev), &pmgr_base_reg_ops, s,
3362-
"sep.pmgr_base", PMGR_BASE_REG_SIZE); // T8030
3362+
"sep.pmgr_base", PMGR_BASE_REG_SIZE);
33633363
sysbus_init_mmio(sbd, &s->pmgr_base_mr);
33643364
memory_region_init_io(&s->trng_regs_mr, OBJECT(dev), &trng_regs_reg_ops,
3365-
&s->trng_state, "sep.trng_regs",
3366-
TRNG_REGS_REG_SIZE); // T8030
3365+
&s->trng_state, "sep.trng_regs", TRNG_REGS_REG_SIZE);
33673366
sysbus_init_mmio(sbd, &s->trng_regs_mr);
33683367
memory_region_init_io(&s->key_base_mr, OBJECT(dev), &key_base_reg_ops, s,
3369-
"sep.key_base", KEY_BASE_REG_SIZE); // T8030
3368+
"sep.key_base", KEY_BASE_REG_SIZE);
33703369
sysbus_init_mmio(sbd, &s->key_base_mr);
33713370
memory_region_init_io(&s->key_fcfg_mr, OBJECT(dev), &key_fcfg_reg_ops, s,
3372-
"sep.key_fcfg", KEY_FCFG_REG_SIZE); // T8030
3371+
"sep.key_fcfg", KEY_FCFG_REG_SIZE);
33733372
sysbus_init_mmio(sbd, &s->key_fcfg_mr);
33743373
memory_region_init_io(&s->moni_base_mr, OBJECT(dev), &moni_base_reg_ops, s,
3375-
"sep.moni_base", MONI_BASE_REG_SIZE); // T8030
3374+
"sep.moni_base", MONI_BASE_REG_SIZE);
33763375
sysbus_init_mmio(sbd, &s->moni_base_mr);
33773376
memory_region_init_io(&s->moni_thrm_mr, OBJECT(dev), &moni_thrm_reg_ops, s,
3378-
"sep.moni_thrm", MONI_THRM_REG_SIZE); // T8030
3377+
"sep.moni_thrm", MONI_THRM_REG_SIZE);
33793378
sysbus_init_mmio(sbd, &s->moni_thrm_mr);
3380-
// EISP_BASE T8020/T8030
33813379
memory_region_init_io(&s->eisp_base_mr, OBJECT(dev), &eisp_base_reg_ops, s,
33823380
"sep.eisp_base", EISP_BASE_REG_SIZE);
33833381
sysbus_init_mmio(sbd, &s->eisp_base_mr);
33843382
memory_region_init_io(&s->eisp_hmac_mr, OBJECT(dev), &eisp_hmac_reg_ops, s,
3385-
"sep.eisp_hmac", EISP_HMAC_REG_SIZE); // T8030
3383+
"sep.eisp_hmac", EISP_HMAC_REG_SIZE);
33863384
sysbus_init_mmio(sbd, &s->eisp_hmac_mr);
33873385
memory_region_init_io(&s->aess_base_mr, OBJECT(dev), &aess_base_reg_ops,
3388-
&s->aess_state, "sep.aess_base",
3389-
AESS_BASE_REG_SIZE); // AESS_BASE T8030
3386+
&s->aess_state, "sep.aess_base", AESS_BASE_REG_SIZE);
33903387
sysbus_init_mmio(sbd, &s->aess_base_mr);
33913388
memory_region_init_io(&s->aesh_base_mr, OBJECT(dev), &aesh_base_reg_ops, s,
3392-
"sep.aesh_base", AESH_BASE_REG_SIZE); // T8030
3389+
"sep.aesh_base", AESH_BASE_REG_SIZE);
33933390
sysbus_init_mmio(sbd, &s->aesh_base_mr);
33943391
memory_region_init_io(&s->pka_base_mr, OBJECT(dev), &pka_base_reg_ops,
3395-
&s->pka_state, "sep.pka_base",
3396-
PKA_BASE_REG_SIZE); // PKA_BASE T8030
3392+
&s->pka_state, "sep.pka_base", PKA_BASE_REG_SIZE);
33973393
sysbus_init_mmio(sbd, &s->pka_base_mr);
33983394
memory_region_init_io(&s->pka_tmm_mr, OBJECT(dev), &pka_tmm_reg_ops, s,
3399-
"sep.pka_tmm", PKA_TMM_REG_SIZE); // T8030
3395+
"sep.pka_tmm", PKA_TMM_REG_SIZE);
34003396
sysbus_init_mmio(sbd, &s->pka_tmm_mr);
34013397
memory_region_init_io(&s->misc2_mr, OBJECT(dev), &misc2_reg_ops, s,
34023398
"sep.misc2", MISC2_REG_SIZE);
34033399
sysbus_init_mmio(sbd, &s->misc2_mr);
34043400
memory_region_init_io(&s->progress_mr, OBJECT(dev), &progress_reg_ops, s,
3405-
"sep.progress",
3406-
PROGRESS_REG_SIZE); // Encrypted progress counter?
3401+
"sep.progress", PROGRESS_REG_SIZE);
34073402
sysbus_init_mmio(sbd, &s->progress_mr);
34083403
memory_region_init_io(&s->boot_monitor_mr, OBJECT(dev),
34093404
&boot_monitor_reg_ops, s, "sep.boot_monitor",
3410-
BOOT_MONITOR_REG_SIZE); // T8030
3405+
BOOT_MONITOR_REG_SIZE);
34113406
sysbus_init_mmio(sbd, &s->boot_monitor_mr);
34123407
#ifdef SEP_ENABLE_DEBUG_TRACE_MAPPING
34133408
// TODO: Let's think about something for T8015

0 commit comments

Comments
 (0)