Skip to content

Luacontroller issues #185

@TheEt1234

Description

@TheEt1234

I think the name "logic"/"logic devices" shouldn't be used for them

  • i kinda wanted it to be named after mindustry's mlog but then like, i just kinda called everything that
  • but now its confusing because there are logic gates which have nothing to do with luacs
  • and the name is not accurate
  • A better name would be i guess to just call things like gpu/memcontroller/etc. to "luacontroller devices"
  • Also would need to re-name the mod, that can be done

Ele fabs should be deprecated

  • Instead there should probably be a separate machine for luanium, and a separate machine for assembling the machines, i think thats best

Luacontrollers should probably be rewritten entirely

  • get rid of the editor/main sandbox split i had, that was a mistake, just don't have the editor be so customizable by the user

  • functions like get_node/is_protected/etc. should do something like yield({cmd="get_node",pos=vector.new(x,y,z)}) instead of actually doing the action in the sandbox, this would be required if luacs were async

  • Instead of debug hooks that throw an error, maybe parse the code, and insert yields where needed

    • This will allow sandboxed code to be fast and a lot more reliable, so no random errors from the luac timing out
  • Luac code should be ran async, with luanti's IPC this may be possible

probably would require big breaking changes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions