Skip to content

Commit 89494fc

Browse files
authored
Merge pull request #61 from notoriousR-O-B/documentation_fixes
Minor documentation improvements
2 parents 612e968 + bbfcedd commit 89494fc

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

META.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "pg_roaringbitmap",
33
"abstract": "A Roaring Bitmap data type",
4-
"description": "This library contains a single PostgreSQL extension, a Roaring Bitmap data type called 'roaringbitmap', along with some convenience opperators and functions for constructing and handling Roaring Bitmap.",
4+
"description": "This library contains a single PostgreSQL extension, a Roaring Bitmap data type called 'roaringbitmap', along with some convenience operators and functions for constructing and handling Roaring Bitmaps.",
55
"version": "1.1.0",
66
"maintainer": [
77
"Chen Huajun <[email protected]>"

README.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# pg_roaringbitmap
22
RoaringBitmap extension for PostgreSQL.
33

4-
It's initial based on https://github.com/zeromax007/gpdb-roaringbitmap.
4+
This is originally based on https://github.com/zeromax007/gpdb-roaringbitmap.
55

66

77
# Introduction
8-
Roaring bitmaps are compressed bitmaps which tend to outperform conventional compressed bitmaps such as WAH, EWAH or Concise. In some instances, roaring bitmaps can be hundreds of times faster and they often offer significantly better compression. They can even be faster than uncompressed bitmaps. More information https://github.com/RoaringBitmap/CRoaring.
8+
Roaring bitmaps are compressed bitmaps which tend to outperform conventional compressed bitmaps such as WAH, EWAH or Concise. In some instances, roaring bitmaps can be hundreds of times faster and they often offer significantly better compression. They can even be faster than uncompressed bitmaps. More information at https://github.com/RoaringBitmap/CRoaring.
99

1010

1111
# Build
@@ -23,7 +23,7 @@ Note: The regression testing before the version release only covers PostgreSQL 1
2323
sudo make install
2424
psql -c "create extension roaringbitmap"
2525

26-
Note:You can use `make -f Makefile_native` instead of `make` to let the compiler use the SIMD instructions if it's supported by your CPU. In some scenarios, it may double the performance. But if you copy the `pg_roaringbitmap` binary which builded on machine with SIMD support to other machine without SIMD and run, you could get a SIGILL crash.
26+
Note: You can use `make -f Makefile_native` instead of `make` to let the compiler use SIMD instructions if your CPU supports them. In some scenarios, it may double the performance. But if you use the `pg_roaringbitmap` binary built with SIMD support on a machine without SIMD support, you could get a SIGILL crash.
2727

2828
## Test
2929

@@ -34,13 +34,13 @@ Note:You can use `make -f Makefile_native` instead of `make` to let the compiler
3434
## roaringbitmap
3535
### about roaringbitmap data type
3636

37-
Logically, you could think of roaringbitmap data type as `bit(4294967296)`, and it should be noted that
38-
the integers added to bitmaps is considered to be unsigned. Within bitmaps, numbers are ordered according to uint32. We order the numbers like 0, 1, ..., 2147483647, -2147483648, -2147483647,..., -1. But we use bigint to
37+
Logically, you could think of the roaringbitmap data type as `bit(4294967296)`, and it should be noted that
38+
the integers added to bitmaps are considered to be unsigned. Within bitmaps, numbers are ordered according to uint32. We order the numbers like 0, 1, ..., 2147483647, -2147483648, -2147483647,..., -1. But we use bigint to
3939
reference the range of these integers, that is [0 4294967296).
4040

4141
### input and ouput
4242

43-
Support two kind of input/output syntax 'array' and 'bytea',
43+
Two kinds of input/output syntax are supported: 'array' and 'bytea'.
4444
The default output format is 'bytea'.
4545

4646
postgres=# select roaringbitmap('{1,100,10}');
@@ -58,7 +58,7 @@ or
5858
(1 row)
5959

6060

61-
output format can changed by `roaringbitmap.output_format`
61+
The output format can changed with `roaringbitmap.output_format`
6262

6363
postgres=# set roaringbitmap.output_format='bytea';
6464
SET
@@ -118,10 +118,10 @@ or
118118

119119
SELECT rb_iterate('{1,2,3}'::roaringbitmap);
120120

121-
### Opperator List
121+
### Operator List
122122
<table>
123123
<thead>
124-
<th>Opperator</th>
124+
<th>Operator</th>
125125
<th>Input</th>
126126
<th>Output</th>
127127
<th>Desc</th>
@@ -280,7 +280,7 @@ or
280280
<td><code>rb_index</code></td>
281281
<td><code>roaringbitmap,integer</code></td>
282282
<td><code>bigint</code></td>
283-
<td>Return the 0-based index of element in this roaringbitmap, or -1 if do not exist</td>
283+
<td>Return the 0-based index of the element in this roaringbitmap, or -1 if not present</td>
284284
<td><code>rb_index('{1,2,3}',3)</code></td>
285285
<td><code>2</code></td>
286286
</tr>
@@ -425,7 +425,7 @@ or
425425
<td><code>roaringbitmap</code></td>
426426
<td><code>SET of integer</code></td>
427427
<td>Return set of integer from a roaringbitmap data.</td>
428-
<td><pre>rb_iterate(roaringbitmap('{1,2,3}'))</pre></td>
428+
<td><code>rb_iterate(roaringbitmap('{1,2,3}'))</code></td>
429429
<td><pre>1
430430
2
431431
3</pre></td>
@@ -523,13 +523,13 @@ or
523523
### about roaringbitmap64 data type
524524

525525
​​roaringbitmap64​​ is a 64-bit Roaring bitmap implementation, and its format definition can be found in https://github.com/RoaringBitmap/RoaringFormatSpec.
526-
Logically, you could think of roaringbitmap64 data type as `bit(18446744073709551615)` just like roaringbitmap, and it should be noted that
527-
the bigint data added to bitmaps is considered to be unsigned. Within 64 bit bitmaps, numbers are ordered according to uint64.
526+
Logically, you could think of the roaringbitmap64 data type as `bit(18446744073709551615)` just like roaringbitmap, and it should be noted that
527+
the bigint data added to bitmaps are considered to be unsigned. Within 64 bit bitmaps, numbers are ordered according to uint64.
528528
We order the numbers like 0, 1, ..., 9223372036854775807, -9223372036854775808, -9223372036854775807,..., -1.
529529

530530
### input and ouput
531531

532-
Support two kind of input/output syntax 'array' and 'bytea',
532+
Two kinds of input/output syntax are supported: 'array' and 'bytea'.
533533
The default output format is 'bytea'.
534534

535535
postgres=# select roaringbitmap64('{1,100,10}');
@@ -548,7 +548,7 @@ or
548548
(1 row)
549549

550550

551-
output format can changed by `roaringbitmap.output_format`
551+
The output format can changed with `roaringbitmap.output_format`
552552

553553
postgres=# set roaringbitmap.output_format='bytea';
554554
SET
@@ -608,10 +608,10 @@ or
608608

609609
SELECT rb64_iterate('{1,2,3}'::roaringbitmap64);
610610

611-
### Opperator List
611+
### Operator List
612612
<table>
613613
<thead>
614-
<th>Opperator</th>
614+
<th>Operator</th>
615615
<th>Input</th>
616616
<th>Output</th>
617617
<th>Desc</th>
@@ -770,7 +770,7 @@ or
770770
<td><code>rb64_index</code></td>
771771
<td><code>roaringbitmap64,bigint</code></td>
772772
<td><code>bigint</code></td>
773-
<td>Return the 0-based index of element in this roaringbitmap64, or -1 if do not exist</td>
773+
<td>Return the 0-based index of the element in this roaringbitmap64, or -1 if not present</td>
774774
<td><code>rb64_index('{1,2,3}',3)</code></td>
775775
<td><code>2</code></td>
776776
</tr>
@@ -915,7 +915,7 @@ or
915915
<td><code>roaringbitmap64</code></td>
916916
<td><code>SET of bigint</code></td>
917917
<td>Return set of bigint from a roaringbitmap64 data.</td>
918-
<td><pre>rb64_iterate(roaringbitmap64('{1,2,3}'))</pre></td>
918+
<td><code>rb64_iterate(roaringbitmap64('{1,2,3}'))</code></td>
919919
<td><pre>1
920920
2
921921
3</pre></td>

expected/roaringbitmap.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ select roaringbitmap('\x11'::bytea);
187187
ERROR: bitmap format is error
188188
select '\x11'::bytea::roaringbitmap;
189189
ERROR: bitmap format is error
190-
-- Test Opperator
190+
-- Test Operator
191191
select roaringbitmap('{}') & roaringbitmap('{}');
192192
?column?
193193
----------

expected/roaringbitmap64.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ select roaringbitmap64('{0,1,9999,2147483648,-2147483648,-2,-1}')::roaringbitmap
215215
ERROR: value "2147483648" is out of range for type integer
216216
select roaringbitmap64('{0,1,9999,2147483647,-2147483649,-2,-1}')::roaringbitmap;
217217
ERROR: value "-2147483649" is out of range for type integer
218-
-- Test Opperator
218+
-- Test Operator
219219
select roaringbitmap64('{}') & roaringbitmap64('{}');
220220
?column?
221221
----------

sql/roaringbitmap.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ select roaringbitmap('{1,9999,-88888}'::roaringbitmap::bytea);
5656
select roaringbitmap('\x11'::bytea);
5757
select '\x11'::bytea::roaringbitmap;
5858

59-
-- Test Opperator
59+
-- Test Operator
6060

6161
select roaringbitmap('{}') & roaringbitmap('{}');
6262
select roaringbitmap('{}') & roaringbitmap('{3,4,5}');

sql/roaringbitmap64.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ select '\x11'::bytea::roaringbitmap64;
6363
select roaringbitmap64('{0,1,9999,2147483648,-2147483648,-2,-1}')::roaringbitmap;
6464
select roaringbitmap64('{0,1,9999,2147483647,-2147483649,-2,-1}')::roaringbitmap;
6565

66-
-- Test Opperator
66+
-- Test Operator
6767

6868
select roaringbitmap64('{}') & roaringbitmap64('{}');
6969
select roaringbitmap64('{}') & roaringbitmap64('{3,4,5}');

0 commit comments

Comments
 (0)