Skip to content

Commit 0c6f8fd

Browse files
authored
make addproc backward compatable with exename change (#180)
make addproc backward compatable with exename change
1 parent 98d8987 commit 0c6f8fd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "AzManagers"
22
uuid = "db05ebb0-6096-11e9-199b-87b703361841"
33
authors = ["samtkaplan <[email protected]>"]
4-
version = "3.17.0"
4+
version = "3.17.1"
55

66
[deps]
77
AzSessions = "f239b30d-ae6b-58be-a2d5-7e9f30e280a9"

src/AzManagers.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2025,7 +2025,7 @@ function buildstartupscript_detached(manager::AzManager, exename::String, julia_
20252025

20262026
envstring = build_envstring(env)
20272027

2028-
juliaenvstring = remote_julia_environment_name == "" ? "" : """using Pkg; Pkg.activate(joinpath(Pkg.envdir(), "$remote_julia_environment_name")); """
2028+
juliaenvstring = remote_julia_environment_name == "" ? "" : """Pkg.activate(joinpath(Pkg.envdir(), "$remote_julia_environment_name")); """
20292029

20302030
#=
20312031
if exename is something like `mpirun -n 1 julia`, then we need to remove the `mpirun -n 1` part
@@ -2051,7 +2051,7 @@ function buildstartupscript_detached(manager::AzManager, exename::String, julia_
20512051
export OMP_NUM_THREADS=$omp_num_threads
20522052
ssh-keygen -f /home/$user/.ssh/azmanagers_rsa -N '' <<<y
20532053
cd /home/$user
2054-
$exename_nompi -t $julia_num_threads -e '$(juliaenvstring)try using AzManagers; catch; using Pkg; Pkg.instantiate(); using AzManagers; end; AzManagers.mount_datadisks(); AzManagers.build_lvm(); AzManagers.detached_port!($(AzManagers.detached_port())); AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname", exename="$exename")'
2054+
$exename_nompi -t $julia_num_threads -e 'using Pkg; $(juliaenvstring)try using AzManagers; catch; Pkg.instantiate(); using AzManagers; end; AzManagers.mount_datadisks(); AzManagers.build_lvm(); AzManagers.detached_port!($(AzManagers.detached_port())); if Pkg.dependencies()[Base.UUID("db05ebb0-6096-11e9-199b-87b703361841")].version >= v"3.17"; AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname", exename="$exename"); else @warn "exename not supported in Azmanagers < 3.17"; AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname"); end'
20552055
EOF
20562056
"""
20572057

@@ -2083,7 +2083,7 @@ function buildstartupscript_detached(manager::AzManager, exename::String, julia_
20832083
export OMP_NUM_THREADS=$omp_num_threads
20842084
ssh-keygen -f /home/$user/.ssh/azmanagers_rsa -N '' <<<y
20852085
cd /home/$user
2086-
$exename_nompi -t $julia_num_threads -e '$(juliaenvstring)try using AzManagers; catch; using Pkg; Pkg.instantiate(); using AzManagers; end; AzManagers.mount_datadisks(); AzManagers.detached_port!($(AzManagers.detached_port())); AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname", exename="$exename")'
2086+
$exename_nompi -t $julia_num_threads -e 'using Pkg; $(juliaenvstring)try using AzManagers; catch; Pkg.instantiate(); using AzManagers; end; AzManagers.mount_datadisks(); AzManagers.detached_port!($(AzManagers.detached_port())); if Pkg.dependencies()[Base.UUID("db05ebb0-6096-11e9-199b-87b703361841")].version >= v"3.17"; AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname", exename="$exename"); else @warn "exename not supported in Azmanagers < 3.17"; AzManagers.detachedservice(;subscriptionid="$subscriptionid", resourcegroup="$resourcegroup", vmname="$vmname"); end'
20872087
EOF
20882088
"""
20892089
cmd = shell_cmds
@@ -3388,7 +3388,7 @@ function detached_run(code, ip::String="", port=detached_port();
33883388
serialize(io, variablebundle())
33893389
body = Dict(
33903390
"persist" => persist,
3391-
"exename" => vm["exename"],
3391+
"exename" => get(vm, "exename", "julia"),
33923392
"variablebundle" => base64encode(take!(io)),
33933393
"code" => """
33943394
$code

0 commit comments

Comments
 (0)