Skip to content

make MPI optional through julia extension#206

Merged
samtkaplan merged 1 commit intoChevronETC:masterfrom
mloubout:mpi-as-ext
Sep 2, 2025
Merged

make MPI optional through julia extension#206
samtkaplan merged 1 commit intoChevronETC:masterfrom
mloubout:mpi-as-ext

Conversation

@mloubout
Copy link
Contributor

@mloubout mloubout commented Aug 25, 2025

Move all the mpi code into an MPI extension that only gets loaded when using MPI is called. This will allow to use serial devito without having to worry about an MPI preferences or library.

MPI extension is tested as well.

All tests passs locally, might need few tweaks for CI

Testing decoupler as well

@samtkaplan
Copy link
Member

Thanks @mloubout , this is looking great. one question: can we remove MPIPreferences from the deps? In my quick scan through the changes I don't think it is needed, but I may have missed something. Thanks.

@mloubout
Copy link
Contributor Author

can we remove MPIPreferences from the deps?

I'm not sure. It's needed because of the extension and extensions don't accept dependencies. So to be able to set the preference for the extension the only seems to be to keep it. Not sure what a woraround would be.

Concerning the Pro/decoupler tests, i think it will only be tested once merged because the secrets are (rightfully) locked to you guys only, so you might wanna check the pro tests still work on your side.

@samtkaplan samtkaplan mentioned this pull request Aug 28, 2025
1 task
@samtkaplan
Copy link
Member

@mloubout I made an alternative PR over here: #207. I'm not sure how to add you as a reviewer to that one, but if you have time I would appreciate a look.

@samtkaplan samtkaplan merged commit 32736ca into ChevronETC:master Sep 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants