make MPI optional through julia extension#206
Merged
samtkaplan merged 1 commit intoChevronETC:masterfrom Sep 2, 2025
Merged
Conversation
Member
|
Thanks @mloubout , this is looking great. one question: can we remove MPIPreferences from the deps? In my quick scan through the changes I don't think it is needed, but I may have missed something. Thanks. |
Contributor
Author
I'm not sure. It's needed because of the extension and extensions don't accept dependencies. So to be able to set the preference for the extension the only seems to be to keep it. Not sure what a woraround would be. Concerning the Pro/decoupler tests, i think it will only be tested once merged because the secrets are (rightfully) locked to you guys only, so you might wanna check the pro tests still work on your side. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all the mpi code into an MPI extension that only gets loaded when
using MPIis called. This will allow to use serial devito without having to worry about an MPI preferences or library.MPI extension is tested as well.
All tests passs locally, might need few tweaks for CI
Testing decoupler as well