fix removedc bug

make a note of a failing unit test on windows.

Author: samtkaplan

src/jop_removedc.jl

@@ -20,7 +20,7 @@ function JopRemoveDC_df!(d::AbstractArray{T,2}, m::AbstractArray{T,2}; kwargs...
         mean = sum(_m[:,k2]) / length(_m[:,k2])
         _d[:,k2] .= _m[:,k2] .- mean
     end
-    _d
+    d
 end
 
 function JopRemoveDC_df′!(m::AbstractArray{T,2}, d::AbstractArray{T,2}; kwargs...) where {T}
@@ -32,5 +32,5 @@ function JopRemoveDC_df′!(m::AbstractArray{T,2}, d::AbstractArray{T,2}; kwargs
         mean = sum(_d[:,k2]) / length(_d[:,k2])
         _m[:,k2] .= _d[:,k2] .- mean
     end
-    _m
+    m
 end

test/jop_removedc.jl

@@ -19,7 +19,17 @@ end
 end
 
 @testset "JopRemoveDC, dot product test, T=$T" for T in (Float32,Float64,Complex{Float32},Complex{Float64})
-    A = JopRemoveDC(JetSpace(T,n1,n2))
-    lhs,rhs = dot_product_test(A, rand(domain(A)), rand(range(A)))
-    @test lhs ≈ rhs
+    #=
+    I observe the following bug on windows:
+    x = rand(Complex{Float64},101,201)
+    using LinearAlgebra
+    dot(x,x) # crashes Julia, presumably due to an issue with BLAS on windows.
+    =#
+    if Sys.iswindows() && T == Complex{Float64}
+        @warn "dot product test fails on Windows due to the LinearAlgebra.dot method not working for Complex{Float64}"
+    else
+        A = JopRemoveDC(JetSpace(T,n1,n2))
+        lhs,rhs = dot_product_test(A, rand(domain(A)), rand(range(A)))
+        @test lhs ≈ rhs
+    end
 end