update create_coin hint test to use a list (#8628)

* update create_coin hint test to use a list

* the hint/memo is always included in the CREATE_COIN conditions now

Author: arvidn

tests/core/full_node/test_mempool.py

@@ -1818,7 +1818,7 @@ def test_create_coin_different_parent(self):
             assert c.conditions == [
                 (
                     opcode.value,
-                    [ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([10])])],
+                    [ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([10]), b""])],
                 )
             ]
 
@@ -1832,11 +1832,11 @@ def test_create_coin_different_puzzhash(self):
         assert len(npc_result.npc_list) == 1
         opcode = ConditionOpcode.CREATE_COIN
         assert (
-            ConditionWithArgs(opcode, [puzzle_hash_1.encode("ascii"), bytes([5])])
+            ConditionWithArgs(opcode, [puzzle_hash_1.encode("ascii"), bytes([5]), b""])
             in npc_result.npc_list[0].conditions[0][1]
         )
         assert (
-            ConditionWithArgs(opcode, [puzzle_hash_2.encode("ascii"), bytes([5])])
+            ConditionWithArgs(opcode, [puzzle_hash_2.encode("ascii"), bytes([5]), b""])
             in npc_result.npc_list[0].conditions[0][1]
         )
 
@@ -1849,19 +1849,19 @@ def test_create_coin_different_amounts(self):
         assert len(npc_result.npc_list) == 1
         opcode = ConditionOpcode.CREATE_COIN
         assert (
-            ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([5])])
+            ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([5]), b""])
             in npc_result.npc_list[0].conditions[0][1]
         )
         assert (
-            ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([4])])
+            ConditionWithArgs(opcode, [puzzle_hash.encode("ascii"), bytes([4]), b""])
             in npc_result.npc_list[0].conditions[0][1]
         )
 
     def test_create_coin_with_hint(self):
         # CREATE_COIN
         puzzle_hash_1 = "abababababababababababababababab"
         hint = "12341234123412341234213421341234"
-        npc_result = generator_condition_tester(f'(51 "{puzzle_hash_1}" 5 "{hint}")')
+        npc_result = generator_condition_tester(f'(51 "{puzzle_hash_1}" 5 ("{hint}"))')
         assert npc_result.error is None
         assert len(npc_result.npc_list) == 1
         opcode = ConditionOpcode.CREATE_COIN

tests/generator/test_rom.py

@@ -103,7 +103,7 @@ def test_get_name_puzzle_conditions(self):
         npc_result = get_name_puzzle_conditions(gen, max_cost=MAX_COST, cost_per_byte=COST_PER_BYTE, safe_mode=False)
         assert npc_result.error is None
         assert npc_result.clvm_cost == EXPECTED_COST
-        cond_1 = ConditionWithArgs(ConditionOpcode.CREATE_COIN, [bytes([0] * 31 + [1]), int_to_bytes(500)])
+        cond_1 = ConditionWithArgs(ConditionOpcode.CREATE_COIN, [bytes([0] * 31 + [1]), int_to_bytes(500), b""])
         CONDITIONS = [
             (ConditionOpcode.CREATE_COIN, [cond_1]),
         ]