Skip to content

Commit 39764bb

Browse files
committed
use log.exception() instead of log.error() and log.warning() when logging exceptions
1 parent 8d53bbc commit 39764bb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

chia/plot_sync/receiver.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ def __init__(
113113
async def trigger_callback(self, update: Optional[Delta] = None) -> None:
114114
try:
115115
await self._update_callback(self._connection.peer_node_id, update)
116-
except Exception as e:
117-
log.error(f"_update_callback: node_id {self.connection().peer_node_id}, raised {e}")
116+
except Exception:
117+
log.exception(f"_update_callback: node_id {self.connection().peer_node_id}")
118118

119119
def reset(self) -> None:
120120
log.info(f"reset: node_id {self.connection().peer_node_id}, current_sync: {self._current_sync}")
@@ -181,13 +181,13 @@ async def send_response(plot_sync_error: Optional[PlotSyncError] = None) -> None
181181
await method(message)
182182
await send_response()
183183
except InvalidIdentifierError as e:
184-
log.warning(f"_process: node_id {self.connection().peer_node_id}, InvalidIdentifierError {e}")
184+
log.exception(f"_process: node_id {self.connection().peer_node_id}")
185185
await send_response(PlotSyncError(int16(e.error_code), f"{e}", e.expected_identifier))
186186
except PlotSyncException as e:
187-
log.warning(f"_process: node_id {self.connection().peer_node_id}, Error {e}")
187+
log.exception(f"_process: node_id {self.connection().peer_node_id}")
188188
await send_response(PlotSyncError(int16(e.error_code), f"{e}", None))
189189
except Exception as e:
190-
log.warning(f"_process: node_id {self.connection().peer_node_id}, Exception {e}")
190+
log.exception(f"_process: node_id {self.connection().peer_node_id}")
191191
await send_response(PlotSyncError(int16(ErrorCodes.unknown), f"{e}", None))
192192

193193
def _validate_identifier(self, identifier: PlotSyncIdentifier, start: bool = False) -> None:

chia/plotting/manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,8 @@ def _refresh_task(self, sleep_interval_ms: int):
278278
f"total_result.removed {len(total_result.removed)}, "
279279
f"total_duration {total_result.duration:.2f} seconds"
280280
)
281-
except Exception as e:
282-
log.error(f"_refresh_callback raised: {e} with the traceback: {traceback.format_exc()}")
281+
except Exception:
282+
log.exception("_refresh_callback raised")
283283
self.reset()
284284

285285
def refresh_batch(self, plot_paths: list[Path], plot_directories: set[Path]) -> PlotRefreshResult:

0 commit comments

Comments
 (0)