use spend() as pyo3 doesn't support property

Author: matt-o-how

chia/_tests/blockchain/test_blockchain.py

@@ -2076,7 +2076,7 @@ async def test_timelock_conditions(
             if expected == AddBlockResult.NEW_PEAK:
                 # ensure coin was in fact spent
                 c = await b.coin_store.get_coin_record(coin.name())
-                assert c is not None and c.spent
+                assert c is not None and c.spent()
 
     @pytest.mark.anyio
     @pytest.mark.parametrize(
@@ -2286,10 +2286,10 @@ async def test_ephemeral_timelock(
             if expected == AddBlockResult.NEW_PEAK:
                 # ensure coin1 was in fact spent
                 c = await b.coin_store.get_coin_record(coin1.name())
-                assert c is not None and c.spent
+                assert c is not None and c.spent()
                 # ensure coin2 was NOT spent
                 c = await b.coin_store.get_coin_record(coin2.name())
-                assert c is not None and not c.spent
+                assert c is not None and not c.spent()
 
     @pytest.mark.anyio
     async def test_not_tx_block_but_has_data(self, empty_blockchain: Blockchain, bt: BlockTools) -> None:
@@ -3103,9 +3103,9 @@ async def test_double_spent_in_reorg(self, empty_blockchain: Blockchain, bt: Blo
 
         # ephemeral coin is spent
         first_coin = await b.coin_store.get_coin_record(new_coin.name())
-        assert first_coin is not None and first_coin.spent
+        assert first_coin is not None and first_coin.spent()
         second_coin = await b.coin_store.get_coin_record(tx_2.additions()[0].name())
-        assert second_coin is not None and not second_coin.spent
+        assert second_coin is not None and not second_coin.spent()
 
         farmer_coin = create_farmer_coin(
             blocks_reorg[-1].height,
@@ -3121,7 +3121,7 @@ async def test_double_spent_in_reorg(self, empty_blockchain: Blockchain, bt: Blo
         await _validate_and_add_block(b, blocks_reorg[-1])
 
         farmer_coin_record = await b.coin_store.get_coin_record(farmer_coin.name())
-        assert farmer_coin_record is not None and farmer_coin_record.spent
+        assert farmer_coin_record is not None and farmer_coin_record.spent()
 
     @pytest.mark.anyio
     async def test_minting_coin(self, empty_blockchain: Blockchain, bt: BlockTools) -> None:

chia/_tests/clvm/coin_store.py

@@ -130,7 +130,7 @@ def all_coins(self) -> Iterator[Coin]:
 
     def all_unspent_coins(self) -> Iterator[Coin]:
         for coin_entry in self._db.values():
-            if not coin_entry.spent:
+            if not coin_entry.spent():
                 yield coin_entry.coin
 
     def _add_coin_entry(self, coin: Coin, birthday: CoinTimestamp) -> None:

chia/_tests/core/full_node/stores/test_coin_store.py

@@ -138,20 +138,20 @@ async def test_basic_coin_store(db_version: int, softfork_height: uint32, bt: Bl
                 # Check that the coinbase rewards are added
                 record = await coin_store.get_coin_record(expected_coin.name())
                 assert record is not None
-                assert not record.spent
+                assert not record.spent()
                 assert record.coin == expected_coin
                 all_records.add(record)
             for coin_name in tx_removals:
                 # Check that the removed coins are set to spent
                 record = await coin_store.get_coin_record(coin_name)
                 assert record is not None
-                assert record.spent
+                assert record.spent()
                 all_records.add(record)
             for coin_id, coin, _ in tx_additions:
                 # Check that the added coins are added
                 record = await coin_store.get_coin_record(coin_id)
                 assert record is not None
-                assert not record.spent
+                assert not record.spent()
                 assert coin == record.coin
                 all_records.add(record)
 
@@ -200,7 +200,7 @@ async def test_set_spent(db_version: int, bt: BlockTools) -> None:
             records = [await coin_store.get_coin_record(coin.name()) for coin in coins]
             for record in records:
                 assert record is not None
-                assert record.spent
+                assert record.spent()
                 assert record.spent_block_index == block.height
 
 
@@ -268,9 +268,9 @@ async def test_rollback(db_version: int, bt: BlockTools) -> None:
                     and selected_coin.name == record.name
                     and not selected_coin.confirmed_block_index < block.height
                 ):
-                    assert not record.spent
+                    assert not record.spent()
                 else:
-                    assert record.spent
+                    assert record.spent()
                     assert record.spent_block_index == block.height
 
             if spend_selected_coin:
@@ -303,7 +303,7 @@ async def test_rollback(db_version: int, bt: BlockTools) -> None:
             if block.height <= reorg_index:
                 for record in records:
                     assert record is not None
-                    assert record.spent == (record.name != selected_coin.name)
+                    assert record.spent() == (record.name != selected_coin.name)
             else:
                 for record in records:
                     assert record is None
@@ -334,7 +334,7 @@ async def test_basic_reorg(tmp_dir: Path, db_version: int, bt: BlockTools) -> No
                     records = [await coin_store.get_coin_record(coin.name()) for coin in coins]
                     for record in records:
                         assert record is not None
-                        assert not record.spent
+                        assert not record.spent()
                         assert record.confirmed_block_index == block.height
                         assert record.spent_block_index == 0
 
@@ -359,7 +359,7 @@ async def test_basic_reorg(tmp_dir: Path, db_version: int, bt: BlockTools) -> No
                         records = [await coin_store.get_coin_record(coin.name()) for coin in coins]
                         for record in records:
                             assert record is not None
-                            assert not record.spent
+                            assert not record.spent()
                             assert record.confirmed_block_index == reorg_block.height
                             assert record.spent_block_index == 0
             peak = b.get_peak()

chia/_tests/core/test_full_node_rpc.py

@@ -198,7 +198,7 @@ async def test1(
         assert coin in compute_additions(coin_spend)
 
         assert len(await client.get_coin_records_by_puzzle_hash(ph_receiver)) == 1
-        assert len(list(filter(lambda cr: not cr.spent, (await client.get_coin_records_by_puzzle_hash(ph))))) == 3
+        assert len(list(filter(lambda cr: not cr.spent(), (await client.get_coin_records_by_puzzle_hash(ph))))) == 3
         assert len(await client.get_coin_records_by_puzzle_hashes([ph_receiver, ph])) == 5
         assert len(await client.get_coin_records_by_puzzle_hash(ph, False)) == 3
         assert len(await client.get_coin_records_by_puzzle_hash(ph, True)) == 4

chia/_tests/wallet/rpc/test_wallet_rpc.py

@@ -1464,7 +1464,7 @@ async def test_get_coin_records_by_names(wallet_rpc_environment: WalletRpcTestEn
     # Prepare some records and parameters first
     result = await store.get_coin_records()
     coins = {record.coin for record in result.records}
-    coins_unspent = {record.coin for record in result.records if not record.spent}
+    coins_unspent = {record.coin for record in result.records if not record.spent()}
     coin_ids = [coin.name() for coin in coins]
     coin_ids_unspent = [coin.name() for coin in coins_unspent]
     assert len(coin_ids) > 0

chia/_tests/wallet/test_singleton_lifecycle_fast.py

@@ -424,7 +424,7 @@ def create_throwaway_pubkey(seed: bytes) -> G1Element:
 def assert_coin_spent(coin_store: CoinStore, coin: Coin, is_spent: bool = True) -> None:
     coin_record = coin_store.coin_record(coin.name())
     assert coin_record is not None
-    assert coin_record.spent is is_spent
+    assert coin_record.spent() is is_spent
 
 
 def spend_coin_to_singleton(

chia/_tests/wallet/test_wallet.py

@@ -1885,11 +1885,11 @@ async def test_wallet_tx_reorg(self, wallet_environments: WalletTestFramework) -
         added_1 = tx_record.additions[1]
         wallet_coin_record_rem = await wsm.coin_store.get_coin_record(removed.name())
         assert wallet_coin_record_rem is not None
-        assert wallet_coin_record_rem.spent
+        assert wallet_coin_record_rem.spent()
 
         coin_record_full_node = await full_node_api.full_node.coin_store.get_coin_record(removed.name())
         assert coin_record_full_node is not None
-        assert coin_record_full_node.spent
+        assert coin_record_full_node.spent()
         add_1_coin_record_full_node = await full_node_api.full_node.coin_store.get_coin_record(added.name())
         assert add_1_coin_record_full_node is not None
         assert add_1_coin_record_full_node.confirmed_block_index > 0

chia/_tests/wallet/test_wallet_coin_store.py

@@ -202,9 +202,9 @@ async def test_set_spent() -> None:
         store = await WalletCoinStore.create(db_wrapper)
         await store.add_coin_record(record_1)
 
-        assert not (await store.get_coin_record(coin_1.name())).spent
+        assert not (await store.get_coin_record(coin_1.name())).spent()
         await store.set_spent(coin_1.name(), uint32(12))
-        assert (await store.get_coin_record(coin_1.name())).spent
+        assert (await store.get_coin_record(coin_1.name())).spent()
         assert (await store.get_coin_record(coin_1.name())).spent_block_height == 12
 
 
@@ -908,7 +908,7 @@ async def test_rollback_to_block() -> None:
         await store.rollback_to_block(6)
 
         new_r5 = await store.get_coin_record(coin_5.name())
-        assert not new_r5.spent
+        assert not new_r5.spent()
         assert new_r5.spent_block_height == 0
         assert new_r5 != r5
 
@@ -918,7 +918,7 @@ async def test_rollback_to_block() -> None:
 
         assert await store.get_coin_record(coin_5.name()) is None
         new_r4 = await store.get_coin_record(coin_4.name())
-        assert not new_r4.spent
+        assert not new_r4.spent()
         assert new_r4.spent_block_height == 0
         assert new_r4 != r4
 

chia/cmds/sim_funcs.py

@@ -337,7 +337,7 @@ def print_coin_record(
     print(f"Coin 0x{coin_record.name.hex()}")
     print(f"Wallet Address: {coin_address}")
     print(f"Confirmed at block: {coin_record.confirmed_block_index}")
-    print(f"Spent: {f'at Block {coin_record.spent_block_index}' if coin_record.spent else 'No'}")
+    print(f"Spent: {f'at Block {coin_record.spent_block_index}' if coin_record.spent() else 'No'}")
     print(f"Coin Amount: {coin_record.coin.amount} {name}")
     print(f"Parent Coin ID: 0x{coin_record.coin.parent_coin_info.hex()}")
     print(f"Created at: {datetime.fromtimestamp(float(coin_record.timestamp)).strftime('%Y-%m-%d %H:%M:%S')}\n")

chia/consensus/block_body_validation.py

@@ -482,7 +482,7 @@ async def validate_block_body(
         if unspent.confirmed_block_index <= fork_info.fork_height:
             # Spending something in the current chain, confirmed before fork
             # (We ignore all coins confirmed after fork)
-            if unspent.spent == 1 and unspent.spent_block_index <= fork_info.fork_height:
+            if unspent.spent() == 1 and unspent.spent_block_index <= fork_info.fork_height:
                 # Check for coins spent in an ancestor block
                 return Err.DOUBLE_SPEND
             removal_coin_records[unspent.name] = unspent