-prevent responding to own trade

-failures now have reasons attached

Author: matt-o-how

src/wallet/trade_manager.py

@@ -228,6 +228,9 @@ async def respond_to_offer(self, file_path: Path) -> bool:
                         ] = await self.wallet_state_manager.get_wallet_for_colour(
                             colour
                         )
+                    unspent = await self.wallet_state_manager.get_spendable_coins_for_wallet(wallets[colour].wallet_info.id)
+                    if coinsol.coin in [record.coin for record in unspent]:
+                        return False, "can't respond to own offer"
                     innerpuzzlereveal = solution.rest().rest().rest().first()
                     innersol = solution.rest().rest().rest().rest().first()
                     out_amount = cc_wallet_puzzles.get_output_amount_for_puzzle_and_solution(
@@ -267,6 +270,9 @@ async def respond_to_offer(self, file_path: Path) -> bool:
                     coinsols.append(coinsol)
             else:
                 # standard chia coin
+                unspent = await self.wallet_state_manager.get_spendable_coins_for_wallet(1)
+                if coinsol.coin in [record.coin for record in unspent]:
+                    return False, "can't respond to own offer"
                 if chia_discrepancy is None:
                     chia_discrepancy = cc_wallet_puzzles.get_output_discrepancy_for_puzzle_and_solution(
                         coinsol.coin, puzzle, solution
@@ -309,7 +315,7 @@ async def respond_to_offer(self, file_path: Path) -> bool:
                         my_cc_spends.add(add)
 
             if my_cc_spends == set() or my_cc_spends is None:
-                return False
+                return False, "insufficient funds"
 
             auditor = my_cc_spends.pop()
             auditor_inner_puzzle = await self.get_inner_puzzle_for_puzzle_hash(
@@ -570,4 +576,4 @@ async def respond_to_offer(self, file_path: Path) -> bool:
         for tx in my_tx_records:
             await self.wallet_state_manager.add_transaction(tx)
 
-        return True
+        return True, None

src/wallet/websocket_server.py

@@ -464,8 +464,11 @@ async def create_offer_for_ids(self, websocket, request, response_api):
 
     async def respond_to_offer(self, websocket, request, response_api):
         file_path = Path(request["filename"])
-        success = await self.trade_manager.respond_to_offer(file_path)
-        response = {"success": success}
+        success, reason = await self.trade_manager.respond_to_offer(file_path)
+        if success:
+            response = {"success": success}
+        else:
+            response = {"success": success, "reason": reason}
         return await websocket.send(format_response(response_api, response))
 
     async def safe_handle(self, websocket, path):