rename to DataStore.prefer_db_kv_blob_length (#19692)

Author: altendky

chia/_tests/core/data_layer/test_data_store.py

@@ -2184,7 +2184,7 @@ async def test_basic_key_value_db_vs_disk_cutoff(
     seeded_random: random.Random,
     size_offset: int,
 ) -> None:
-    size = data_store.prefer_file_kv_blob_length + size_offset
+    size = data_store.prefer_db_kv_blob_length + size_offset
 
     blob = bytes(seeded_random.getrandbits(8) for _ in range(size))
     blob_hash = bytes32(sha256(blob).digest())
@@ -2219,13 +2219,13 @@ async def test_changing_key_value_db_vs_disk_cutoff(
     size_offset: int,
     limit_change: int,
 ) -> None:
-    size = data_store.prefer_file_kv_blob_length + size_offset
+    size = data_store.prefer_db_kv_blob_length + size_offset
 
     blob = bytes(seeded_random.getrandbits(8) for _ in range(size))
     async with data_store.db_wrapper.writer() as writer:
         kv_id = await data_store.add_kvid(blob=blob, store_id=store_id, writer=writer)
 
-    data_store.prefer_file_kv_blob_length += limit_change
+    data_store.prefer_db_kv_blob_length += limit_change
     retrieved_blob = await data_store.get_blob_from_kvid(kv_id=kv_id, store_id=store_id)
 
     assert blob == retrieved_blob
@@ -2240,7 +2240,7 @@ async def test_get_keys_both_disk_and_db(
     inserted_keys: set[bytes] = set()
 
     for size_offset in [-1, 0, 1]:
-        size = data_store.prefer_file_kv_blob_length + size_offset
+        size = data_store.prefer_db_kv_blob_length + size_offset
 
         blob = bytes(seeded_random.getrandbits(8) for _ in range(size))
         await data_store.insert(key=blob, value=b"", store_id=store_id, status=Status.COMMITTED)
@@ -2260,7 +2260,7 @@ async def test_get_keys_values_both_disk_and_db(
     inserted_keys_values: dict[bytes, bytes] = {}
 
     for size_offset in [-1, 0, 1]:
-        size = data_store.prefer_file_kv_blob_length + size_offset
+        size = data_store.prefer_db_kv_blob_length + size_offset
 
         key = bytes(seeded_random.getrandbits(8) for _ in range(size))
         value = bytes(seeded_random.getrandbits(8) for _ in range(size))

chia/data_layer/data_store.py

@@ -81,7 +81,7 @@ class DataStore:
     recent_merkle_blobs: LRUCache[bytes32, MerkleBlob]
     merkle_blobs_path: Path
     key_value_blobs_path: Path
-    prefer_file_kv_blob_length: int = 4096
+    prefer_db_kv_blob_length: int = 4096
 
     @classmethod
     @contextlib.asynccontextmanager
@@ -566,7 +566,7 @@ async def insert_root_from_merkle_blob(
         return await self._insert_root(store_id, root_hash, status)
 
     def _use_file_for_new_kv_blob(self, blob: bytes) -> bool:
-        return len(blob) > self.prefer_file_kv_blob_length
+        return len(blob) > self.prefer_db_kv_blob_length
 
     async def get_kvid(self, blob: bytes, store_id: bytes32) -> Optional[KeyOrValueId]:
         blob_hash = bytes32(sha256(blob).digest())