change to Assertion errors

Author: almogdepaz

chia/_tests/plotting/test_prover.py

@@ -26,9 +26,9 @@ def test_v2_prover_get_memo_raises_error(self) -> None:
         with pytest.raises(NotImplementedError, match="V2 plot format is not yet implemented"):
             prover.get_memo()
 
-    def test_v2_prover_get_compression_level_raises_error(self) -> None:
+    def test_v2_prover_get_compression_level_raises_assertion_error(self) -> None:
         prover = V2Prover("/nonexistent/path/test.plot2")
-        with pytest.raises(NotImplementedError, match="V2 plot format does not support compression level"):
+        with pytest.raises(AssertionError, match="get_compression_level\\(\\) should never be called on V2 plots"):
             prover.get_compression_level()
 
     def test_v2_prover_get_id_raises_error(self) -> None:

chia/farmer/farmer.py

@@ -143,7 +143,7 @@ def __init__(
         # Quality string to plot identifier and challenge_hash, for use with harvester.RequestSignatures
         self.quality_str_to_identifiers: dict[bytes32, tuple[str, bytes32, bytes32, bytes32]] = {}
 
-        # Track pending solver requests, keyed by quality string hex
+        # Track pending solver requests, keyed by partial proof
         self.pending_solver_requests: dict[bytes, dict[str, Any]] = {}
 
         # number of responses to each signage point

chia/plotting/prover.py

@@ -56,7 +56,7 @@ def get_memo(self) -> bytes:
         raise NotImplementedError("V2 plot format is not yet implemented")
 
     def get_compression_level(self) -> uint8:
-        raise NotImplementedError("V2 plot format does not support compression level")
+        raise AssertionError("get_compression_level() should never be called on V2 plots")
 
     def get_version(self) -> PlotVersion:
         return PlotVersion.V2
@@ -78,8 +78,7 @@ def get_partial_proofs_for_challenge(self, challenge: bytes32) -> list[bytes]:
         raise NotImplementedError("V2 plot format is not yet implemented")
 
     def get_full_proof(self, challenge: bytes32, index: int, parallel_read: bool = True) -> bytes:
-        # TODO: todo_v2_plots Implement plot proof generation
-        raise NotImplementedError("V2 plot format require solver to get full proof")
+        raise AssertionError("V2 plot format require solver to get full proof")
 
     @classmethod
     def from_bytes(cls, data: bytes) -> V2Prover:
@@ -121,7 +120,7 @@ def get_qualities_for_challenge(self, challenge: bytes32) -> list[bytes32]:
         return [bytes32(quality) for quality in self._disk_prover.get_qualities_for_challenge(challenge)]
 
     def get_partial_proofs_for_challenge(self, challenge: bytes32) -> list[bytes]:
-        raise NotImplementedError("V1 does not implement quality chains, only qualities")
+        raise AssertionError("V1 does not implement quality chains, only qualities")
 
     def get_full_proof(self, challenge: bytes32, index: int, parallel_read: bool = True) -> bytes:
         return bytes(self._disk_prover.get_full_proof(challenge, index, parallel_read))