naming and types

Author: almogdepaz

chia/harvester/harvester_api.py

@@ -130,8 +130,8 @@ def blocking_lookup_v2_partial_proofs(filename: Path, plot_info: PlotInfo) -> Op
                     good_qualities = []
                     sp_interval_iters = calculate_sp_interval_iters(self.harvester.constants, sub_slot_iters)
 
-                    for quality in partial_proofs:
-                        quality_str = quality_for_partial_proof(quality, new_challenge.challenge_hash)
+                    for partial_proof in partial_proofs:
+                        quality_str = quality_for_partial_proof(partial_proof, new_challenge.challenge_hash)
                         required_iters: uint64 = calculate_iterations_quality(
                             self.harvester.constants,
                             quality_str,
@@ -143,7 +143,7 @@ def blocking_lookup_v2_partial_proofs(filename: Path, plot_info: PlotInfo) -> Op
                         )
 
                         if required_iters < sp_interval_iters:
-                            good_qualities.append(quality)
+                            good_qualities.append(partial_proof)
 
                     if len(good_qualities) > 0:
                         size = plot_info.prover.get_size().size_v2

chia/plotting/prover.py

@@ -28,8 +28,8 @@ def get_version(self) -> PlotVersion: ...
     def __bytes__(self) -> bytes: ...
     def get_id(self) -> bytes32: ...
     def get_qualities_for_challenge(self, challenge: bytes32) -> list[bytes32]: ...
-    def get_partial_proofs_for_challenge(self, challenge: bytes) -> list[bytes]: ...
-    def get_full_proof(self, challenge: bytes, index: int, parallel_read: bool = True) -> bytes: ...
+    def get_partial_proofs_for_challenge(self, challenge: bytes32) -> list[bytes]: ...
+    def get_full_proof(self, challenge: bytes32, index: int, parallel_read: bool = True) -> bytes: ...
 
     @classmethod
     def from_bytes(cls, data: bytes) -> ProverProtocol: ...
@@ -56,8 +56,7 @@ def get_memo(self) -> bytes:
         raise NotImplementedError("V2 plot format is not yet implemented")
 
     def get_compression_level(self) -> uint8:
-        # TODO: todo_v2_plots implement compression level retrieval
-        raise NotImplementedError("V2 plot format is not yet implemented")
+        raise NotImplementedError("V2 plot format does not support compression level")
 
     def get_version(self) -> PlotVersion:
         return PlotVersion.V2
@@ -70,15 +69,15 @@ def get_id(self) -> bytes32:
         # TODO: Extract plot ID from V2 plot file
         raise NotImplementedError("V2 plot format is not yet implemented")
 
-    def get_qualities_for_challenge(self, challenge: bytes) -> list[bytes32]:
+    def get_qualities_for_challenge(self, challenge: bytes32) -> list[bytes32]:
         # TODO: todo_v2_plots Implement plot quality lookup
         raise NotImplementedError("V2 plot format is not yet implemented")
 
-    def get_partial_proofs_for_challenge(self, challenge: bytes) -> list[bytes]:
+    def get_partial_proofs_for_challenge(self, challenge: bytes32) -> list[bytes]:
         # TODO: todo_v2_plots Implement quality chain lookup (16 * k bits blobs)
         raise NotImplementedError("V2 plot format is not yet implemented")
 
-    def get_full_proof(self, challenge: bytes, index: int, parallel_read: bool = True) -> bytes:
+    def get_full_proof(self, challenge: bytes32, index: int, parallel_read: bool = True) -> bytes:
         # TODO: todo_v2_plots Implement plot proof generation
         raise NotImplementedError("V2 plot format require solver to get full proof")
 
@@ -121,10 +120,10 @@ def get_id(self) -> bytes32:
     def get_qualities_for_challenge(self, challenge: bytes32) -> list[bytes32]:
         return [bytes32(quality) for quality in self._disk_prover.get_qualities_for_challenge(challenge)]
 
-    def get_partial_proofs_for_challenge(self, challenge: bytes) -> list[bytes]:
+    def get_partial_proofs_for_challenge(self, challenge: bytes32) -> list[bytes]:
         raise NotImplementedError("V1 does not implement quality chains, only qualities")
 
-    def get_full_proof(self, challenge: bytes, index: int, parallel_read: bool = True) -> bytes:
+    def get_full_proof(self, challenge: bytes32, index: int, parallel_read: bool = True) -> bytes:
         return bytes(self._disk_prover.get_full_proof(challenge, index, parallel_read))
 
     @classmethod