Skip to content

Commit 87618b7

Browse files
authored
[LABS-248] Pivot Ruff config from "select" to "ignore" (#20114)
* Pivot from "select" to "ignore" * Add classifications for ignores
1 parent 0158ff2 commit 87618b7

File tree

1 file changed

+36
-38
lines changed

1 file changed

+36
-38
lines changed

ruff.toml

Lines changed: 36 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2,43 +2,7 @@ line-length = 120
22

33
[lint]
44
preview = true
5-
select = [
6-
"PL", # Pylint
7-
"I", # Isort
8-
"FA", # Flake8: future-annotations
9-
"UP", # Pyupgrade
10-
"RUF", # Ruff specific
11-
"F", # Flake8 core
12-
"ASYNC", # Flake8 async
13-
"ISC", # flake8-implicit-str-concat
14-
"TID", # flake8-tidy-imports
15-
"T10", # Debug statements
16-
"EXE", # shebang usage
17-
"ICN", # Import name conventions (i.e. import pandas as pd)
18-
"INP", # Missing __init__.py
19-
"Q", # quotes
20-
"SLOT", # __slots__ usage
21-
"TID", # Tidy imports
22-
"FLY", # .join -> f-string
23-
"PIE", # flake8 plugin for extra lints
24-
"PYI", # type stubs linting
25-
"RSE", # Linting raises
26-
"S", # Potential security issues
27-
# pycodestyle
28-
"E",
29-
"W",
30-
# Trailing commas
31-
# "COM812" # missing-trailing-comma (5105 errors)
32-
"COM818",
33-
"COM819",
34-
# Libraries we don't use so might as well enable
35-
"INT",
36-
"AIR",
37-
"FAST",
38-
"DJ",
39-
"NPY",
40-
"PD",
41-
]
5+
select = ["ALL"]
426
explicit-preview-rules = false
437
ignore = [
448
# Pylint convention
@@ -103,7 +67,41 @@ ignore = [
10367
# TODO: Remove these - it's a lot of errors
10468
"UP045",
10569
"UP007",
106-
"UP035"
70+
"UP035",
71+
72+
# Should fix
73+
"FBT", # boolean positional usage: ~2100 errors
74+
"ANN", # function annotations: ~1100 errors # Gets fixed with mypy-exclusion removal
75+
"G", # logging format: ~1000 errors
76+
"RET", # return linting: ~700 errors
77+
"B", # potential bugs linting: ~600 errors
78+
"PT", # pytest styling: ~600 errors
79+
"SIM", # code simplifications: ~500 errors
80+
"A", # bad behavior relative to builtins: ~200 errors
81+
"PTH", # pathlib linting: ~200 errors
82+
"PGH", # cheap code quality improvements: ~100 errors
83+
"LOG", # logging: <50 errors
84+
# Might be nice, might be annoying
85+
"BLE001", # blind exceptions: ~300 errors
86+
"D", # docstrings: ~9000 errors,
87+
"TRY", # proper exception behavior: ~1300 errors
88+
"EM", # excetion messages: ~1000 errors
89+
"C", # comprehensions: ~600 errors
90+
"SLF", # private member access: ~600 errors
91+
"FURB", # "refurbishing" and "modernizing": ~200 errors
92+
"PERF", # anti-pattern linting: ~200 errors
93+
"N", # pep8 naming: ~200 errors
94+
# Probably fine for our purposes
95+
"COM812", # trailing commas: ~5000 errors
96+
"CPY001", # copyright notices: ~900 errors
97+
"TC", # type checking linting: ~1700 errors # Too much reliance on runtime types to enable this
98+
"T", # using print: ~1300 errors # might want to enable this but not for CLI or tools/
99+
"TD", # formatting of TODOs: ~800 errors
100+
"DOC", # also docstrings: ~700 errors
101+
"ARG", # unused arguments: ~500 errors
102+
"ERA", # commented out code: ~400 errors
103+
"DTZ", # datetimez: <50 errors # likely needs the tzlocal library as a dependency
104+
"FIX", # TODOs, etc: ~400 errors
107105
]
108106

109107
[lint.per-file-ignores]

0 commit comments

Comments
 (0)