Change minimium node version to 20 and npm version to 10 (#19845)

* Update to node 20

* Update another script for minimum npm version

* update check for npm >= 10

* update npm version

---------

Co-authored-by: Zlatko <[email protected]>

Author: emlowe

.github/workflows/build-macos-installers.yml

@@ -176,10 +176,10 @@ jobs:
 
       - uses: chia-network/actions/activate-venv@main
 
-      - name: Setup Node 18.x
+      - name: Setup Node 20.x
         uses: actions/setup-node@v4
         with:
-          node-version: "18.x"
+          node-version: "20.x"
 
       - name: Prepare GUI cache
         id: gui-ref

.github/workflows/build-windows-installer.yml

@@ -95,10 +95,10 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
 
-      - name: Setup Node 18.x
+      - name: Setup Node 20.x
         uses: actions/setup-node@v4
         with:
-          node-version: "18.x"
+          node-version: "20.x"
 
       - name: Test for secrets access
         id: check_secrets

build_scripts/npm_global/package-lock.json

@@ -10,6 +10,6 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "n": "^8.2.0"
+    "n": "^10.2.0"
   }
 }

build_scripts/npm_global/package.json

@@ -40,17 +40,17 @@ do_install_npm_locally() {
   NODEJS_VERSION="$(node -v | cut -d'.' -f 1 | sed -e 's/^v//')"
   NPM_VERSION="$(npm -v | cut -d'.' -f 1)"
 
-  if [ "$NODEJS_VERSION" -lt "18" ] || [ "$NPM_VERSION" -lt "9" ]; then
-    if [ "$NODEJS_VERSION" -lt "18" ]; then
-      echo "Current NodeJS version($(node -v)) is less than 18. GUI app requires NodeJS>=18."
+  if [ "$NODEJS_VERSION" -lt "20" ] || [ "$NPM_VERSION" -lt "10" ]; then
+    if [ "$NODEJS_VERSION" -lt "20" ]; then
+      echo "Current NodeJS version($(node -v)) is less than 20. GUI app requires NodeJS>=20."
     fi
-    if [ "$NPM_VERSION" -lt "9" ]; then
-      echo "Current npm version($(npm -v)) is less than 9. GUI app requires npm>=9."
+    if [ "$NPM_VERSION" -lt "10" ]; then
+      echo "Current npm version($(npm -v)) is less than 10. GUI app requires npm>=10."
     fi
 
     if [ "$(uname)" = "OpenBSD" ] || [ "$(uname)" = "FreeBSD" ]; then
       # `n` package does not support OpenBSD/FreeBSD
-      echo "Please install NodeJS>=18 and/or npm>=9 manually"
+      echo "Please install NodeJS>=20 and/or npm>=10 manually"
       exit 1
     fi
 
@@ -70,17 +70,17 @@ do_install_npm_locally() {
     export N_PREFIX=${SCRIPT_DIR}/.n
     PATH="${N_PREFIX}/bin:$(npm prefix)/node_modules/.bin:${PATH}"
     export PATH
-    # `n 18` here installs nodejs@18 under $N_PREFIX directory
-    echo "n 18"
-    n 18
+    # `n 20` here installs nodejs@20 under $N_PREFIX directory
+    echo "n 20"
+    n 20
     echo "Current NodeJS version: $(node -v)"
     echo "Current npm version: $(npm -v)"
-    if [ "$(node -v | cut -d'.' -f 1 | sed -e 's/^v//')" -lt "18" ]; then
-      echo "Error: Failed to install NodeJS>=18"
+    if [ "$(node -v | cut -d'.' -f 1 | sed -e 's/^v//')" -lt "20" ]; then
+      echo "Error: Failed to install NodeJS>=20"
       exit 1
     fi
-    if [ "$(npm -v | cut -d'.' -f 1)" -lt "9" ]; then
-      echo "Error: Failed to install npm>=9"
+    if [ "$(npm -v | cut -d'.' -f 1)" -lt "10" ]; then
+      echo "Error: Failed to install npm>=10"
       exit 1
     fi
     cd "${SCRIPT_DIR}"
@@ -131,23 +131,23 @@ if [ "$(uname)" = "Linux" ]; then
     # AMZN 2
     if ! nodejs_is_installed; then
       echo "Installing nodejs on Amazon Linux 2."
-      curl -sL https://rpm.nodesource.com/setup_12.x | sudo bash -
+      curl -sL https://rpm.nodesource.com/setup_20.x | sudo bash -
       sudo yum install -y nodejs
     fi
     do_install_npm_locally
   elif type yum >/dev/null 2>&1 && [ ! -f /etc/rocky-release ] && [ ! -f /etc/fedora-release ] && [ -f /etc/redhat-release ] || [ -f /etc/centos-release ]; then
     # CentOS or Redhat
     if ! nodejs_is_installed; then
       echo "Installing nodejs on CentOS/Redhat."
-      curl -sL https://rpm.nodesource.com/setup_12.x | sudo bash -
+      curl -sL https://rpm.nodesource.com/setup_20.x | sudo bash -
       sudo yum install -y nodejs
     fi
     do_install_npm_locally
   elif type yum >/dev/null 2>&1 && [ -f /etc/rocky-release ] || [ -f /etc/fedora-release ]; then
     # RockyLinux
     if ! nodejs_is_installed; then
       echo "Installing nodejs on RockyLinux/Fedora"
-      sudo dnf module enable nodejs:12
+      sudo dnf module enable nodejs:20
       sudo dnf install -y nodejs
     fi
     do_install_npm_locally

install-gui.sh

@@ -32,8 +32,8 @@ if ! npm version >/dev/null 2>&1; then
 fi
 
 NPM_VERSION="$(npm -v | cut -d'.' -f 1)"
-if [ "$NPM_VERSION" -lt "9" ]; then
-  echo "Current npm version($(npm -v)) is less than 9. GUI app requires npm>=9."
+if [ "$NPM_VERSION" -lt "10" ]; then
+  echo "Current npm version($(npm -v)) is less than 10. GUI app requires npm>=10."
   exit 1
 else
   echo "Found npm $(npm -v)"