more pr comments, fix test to catch assertion

Author: almogdepaz

chia/_tests/plotting/test_prover.py

@@ -43,7 +43,7 @@ def test_v2_prover_get_qualities_for_challenge_raises_error(self) -> None:
 
     def test_v2_prover_get_full_proof_raises_error(self) -> None:
         prover = V2Prover("/nonexistent/path/test.plot2")
-        with pytest.raises(NotImplementedError, match="V2 plot format require solver to get full proof"):
+        with pytest.raises(AssertionError, match="V2 plot format require solver to get full proof"):
             prover.get_full_proof(bytes32(b"1" * 32), 0)
 
     def test_v2_prover_bytes_raises_error(self) -> None:

chia/cmds/solver.py

@@ -33,7 +33,7 @@ def get_state_cmd(
     asyncio.run(get_state(ChiaCliContext.set_default(ctx), solver_rpc_port))
 
 
-@solver_cmd.command("solve", help="Solve a quality string")
+@solver_cmd.command("solve", help="Solve a partial proof of space, turning it into a full proof")
 @click.option(
     "-sp",
     "--solver-rpc-port",
@@ -43,38 +43,20 @@ def get_state_cmd(
     show_default=True,
 )
 @click.option(
-    "-q",
-    "--quality",
-    help="Quality string to solve (hex format)",
+    "-p",
+    "--partial_proof",
+    help="partial proof string to solve (hex format)",
     type=str,
     required=True,
 )
-@click.option(
-    "-k",
-    "--plot-size",
-    help="Plot size (k value, default: 32)",
-    type=int,
-    default=32,
-    show_default=True,
-)
-@click.option(
-    "-d",
-    "--difficulty",
-    help="Plot difficulty (default: 1000)",
-    type=int,
-    default=1000,
-    show_default=True,
-)
 @click.pass_context
 def solve_cmd(
     ctx: click.Context,
     solver_rpc_port: Optional[int],
-    quality: str,
-    plot_size: int,
-    difficulty: int,
+    partial_proof: str,
 ) -> None:
     import asyncio
 
-    from chia.cmds.solver_funcs import solve_quality
+    from chia.cmds.solver_funcs import solve_partial_proof
 
-    asyncio.run(solve_quality(ChiaCliContext.set_default(ctx), solver_rpc_port, quality, plot_size, difficulty))
+    asyncio.run(solve_partial_proof(ChiaCliContext.set_default(ctx), solver_rpc_port, partial_proof))

chia/cmds/solver_funcs.py

@@ -21,17 +21,15 @@ async def get_state(
         print(f"Failed to get solver state: {e}")
 
 
-async def solve_quality(
+async def solve_partial_proof(
     ctx: ChiaCliContext,
     solver_rpc_port: Optional[int],
-    quality_hex: str,
-    plot_size: int = 32,
-    difficulty: int = 1000,
+    partial_proof: str,
 ) -> None:
-    """Solve a quality string via RPC."""
+    """Solve a partial proof via RPC."""
     try:
         async with get_any_service_client(SolverRpcClient, ctx.root_path, solver_rpc_port) as (client, _):
-            response = await client.solve(quality_hex)
+            response = await client.solve(partial_proof)
             print(json.dumps(response, indent=2))
     except Exception as e:
-        print(f"Failed to solve quality: {e}")
+        print(f"Failed to solve partial proof: {e}")