[CHIA-3795] change v1 plot phase-out (#20216)

* change v1 plot phase-out to not affect required iters, and to be quantized to epoch blocks

* disable hard-fork 2 tests until we have a new test cache

* fix rate limits test

* address review comments

Author: arvidn

chia/_tests/conftest.py

@@ -200,7 +200,8 @@ class ConsensusMode(ComparableEnum):
 
 @pytest.fixture(
     scope="session",
-    params=[ConsensusMode.PLAIN, ConsensusMode.HARD_FORK_2_0, ConsensusMode.HARD_FORK_3_0],
+    # TODO: todo_v2_plots add HARD_FORK_3_0 mode as well as after phase-out
+    params=[ConsensusMode.PLAIN, ConsensusMode.HARD_FORK_2_0],
 )
 def consensus_mode(request):
     return request.param

chia/_tests/core/consensus/test_pot_iterations.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-import pytest
 from chia_rs import PlotSize
 from chia_rs.sized_ints import uint8, uint16, uint32, uint64, uint128
 from pytest import raises
@@ -10,7 +9,6 @@
 from chia.consensus.pot_iterations import (
     calculate_ip_iters,
     calculate_iterations_quality,
-    calculate_phase_out,
     calculate_sp_interval_iters,
     calculate_sp_iters,
     is_overflow_block,
@@ -84,17 +82,7 @@ def test_calculate_ip_iters(self):
         assert ip_iters == (sp_iters + test_constants.NUM_SP_INTERVALS_EXTRA * sp_interval_iters + required_iters) % ssi
         assert sp_iters > ip_iters
 
-    @pytest.mark.parametrize(
-        "height",
-        [
-            uint32(0),
-            test_constants.HARD_FORK2_HEIGHT - 1,
-            test_constants.HARD_FORK2_HEIGHT,
-            test_constants.HARD_FORK2_HEIGHT + test_constants.PLOT_V1_PHASE_OUT,
-            test_constants.HARD_FORK2_HEIGHT + test_constants.PLOT_V1_PHASE_OUT + 1,
-        ],
-    )
-    def test_win_percentage(self, height: uint32):
+    def test_win_percentage(self):
         """
         Tests that the percentage of blocks won is proportional to the space of each farmer,
         with the assumption that all farmers have access to the same VDF speed.
@@ -129,59 +117,19 @@ def test_win_percentage(self, height: uint32):
                         quality = std_hash(
                             slot_index.to_bytes(4, "big") + plot_k_val.to_bytes(1, "big") + bytes(farmer_index)
                         )
-                        required_iters = calculate_iterations_quality(
-                            constants, quality, k, difficulty, sp_hash, sub_slot_iters, height
-                        )
+                        required_iters = calculate_iterations_quality(constants, quality, k, difficulty, sp_hash)
                         if required_iters < sp_interval_iters:
                             wins[k] += 1
                             total_wins_in_slot += 1
 
-        if height < test_constants.HARD_FORK2_HEIGHT + test_constants.PLOT_V1_PHASE_OUT:
-            total_space = sum(farmer_space.values())
-            percentage_space = {k: float(sp / total_space) for k, sp in farmer_space.items()}
-        else:
-            # after the phase-out, v1 plots don't count
-            # all wins are by v2 plots
-            total_space = sum(0 if k.size_v2 is None else sp for k, sp in farmer_space.items())
-            percentage_space = {
-                k: 0.0 if k.size_v2 is None else float(sp / total_space) for k, sp in farmer_space.items()
-            }
+        total_space = sum(farmer_space.values())
+        percentage_space = {k: float(sp / total_space) for k, sp in farmer_space.items()}
 
         win_percentage = {k: wins[k] / sum(wins.values()) for k in farmer_ks.keys()}
         for k in farmer_ks.keys():
             # Win rate is proportional to percentage of space
             assert abs(win_percentage[k] - percentage_space[k]) < 0.01
 
-    @pytest.mark.parametrize("sp_interval", [uint64(6250000000), uint64(1), uint64(2), uint64(10), uint64(10000000000)])
-    def test_calculate_phase_out(self, sp_interval: uint64):
-        constants = test_constants
-        sub_slot_iters = uint64(sp_interval * constants.NUM_SPS_SUB_SLOT)
-        # Before or at HARD_FORK2_HEIGHT, should return 0
-        assert calculate_phase_out(constants, sub_slot_iters, uint32(constants.HARD_FORK2_HEIGHT - 1)) == 0
-        assert calculate_phase_out(constants, sub_slot_iters, constants.HARD_FORK2_HEIGHT) == 0
-        # after HARD_FORK2_HEIGHT, should return value = delta/phase_out_period * sp_interval
-        assert (
-            calculate_phase_out(constants, sub_slot_iters, uint32(constants.HARD_FORK2_HEIGHT + 1))
-            == sp_interval // constants.PLOT_V1_PHASE_OUT
-        )
-        assert (
-            calculate_phase_out(
-                constants, sub_slot_iters, uint32(constants.HARD_FORK2_HEIGHT + constants.PLOT_V1_PHASE_OUT // 2)
-            )
-            == sp_interval // 2
-        )
-        assert (
-            calculate_phase_out(
-                constants, sub_slot_iters, uint32(constants.HARD_FORK2_HEIGHT + constants.PLOT_V1_PHASE_OUT)
-            )
-            == sp_interval
-        )
-
-        # Test with maximum uint32 height to ensure no overflow
-        max_uint32_height = uint32(0xFFFFFFFF)
-        result_max_height = calculate_phase_out(constants, sub_slot_iters, max_uint32_height)
-        assert result_max_height == sp_interval  # Should cap at sp_interval
-
 
 def test_expected_plot_size_v1() -> None:
     last_size = 2_400_000

chia/_tests/core/custom_types/test_proof_of_space.py

@@ -14,6 +14,7 @@
 from chia.types.blockchain_format.proof_of_space import (
     calculate_prefix_bits,
     check_plot_size,
+    is_v1_phased_out,
     make_pos,
     passes_plot_filter,
     verify_and_get_quality_string,
@@ -150,6 +151,7 @@ def test_verify_and_get_quality_string(caplog: pytest.LogCaptureFixture, case: P
         original_challenge_hash=b32("0x73490e166d0b88347c37d921660b216c27316aae9a3450933d3ff3b854e5831a"),
         signage_point=b32("0x7b3e23dbd438f9aceefa9827e2c5538898189987f49b06eceb7a43067e77b531"),
         height=case.height,
+        prev_transaction_block_height=case.height,
     )
     assert quality_string is None
     assert len(caplog.text) == 0 if case.expected_error is None else case.expected_error in caplog.text
@@ -187,6 +189,7 @@ def test_verify_and_get_quality_string_v2(caplog: pytest.LogCaptureFixture, case
             original_challenge_hash=b32("0x73490e166d0b88347c37d921660b216c27316aae9a3450933d3ff3b854e5831a"),
             signage_point=b32("0x7b3e23dbd438f9aceefa9827e2c5538898189987f49b06eceb7a43067e77b531"),
             height=case.height,
+            prev_transaction_block_height=case.height,
         )
     except NotImplementedError as e:
         assert case.expected_error is not None
@@ -281,3 +284,30 @@ def test_calculate_prefix_bits_v1(height: uint32, expected: int) -> None:
 )
 def test_calculate_prefix_bits_v2(height: uint32, expected: int) -> None:
     assert calculate_prefix_bits(DEFAULT_CONSTANTS, height, PlotSize.make_v2(28)) == expected
+
+
+def test_v1_phase_out() -> None:
+    constants = DEFAULT_CONSTANTS.replace(HARD_FORK2_HEIGHT=uint32(500000))
+    rng = random.Random()
+
+    phase_out_epochs = 1 << (constants.PLOT_V1_PHASE_OUT // constants.EPOCH_BLOCKS).bit_length()
+    print(f"phase-out epochs: {phase_out_epochs}")
+
+    for epoch in range(-5, phase_out_epochs + 5):
+        prev_tx_height = uint32(constants.HARD_FORK2_HEIGHT + epoch * constants.EPOCH_BLOCKS)
+        num_phased_out = 0
+        rng.seed(1337)
+        for i in range(1000):
+            proof = rng.randbytes(32)
+            if is_v1_phased_out(proof, prev_tx_height, constants):
+                num_phased_out += 1
+
+        expect = min(1.0, max(0.0, epoch / phase_out_epochs))
+
+        print(
+            f"height: {prev_tx_height} "
+            f"epoch: {epoch} "
+            f"phased-out: {num_phased_out / 10:0.2f}% "
+            f"expect: {expect * 100.0:0.2f}%"
+        )
+        assert abs((num_phased_out / 1000) - expect) < 0.05

chia/_tests/core/full_node/test_full_node.py

@@ -3224,12 +3224,15 @@ async def declare_pos_unfinished_block(
         include_signature_source_data=True,
     )
     await full_node_api.declare_proof_of_space(pospace, dummy_peer)
+    tx_peak = blockchain.get_tx_peak()
+    assert tx_peak is not None
     q_str: Optional[bytes32] = verify_and_get_quality_string(
         block.reward_chain_block.proof_of_space,
         blockchain.constants,
         challenge,
         challenge_chain_sp,
         height=block.reward_chain_block.height,
+        prev_transaction_block_height=tx_peak.height,
     )
     assert q_str is not None
     unfinised_block = None

chia/_tests/core/server/test_rate_limits.py

@@ -24,7 +24,6 @@
 rl_v2 = [Capability.BASE, Capability.BLOCK_HEADERS, Capability.RATE_LIMITS_V2]
 rl_v1 = [Capability.BASE]
 node_with_params_b = node_with_params
-test_different_versions_results: list[int] = []
 
 
 @dataclass
@@ -418,11 +417,14 @@ async def test_different_versions(
     # The following code checks whether all of the runs resulted in the same number of items in "rate_limits_tx",
     # which would mean the same rate limits are always used. This should not happen, since two nodes with V2
     # will use V2.
-    total_tx_msg_count = len(get_rate_limits_to_use(a_con.local_capabilities, a_con.peer_capabilities))
+    rate_limits = get_rate_limits_to_use(a_con.local_capabilities, a_con.peer_capabilities)[0]
+    limit = rate_limits[ProtocolMessageTypes.request_header_blocks]
+    assert isinstance(limit, RLSettings)
 
-    test_different_versions_results.append(total_tx_msg_count)
-    if len(test_different_versions_results) >= 4:
-        assert len(set(test_different_versions_results)) >= 2
+    if Capability.RATE_LIMITS_V2 in a_con.local_capabilities and Capability.RATE_LIMITS_V2 in a_con.peer_capabilities:
+        assert limit.frequency == 5000
+    else:
+        assert limit.frequency == 500
 
 
 @pytest.mark.anyio

chia/_tests/farmer_harvester/test_farmer.py

@@ -626,7 +626,14 @@ async def test_farmer_new_proof_of_space_for_pool_stats(
     }
 
     assert (
-        verify_and_get_quality_string(pos, DEFAULT_CONSTANTS, case.challenge_hash, case.sp_hash, height=uint32(1))
+        verify_and_get_quality_string(
+            pos,
+            DEFAULT_CONSTANTS,
+            case.challenge_hash,
+            case.sp_hash,
+            height=uint32(1),
+            prev_transaction_block_height=uint32(1),
+        )
         is not None
     )
 
@@ -883,7 +890,12 @@ async def test_farmer_pool_response(
 
     assert (
         verify_and_get_quality_string(
-            pos, DEFAULT_CONSTANTS, sp.challenge_hash, sp.challenge_chain_sp, height=uint32(1)
+            pos,
+            DEFAULT_CONSTANTS,
+            sp.challenge_hash,
+            sp.challenge_chain_sp,
+            height=uint32(1),
+            prev_transaction_block_height=uint32(1),
         )
         is not None
     )
@@ -1251,7 +1263,12 @@ async def test_farmer_additional_headers_on_partial_submit(
 
     assert (
         verify_and_get_quality_string(
-            pos, DEFAULT_CONSTANTS, sp.challenge_hash, sp.challenge_chain_sp, height=uint32(1)
+            pos,
+            DEFAULT_CONSTANTS,
+            sp.challenge_hash,
+            sp.challenge_chain_sp,
+            height=uint32(1),
+            prev_transaction_block_height=uint32(1),
         )
         is not None
     )

chia/_tests/weight_proof/test_weight_proof.py

@@ -47,7 +47,6 @@ async def load_blocks_dont_validate(
             cc_sp,
             block.height,
             difficulty,
-            sub_slot_iters,
             uint32(0),  # prev_tx_block(blocks, prev_b), todo need to get height of prev tx block somehow here
         )
         assert required_iters is not None

chia/consensus/block_header_validation.py

@@ -502,7 +502,6 @@ def validate_unfinished_header_block(
         cc_sp_hash,
         height,
         expected_vs.difficulty,
-        expected_vs.ssi,
         prev_tx_block(blocks, prev_b),
     )
     if required_iters is None:

chia/consensus/default_constants.py

@@ -84,7 +84,7 @@
     HARD_FORK2_HEIGHT=uint32(0xFFFFFFFA),
     # starting at the hard fork 2 height, v1 plots will gradually be phased out,
     # and stop working entirely after this many blocks
-    PLOT_V1_PHASE_OUT=uint32(1179648),
+    PLOT_V1_PHASE_OUT=uint32(255 * 4608),
     # June 2027
     PLOT_FILTER_128_HEIGHT=uint32(10542000),
     # June 2030

chia/consensus/multiprocess_validation.py

@@ -220,7 +220,6 @@ async def return_error(error_code: Err) -> PreValidationResult:
         cc_sp_hash,
         block.height,
         vs.difficulty,
-        vs.ssi,
         prev_tx_block(blockchain, prev_b),
     )
     if required_iters is None: