[Bug] 1.3 Seems to use target_outbound_peer_count for total target_peer_count.

[scrutinously]

What happened?

Running a node on 1.3, my peer count is consistently low. My main farmer on 1.2.11 is always connected to max peers allowed by target_peer_count, but the 1.3 node will never go higher than the limit set by target_outbound_peer_count.

  target_outbound_peer_count: 6
  target_peer_count: 20

I confirmed this by changing the target_outbound_peer_count to multiple targets, and it always matched that target and would not exceed it.

Version

1.3 installed from source branch: latest

What platform are you using?

Linux

What ui mode are you using?

CLI

Relevant log output

No response

[mariano54]

I think that might be related to upnp not working properly. Can you check that your port 8444 is accessible from outside?
https://portchecker.co/
https://github.com/Chia-Network/chia-blockchain/wiki/Resolving-Sync-Issues---Port-8444

[scrutinously]

Yeah, the port is open upnp is disabled, 8444 forwarded to my main farmer, somehow I still have outbound syncing from my 1.3 node despite 8444 forwarded to a different computer. Still, why is the node not attempting to get more connections when it should be looking for 14 inbound peers (20 peer count - 6 outbound count?).

The node is staying in sync, I'm just concerned that the limit appears to be incorrect, and I don't want to set outbound very high because upload bandwidth is so low.

[mariano54]

it will limit outbound to 6. It cannot obtain inbound, most likely because your computer is not accessible for some reason.

[scrutinously]

Shouldn't it be harder for outbound peer connections without UPNP and no port forwarding? As to the "not accessible" the fact that this is in a WSL2 instance may be a contributing factor.

[mariano54]

Yeah that might be related..

[emlowe]

Whether you get incoming peers or not can't be controlled by the software - I don't think there is a bug here. Do you have any log output that suggests your node is rejecting incoming peers? Moving to a support discussion

[scrutinously]

It has no problem finding peers, but when it gets to the target_outbound_peer_count limit, it stops looking:

2022-03-10T15:01:36.459 full_node full_node_server        : INFO     Connected with full_node {'host': '203.87.15.52', 'port': 8444}
2022-03-10T15:01:39.196 full_node full_node_server        : INFO     Connected with full_node {'host': '94.172.180.190', 'port': 8444}
2022-03-10T15:01:39.197 full_node full_node_server        : INFO     Connection closed: 94.172.180.190, node id: 96f7783ecc9d27fe2a5b662da1fe3ca65aed40068a2603a977e7d5db04e4ce90
2022-03-10T15:01:39.197 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '94.172.180.190', 'port': 8444}
2022-03-10T15:01:44.240 full_node chia.full_node.full_node: INFO     Added blocks 1672681 to 1672713
2022-03-10T15:01:46.546 full_node full_node_server        : INFO     Cannot connect to host 112.44.135.9:8444 ssl:<ssl.SSLContext object at 0x7f22535093c0> [Connect call failed ('112.44.135.9', 8444)]
2022-03-10T15:01:51.083 full_node chia.full_node.full_node: INFO     Added blocks 1672713 to 1672745
2022-03-10T15:01:51.239 full_node full_node_server        : INFO     Connected with full_node {'host': '207.244.241.141', 'port': 8444}
2022-03-10T15:01:51.240 full_node full_node_server        : INFO     Connection closed: 207.244.241.141, node id: 4057b1a281165690e56450c3c6c30e86b0e8edef9d4aff73ae5e4fc20864dea0
2022-03-10T15:01:51.241 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '207.244.241.141', 'port': 8444}
2022-03-10T15:01:54.973 full_node full_node_server        : INFO     Connected with full_node {'host': '67.173.67.193', 'port': 8444}
2022-03-10T15:01:54.989 full_node full_node_server        : INFO     Connection closed: 67.173.67.193, node id: 7d87a19c03e92e36e2ade6e064cb4c63c617102048fc18497f21a3057d7ef61a
2022-03-10T15:01:54.989 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '67.173.67.193', 'port': 8444}
2022-03-10T15:02:01.319 full_node full_node_server        : INFO     Connected with full_node {'host': '58.82.195.185', 'port': 8444}
2022-03-10T15:02:01.320 full_node full_node_server        : INFO     Connection closed: 58.82.195.185, node id: e352b96ebcaef7b1d8e5de745e6d780c7e772597fbb55cf14a7509525f37379d
2022-03-10T15:02:01.321 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '58.82.195.185', 'port': 8444}
2022-03-10T15:02:02.564 full_node full_node_server        : INFO     Connected with full_node {'host': '73.60.125.48', 'port': 8444}
2022-03-10T15:02:02.565 full_node full_node_server        : INFO     Connection closed: 73.60.125.48, node id: 68c1373a4693b70b64f7556a31f5f0bececc09249aa140e1ca4b8c196e8dde0e
2022-03-10T15:02:02.565 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '73.60.125.48', 'port': 8444}
2022-03-10T15:02:03.595 full_node chia.full_node.full_node: INFO     Added blocks 1672745 to 1672777
2022-03-10T15:02:06.373 full_node full_node_server        : INFO     Connected with full_node {'host': '24.12.7.58', 'port': 8444}
2022-03-10T15:02:06.374 full_node full_node_server        : INFO     Connection closed: 24.12.7.58, node id: 53f769cd1ef4ad5e2d1d45d49c920109590413bfeb3a8a9b3e96a21af68e6258
2022-03-10T15:02:06.374 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '24.12.7.58', 'port': 8444}
2022-03-10T15:02:10.213 full_node full_node_server        : INFO     Connected with full_node {'host': '68.149.124.108', 'port': 8444}
2022-03-10T15:02:12.270 full_node chia.full_node.full_node: INFO     Added blocks 1672777 to 1672809
2022-03-10T15:02:14.420 full_node full_node_server        : INFO     Connected with full_node {'host': '213.155.245.26', 'port': 8444}
2022-03-10T15:02:14.577 full_node full_node_server        : INFO     Connection closed: 213.155.245.26, node id: f3505a5dcb95a456494643926e0976ea1e2dad304a56b9f56ae1372b66acb8f4
2022-03-10T15:02:14.577 full_node chia.full_node.full_node: INFO     peer disconnected {'host': '213.155.245.26', 'port': 8444}
2022-03-10T15:02:22.616 full_node chia.full_node.full_node: INFO     Added blocks 1672809 to 1672841
2022-03-10T15:02:29.381 full_node chia.full_node.full_node: INFO     Added blocks 1672841 to 1672873
2022-03-10T15:02:34.044 full_node chia.full_node.full_node: INFO     Added blocks 1672873 to 1672905
2022-03-10T15:02:44.643 full_node chia.full_node.full_node: INFO     Added blocks 1672905 to 1672937
2022-03-10T15:02:52.740 full_node chia.full_node.full_node: INFO     Added blocks 1672937 to 1672969
2022-03-10T15:02:59.924 full_node chia.full_node.full_node: INFO     Added blocks 1672969 to 1673001
2022-03-10T15:03:05.976 full_node chia.full_node.full_node: INFO     Added blocks 1673001 to 1673033

[emlowe]

Right, it stops looking for peers - that's expected because it hit the target_outbound. In networking parlance, these are what I will CONNECT to.

It's still available itself to be found, however. That is, it is still LISTENING for connections, but no one is coming along.

[scrutinously]

this doesn't make sense, it should be looking to connect to others to receive, but instead it's looking for others to send to?

[emlowe]

Let me try to explain.

You are at your house and you want to visit 10 neighbours. You are willing to visit 5 (target_outbound) and have 5 others come visit you - for a total of 10 (target_peer_count)

So you go to your 5 neighbours, knock on their doors, visit and go home. You have filled your target_outbound limit of 5 neighbours.

Now, you are waiting for 5 others to come to visit you, but they never do (your dog frightened them). So you in total visited 5 neighbours. If you want to visit more, you need to go yourself, but you set your limit to 5.

this is how it works. If you want to go visit more neighbours on your own, increase your target_outbound limit - this can be useful when your neighbours can't come visit you.

[scrutinously]

So why does the client have such a low default limit to connect to others? The way it was set up implied it was for controlling up vs down bandwidth rather than who seeks out who for connections.