upgrade ruff and fix issues that arise #19812
Description
@copilot We want to upgrade to the newest ruff version which I believe is 0.12.3. Fix new ruff check issues that arise. Also do ruff format to ensure it conforms. Needs to pass CI too. Start from change ab9e729.