From 1aad2fa8f6a96dcd842dcc9cc57277ab5d0d670f Mon Sep 17 00:00:00 2001
From: Kyle Altendorf <sda@fstab.net>
Date: Mon, 8 Jul 2024 11:59:08 -0400
Subject: [PATCH] coverage exclude `else: assert False`

---
 .coveragerc                                    |  1 +
 chia/_tests/core/data_layer/test_data_rpc.py   | 18 +++++++++---------
 .../core/data_layer/test_data_store_schema.py  |  2 +-
 chia/consensus/vdf_info_computation.py         |  1 -
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.coveragerc b/.coveragerc
index ec4426c53cc4..37da14c565bb 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -25,3 +25,4 @@ exclude_also =
   if TYPE_CHECKING:
   ^ *@pytest.mark.skip($|\()
   benchmark_runner: BenchmarkRunner
+  else:\s*(#\[^\n]*)?\n(\s+#[^\n]*\n)?\s+assert False
diff --git a/chia/_tests/core/data_layer/test_data_rpc.py b/chia/_tests/core/data_layer/test_data_rpc.py
index 8cad29a9a766..8f82c907c35a 100644
--- a/chia/_tests/core/data_layer/test_data_rpc.py
+++ b/chia/_tests/core/data_layer/test_data_rpc.py
@@ -1813,7 +1813,7 @@ async def test_make_and_cancel_offer(offer_setup: OfferSetup, reference: MakeAnd
             break
         await offer_setup.full_node_api.farm_blocks_to_puzzlehash(count=1, guarantee_transaction_blocks=True)
         await asyncio.sleep(0.5)
-    else:  # pragma: no cover
+    else:
         assert False, "offer was not cancelled"
 
     taker_request = {
@@ -2124,7 +2124,7 @@ async def test_clear_pending_roots(
             finally:
                 client.close()
                 await client.await_closed()
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
 
         assert cleared_root == {"success": True, "root": pending_root.marshal()}
@@ -2352,7 +2352,7 @@ async def test_wallet_log_in_changes_active_fingerprint(
             )
             assert process.stdout is not None
             assert await process.stdout.read() == b""
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
 
         active_fingerprint = cast(int, (await wallet_rpc_api.get_logged_in_fingerprint(request={}))["fingerprint"])
@@ -3110,7 +3110,7 @@ async def test_pagination_cmds(
             finally:
                 client.close()
                 await client.await_closed()
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
         if max_page_size is None or max_page_size == 100:
             assert keys == {
@@ -3179,7 +3179,7 @@ async def test_pagination_cmds(
                 "total_bytes": 9,
                 "total_pages": 2,
             }
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
 
 
@@ -3282,7 +3282,7 @@ async def test_unsubmitted_batch_update(
                 finally:
                     client.close()
                     await client.await_closed()
-            else:  # pragma: no cover
+            else:
                 assert False, "unhandled parametrization"
 
             await full_node_api.farm_blocks_to_puzzlehash(
@@ -3420,7 +3420,7 @@ async def test_unsubmitted_batch_update(
             finally:
                 client.close()
                 await client.await_closed()
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
 
         pending_root = await data_layer.data_store.get_pending_root(store_id=store_id)
@@ -3550,7 +3550,7 @@ async def test_multistore_update(
                 update_tx_rec0 = bytes32.from_hexstr(res["tx_id"][0])
             else:
                 assert res == {"success": True}
-        else:  # pragma: no cover
+        else:
             assert False, "unhandled parametrization"
 
         if not submit_on_chain:
@@ -3587,7 +3587,7 @@ async def test_multistore_update(
                     res = await client.submit_all_pending_roots(fee=None)
 
                 update_tx_rec0 = bytes32.from_hexstr(res["tx_id"][0])
-            else:  # pragma: no cover
+            else:
                 assert False, "unhandled parametrization"
 
         await farm_block_with_spend(full_node_api, ph, update_tx_rec0, wallet_rpc_api)
diff --git a/chia/_tests/core/data_layer/test_data_store_schema.py b/chia/_tests/core/data_layer/test_data_store_schema.py
index 46a474f2f095..4aedf4394c7a 100644
--- a/chia/_tests/core/data_layer/test_data_store_schema.py
+++ b/chia/_tests/core/data_layer/test_data_store_schema.py
@@ -133,7 +133,7 @@ async def test_node_internal_must_be_valid_reference(
         values["left"] = bad_child_hash
     elif side == Side.RIGHT:
         values["right"] = bad_child_hash
-    else:  # pragma: no cover
+    else:
         assert False
 
     async with data_store.db_wrapper.writer() as writer:
diff --git a/chia/consensus/vdf_info_computation.py b/chia/consensus/vdf_info_computation.py
index 915d863c2f5a..e7a95d266b6f 100644
--- a/chia/consensus/vdf_info_computation.py
+++ b/chia/consensus/vdf_info_computation.py
@@ -143,7 +143,6 @@ def get_signage_point_vdf_info(
         assert curr.finished_challenge_slot_hashes is not None
         cc_vdf_challenge = curr.finished_challenge_slot_hashes[-1]
     else:
-        # All cases are handled above
         assert False
 
     return (