support previous harvester protocol #19994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
AmineKhaldi
reviewed
Aug 27, 2025
Co-authored-by: Amine Khaldi <[email protected]>
AmineKhaldi
approved these changes
Aug 28, 2025
emlowe
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
based on the protocol version advertised by the harvester, use the previous version of the
NewSignagePointHarvestermessage.Current Behavior:
We only send the new version of
NewSignagePointHarvesterto harvesters.New Behavior:
Rename the new version of the message
NewSignagePointHarvester2and re-introduce the previous version asNewSignagePointHarvester.Send the previous version to any harvester advertizing protocol version 0.0.36 or earlier, and the new version to harvesters 0.0.37.