Skip to content

Farmer solver networking #20019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 29, 2025
Merged

Farmer solver networking #20019

merged 14 commits into from
Sep 29, 2025

Conversation

almogdepaz
Copy link
Contributor

@almogdepaz almogdepaz commented Sep 2, 2025 •
edited
Loading

Purpose:

CHIA-3676, CHIA-3677,CHIA-3678

  • farmer now connects to solver instead of solver to farmer
  • Added solver service trusted peer checking
  • Added --set-solver-peer and --set-solver-trusted-peers-only options to chia configure
  • Added chia farm connect-solver ip:port command for live connection management
  • connect_to_solver RPC endpoint in farmer_rpc_api.py Automatically disconnects existing solvers when connecting new one

Current Behavior:

New Behavior:

Testing Notes:

@almogdepaz almogdepaz added Farming Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Sep 2, 2025
@almogdepaz almogdepaz requested a review from arvidn September 3, 2025 10:24
@almogdepaz almogdepaz marked this pull request as ready for review September 3, 2025 11:47
@almogdepaz almogdepaz requested a review from a team as a code owner September 3, 2025 11:47
arvidn
arvidn reviewed Sep 4, 2025
View reviewed changes
arvidn
arvidn reviewed Sep 5, 2025
View reviewed changes
arvidn
arvidn previously approved these changes Sep 16, 2025
View reviewed changes
@arvidn
Copy link
Contributor

arvidn commented Sep 18, 2025

@almogdepaz can you explain the changes you made in the last commit? It's not obvious that it's correct to remove the SOLVER from those sets.

@almogdepaz
Copy link
Contributor Author

almogdepaz commented Sep 18, 2025 •
edited
Loading

@almogdepaz can you explain the changes you made in the last commit? It's not obvious that it's correct to remove the SOLVER from those sets.

as far as i understand that part of the infrastructure the solver should be setup like the full node service, otherwise we will check to see the certs match when accepting connections and when trying to connect, i made a mistake by adding it in the first place, when i thought the connection was from the solver to the farmer and not the other way around and before i realized it needs to be a public service by default

arvidn
arvidn previously approved these changes Sep 18, 2025
View reviewed changes
@arvidn arvidn closed this Sep 19, 2025
@arvidn arvidn reopened this Sep 19, 2025
@almogdepaz almogdepaz force-pushed the farmer_solver_networking branch 2 times, most recently from 1cf0f7d to 0299439 Compare September 28, 2025 08:58
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18080095614

Details

  • 84 of 134 (62.69%) changed or added relevant lines in 18 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.175%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/solver/start_solver.py 0 1 0.0%
chia/cmds/farm.py 5 8 62.5%
chia/solver/solver.py 4 9 44.44%
chia/cmds/configure.py 2 18 11.11%
chia/cmds/farm_funcs.py 2 27 7.41%
Files with Coverage Reduction New Missed Lines %
chia/timelord/timelord_api.py 1 93.02%
chia/util/config.py 1 82.25%
chia/full_node/full_node.py 2 87.27%
chia/util/files.py 2 91.38%
chia/introducer/introducer_api.py 5 81.48%
Totals Coverage Status
Change from base Build 18016390881: 0.04%
Covered Lines: 102876
Relevant Lines: 112672
💛 - Coveralls

@almogdepaz almogdepaz force-pushed the farmer_solver_networking branch from a3e2cca to 984ab6f Compare September 28, 2025 19:12
@almogdepaz almogdepaz force-pushed the farmer_solver_networking branch from cadbff9 to 5c15e29 Compare September 28, 2025 21:30
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/configure.py 11.1% lines 64-66, 68-69, 71-79, 81-82
chia/cmds/farm.py 62.5% lines 126, 128, 130
chia/cmds/farm_funcs.py 7.4% lines 224, 226-243, 245-250
chia/solver/solver.py 44.4% lines 85-86, 89-91
chia/solver/start_solver.py 0.0% lines 74
Total Missing Coverage
134 lines 50 lines 62%

@pmaslana pmaslana merged commit 6bd9360 into main Sep 29, 2025
349 of 350 checks passed
@pmaslana pmaslana deleted the farmer_solver_networking branch September 29, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Farming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@almogdepaz @arvidn @pmaslana