Skip to content

CHIA-3746 Simplify can_replace #20086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CHIA-3746 Simplify can_replace #20086

wants to merge 1 commit into from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

We don't need to pass the coin IDs that the new mempool item is spending.

Current Behavior:

We pass both the new mempool item and the coin IDs that it spends.

New Behavior:

We just pass the new mempool item.

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Sep 18, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 18, 2025
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 17832198559

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.007%) to 91.156%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node.py 1 87.27%
chia/server/node_discovery.py 1 82.11%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/wallet/wallet_node.py 1 87.13%
chia/timelord/timelord_launcher.py 2 90.71%
chia/util/files.py 2 91.38%
chia/rpc/rpc_server.py 3 88.4%
chia/timelord/timelord.py 11 71.94%
Totals Coverage Status
Change from base Build 17773649562: -0.007%
Covered Lines: 102732
Relevant Lines: 112538
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AmineKhaldi