Change pre-commit workflow macOS ARM runner to macos-latest #20093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Changed
cmmarslender
approved these changes
Sep 22, 2025
Pull Request Test Coverage Report for Build 17923515387Details
💛 - Coveralls |
|
https://github.com/Chia-Network/chia-blockchain/actions/runs/17923515279?pr=20093 all pre-commit are passing again anyways |
emlowe
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
there are failures due to lack of wheel for macos 13 plus an issue with sdist:
https://github.com/Chia-Network/chia-blockchain/actions/runs/17922283319/job/50960403468?pr=20087
https://pypi.org/project/ruamel.yaml.clib/#files
https://sourceforge.net/p/ruamel-yaml-clib/tickets/47/
was changed from whatever macos arm (self-hosted i believe) to 13 specifically here
f276522#diff-ac5eead3f3ce4863c524fff031a87b7aecccb4a0493df087a4e1c704a1505036
i don't think we need to specifically use an old version here. we could indeed add a matrix dimension for os oldest/newest etc, but so far we have not done that and so i think whatever intel and whatever arm we can get is fine. we would generally prefer github-hosted so
macos-latestormacos-15would be the choices to consider i think.Current Behavior:
New Behavior:
Testing Notes: