CHIA-3788 Simplify tx_request_and_timeout by converting it from a closure into a FullNode class method #20186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
the
Changed
AmineKhaldi
force-pushed
the
simplify_tx_request_and_timeout
branch
from
11f7c54 to
3435fb7
Compare
AmineKhaldi
commented
Oct 22, 2025
arvidn
reviewed
Oct 22, 2025
…a FullNode class member.
AmineKhaldi
force-pushed
the
simplify_tx_request_and_timeout
branch
from
3435fb7 to
aecaeca
Compare
arvidn
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
The only thing that prevented its decoupling is capturing
transaction.transaction_idwhich we don't need as we have access totransaction_idas a param already.Current Behavior:
tx_request_and_timeoutis a closure, and is defined insideFullNodeAPI'snew_transactionwhere it acceptsFullNodeas a parameter.New Behavior:
tx_request_and_timeoutis aFullNodeclass method.Testing Notes: