[Fusion] Added Global Object Identification composition support (#8467)

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/src/Fusion.CommandLine/Commands/ComposeCommand.cs

@@ -4,6 +4,7 @@
 using System.Text;
 using System.Threading.Channels;
 using HotChocolate.Fusion.Logging;
+using HotChocolate.Fusion.Options;
 using static HotChocolate.Fusion.Properties.CommandLineResources;
 
 namespace HotChocolate.Fusion.Commands;
@@ -48,6 +49,11 @@ public ComposeCommand() : base("compose")
         compositeSchemaFileOption.AddAlias("-c");
         compositeSchemaFileOption.LegalFilePathsOnly();
 
+        var enableGlobalObjectIdentificationOption = new Option<bool>("--enable-global-object-identification")
+        {
+            Description = ComposeCommand_EnableGlobalObjectIdentification_Description
+        };
+
         var watchModeOption = new Option<bool>("--watch")
         {
             Arity = ArgumentArity.ZeroOrOne
@@ -56,20 +62,24 @@ public ComposeCommand() : base("compose")
         AddOption(workingDirectoryOption);
         AddOption(sourceSchemaFileOption);
         AddOption(compositeSchemaFileOption);
+        AddOption(enableGlobalObjectIdentificationOption);
         AddOption(watchModeOption);
 
         this.SetHandler(async context =>
         {
             var workingDirectory = context.ParseResult.GetValueForOption(workingDirectoryOption)!;
             var sourceSchemaFiles = context.ParseResult.GetValueForOption(sourceSchemaFileOption)!;
             var compositeSchemaFile = context.ParseResult.GetValueForOption(compositeSchemaFileOption);
+            var enableGlobalObjectIdentification =
+                context.ParseResult.GetValueForOption(enableGlobalObjectIdentificationOption);
             var watchMode = context.ParseResult.GetValueForOption(watchModeOption);
 
             context.ExitCode = await ExecuteAsync(
                 context.Console,
                 workingDirectory,
                 sourceSchemaFiles,
                 compositeSchemaFile,
+                enableGlobalObjectIdentification,
                 watchMode,
                 context.GetCancellationToken());
         });
@@ -80,6 +90,7 @@ private static async Task<int> ExecuteAsync(
         string workingDirectory,
         List<string> sourceSchemaFiles,
         string? compositeSchemaFile,
+        bool enableGlobalObjectIdentification,
         bool watchMode,
         CancellationToken cancellationToken)
     {
@@ -90,6 +101,7 @@ private static async Task<int> ExecuteAsync(
                 workingDirectory,
                 sourceSchemaFiles,
                 compositeSchemaFile,
+                enableGlobalObjectIdentification,
                 cancellationToken);
         }
 
@@ -98,6 +110,7 @@ private static async Task<int> ExecuteAsync(
             workingDirectory,
             sourceSchemaFiles,
             compositeSchemaFile,
+            enableGlobalObjectIdentification,
             cancellationToken);
     }
 
@@ -106,12 +119,19 @@ private static async Task<int> WatchComposeAsync(
         string workingDirectory,
         List<string> sourceSchemaFiles,
         string? compositeSchemaFile,
+        bool enableGlobalObjectIdentification,
         CancellationToken cancellationToken)
     {
         console.Out.WriteLine("🔍 Starting watch mode...");
 
         // Initial composition
-        await ComposeAsync(console, workingDirectory, sourceSchemaFiles, compositeSchemaFile, cancellationToken);
+        await ComposeAsync(
+            console,
+            workingDirectory,
+            sourceSchemaFiles,
+            compositeSchemaFile,
+            enableGlobalObjectIdentification,
+            cancellationToken);
 
         ImmutableSortedSet<string> sourceSchemaFilePaths;
 
@@ -144,6 +164,7 @@ private static async Task<int> WatchComposeAsync(
             workingDirectory,
             sourceSchemaFiles,
             compositeSchemaFile,
+            enableGlobalObjectIdentification,
             cancellationToken);
 
         // set up file watcher for source schema files
@@ -254,6 +275,7 @@ private static async Task ProcessCompositionRequestsAsync(
         string workingDirectory,
         List<string> sourceSchemaFiles,
         string? compositeSchemaFile,
+        bool enableGlobalObjectIdentification,
         CancellationToken cancellationToken)
     {
         var lastComposition = DateTime.MinValue;
@@ -284,6 +306,7 @@ await ComposeAsync(
                     workingDirectory,
                     sourceSchemaFiles,
                     compositeSchemaFile,
+                    enableGlobalObjectIdentification,
                     cancellationToken);
             }
             catch (Exception ex) when (ex is not OperationCanceledException)
@@ -339,6 +362,7 @@ private static async Task<int> ComposeAsync(
         string workingDirectory,
         List<string> sourceSchemaFiles,
         string? compositeSchemaFile,
+        bool enableGlobalObjectIdentification,
         CancellationToken cancellationToken)
     {
         IEnumerable<string> sourceSchemas;
@@ -356,8 +380,13 @@ private static async Task<int> ComposeAsync(
             return 1;
         }
 
+        var schemaComposerOptions = new SchemaComposerOptions
+        {
+            EnableGlobalObjectIdentification = enableGlobalObjectIdentification
+        };
         var compositionLog = new CompositionLog();
-        var schemaComposer = new SchemaComposer(sourceSchemas, compositionLog);
+        var schemaComposer = new SchemaComposer(sourceSchemas, schemaComposerOptions, compositionLog);
+
         var result = schemaComposer.Compose();
 
         WriteCompositionLog(

src/HotChocolate/Fusion-vnext/src/Fusion.CommandLine/Properties/CommandLineResources.Designer.cs

@@ -36,6 +36,9 @@
   <data name="ComposeCommand_Description" xml:space="preserve">
     <value>Composes multiple source schemas into a single composite schema.</value>
   </data>
+  <data name="ComposeCommand_EnableGlobalObjectIdentification_Description" xml:space="preserve">
+    <value>Determines whether the 'Query.node' field shall be added.</value>
+  </data>
   <data name="ComposeCommand_Error_NoSourceSchemaFilesFound" xml:space="preserve">
     <value>❌ No GraphQL schema files were found in the working directory.</value>
   </data>

src/HotChocolate/Fusion-vnext/src/Fusion.CommandLine/Properties/CommandLineResources.resx

@@ -1,3 +1,4 @@
+using HotChocolate.Language;
 using HotChocolate.Types;
 using HotChocolate.Types.Mutable;
 using static HotChocolate.Fusion.WellKnownArgumentNames;
@@ -61,6 +62,31 @@ public static IEnumerable<IDirective> GetFusionLookupDirectives(
         return lookupDirectives;
     }
 
+    public static IEnumerable<IDirective> GetFusionLookupDirectivesById(
+        this MutableObjectTypeDefinition type,
+        IEnumerable<MutableUnionTypeDefinition> unionTypes)
+    {
+        var lookups = new List<IDirective>();
+        var sourceSchemaNames = type.Directives.AsEnumerable()
+            .Where(d => d.Name == FusionType)
+            .Select(d => (string)d.Arguments[Schema].Value!);
+        unionTypes = unionTypes.ToList();
+
+        foreach (var sourceSchemaName in sourceSchemaNames)
+        {
+            foreach (var lookupDirective in type.GetFusionLookupDirectives(sourceSchemaName, unionTypes))
+            {
+                if (lookupDirective.Arguments[Map] is ListValueNode { Items.Count: 1 } mapArg
+                    && mapArg.Items[0].Value?.Equals(Id) == true)
+                {
+                    lookups.Add(lookupDirective);
+                }
+            }
+        }
+
+        return lookups;
+    }
+
     public static bool HasInternalDirective(this MutableObjectTypeDefinition type)
     {
         return type.Directives.ContainsName(Internal);

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Extensions/MutableObjectTypeDefinitionExtensions.cs

@@ -0,0 +1,6 @@
+namespace HotChocolate.Fusion.Options;
+
+public sealed class SchemaComposerOptions
+{
+    public bool EnableGlobalObjectIdentification { get; init; }
+}

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Options/SchemaComposerOptions.cs

@@ -5,4 +5,6 @@ internal sealed class SourceSchemaMergerOptions
     public bool RemoveUnreferencedTypes { get; init; } = true;
 
     public bool AddFusionDefinitions { get; init; } = true;
+
+    public bool EnableGlobalObjectIdentification { get; init; }
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Options/SourceSchemaMergerOptions.cs

@@ -363,6 +363,9 @@
   <data name="SatisfiabilityValidator_CycleDetected" xml:space="preserve">
     <value>Cycle detected: {0} -&gt; {1}.</value>
   </data>
+  <data name="SatisfiabilityValidator_NodeTypeHasNoLookupById" xml:space="preserve">
+    <value>Type '{0}' implements the 'Node' interface, but does not have a lookup by ID.</value>
+  </data>
   <data name="SatisfiabilityValidator_NoLookupsFoundForType" xml:space="preserve">
     <value>No lookups found for type '{0}' in schema '{1}'.</value>
   </data>