Skip to content

Commit 1a45997

Browse files
authored
Used StringBuilder.Append(char) for single character strings (#9032)
1 parent 42b3c75 commit 1a45997

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.editorconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,8 @@ dotnet_diagnostic.CA1513.severity = warning
183183
# Do not initialize unnecessarily.
184184
dotnet_diagnostic.CA1805.severity = warning
185185
dotnet_diagnostic.RCS1129.severity = none
186+
# Use StringBuilder.Append(char) for single character strings.
187+
dotnet_diagnostic.CA1834.severity = warning
186188
# Simplify name.
187189
dotnet_diagnostic.IDE0001.severity = warning
188190
# Simplify member access.

src/HotChocolate/Adapters/src/Adapters.OpenApi.Core/Parser/OpenApiDefinitionParser.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ private static (string Route, List<OpenApiEndpointDefinitionParameter> Parameter
182182

183183
foreach (var segment in stringValue.Split('/', StringSplitOptions.RemoveEmptyEntries))
184184
{
185-
routeBuilder.Append("/");
185+
routeBuilder.Append('/');
186186

187187
if (segment.StartsWith("{") && segment.EndsWith("}"))
188188
{

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/ClientQueryRequest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public override string ToString()
3535
{
3636
if (Id is not null)
3737
{
38-
query.Append("&");
38+
query.Append('&');
3939
}
4040
query.Append($"query={Query.Replace("\r", "").Replace("\n", "")}");
4141
}

src/HotChocolate/Core/src/Authorization/AuthorizeDirective.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ private static string BuildCacheKey(string? policy, IReadOnlyList<string>? roles
9999
sb.Append(policy);
100100
}
101101

102-
sb.Append(";");
102+
sb.Append(';');
103103

104104
if (roles is not null)
105105
{
@@ -109,7 +109,7 @@ private static string BuildCacheKey(string? policy, IReadOnlyList<string>? roles
109109

110110
if (i < roles.Count - 1)
111111
{
112-
sb.Append(",");
112+
sb.Append(',');
113113
}
114114
}
115115
}

0 commit comments

Comments
 (0)