Cleanup

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/OperationExecutionNode.cs

@@ -57,8 +57,6 @@ public OperationExecutionNode(
 
         _variables = variables.ToArray();
 
-        // TODO: This might include requirements that we wouldn't want to create a front-end facing error for
-        // TODO: How to deal with selections on a specific type? Creating errors for all possible response names is wrong
         _responseNames = GetResponseNamesFromPath(operation, source);
     }
 
@@ -332,13 +330,21 @@ private static ImmutableArray<string> GetResponseNamesFromPath(
 
         var responseNames = new List<string>();
 
-        foreach (var selection in selectionSet.Selections)
+        var stack = new Stack<ISelectionNode>(selectionSet.Selections);
+
+        while (stack.TryPop(out var selection))
         {
-            // TODO: We need to handle InlineFragmentNodes here
             if (selection is FieldNode fieldNode)
             {
                 responseNames.Add(fieldNode.Alias?.Value ?? fieldNode.Name.Value);
             }
+            else if (selection is InlineFragmentNode inlineFragmentNode)
+            {
+                foreach (var child in inlineFragmentNode.SelectionSet.Selections)
+                {
+                    stack.Push(child);
+                }
+            }
         }
 
         return [..responseNames];
@@ -359,7 +365,6 @@ private static ImmutableArray<string> GetResponseNamesFromPath(
 
             if (segment.Kind == SelectionPathSegmentKind.InlineFragment)
             {
-                // TODO: Do we need to handle the case without a type condition?
                 var selection = current.Selections
                     .OfType<InlineFragmentNode>()
                     .FirstOrDefault(s => s.TypeCondition?.Name.Value == segment.Name);
@@ -381,6 +386,7 @@ private static ImmutableArray<string> GetResponseNamesFromPath(
                 {
                     return null;
                 }
+
                 current = selection.SelectionSet;
             }
         }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Results/ValueCompletion.cs

@@ -89,7 +89,7 @@ public void BuildErrorResult(
         {
             var fieldResult = objectResult[responseName];
 
-            if (!fieldResult.Selection.IsIncluded(_includeFlags))
+            if (fieldResult.Selection.IsInternal || !fieldResult.Selection.IsIncluded(_includeFlags))
             {
                 continue;
             }

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/__snapshots__/SubgraphErrorTests.No_Data_And_Error_Without_Path_For_Lookup.snap

@@ -4,7 +4,7 @@
       "message": "A global error"
     },
     {
-      "message": "Unexpected execution error",
+      "message": "Unexpected Execution Error",
       "path": [
         "topProduct",
         "name"

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/__snapshots__/SubgraphErrorTests.No_Data_And_Error_Without_Path_For_Root_Field.snap

@@ -7,7 +7,7 @@
       "message": "A global error"
     },
     {
-      "message": "Unexpected execution error",
+      "message": "Unexpected Execution Error",
       "path": [
         "productById"
       ]