Skip to content

Commit 3b85c32

Browse files
glen-84glen-84
authored
Removed unused variables (#9020)
1 parent 7a3295e commit 3b85c32

File tree

155 files changed

+173
-96
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

155 files changed

+173
-96
lines changed

‎.editorconfig‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ resharper_enforce_if_statement_braces_highlighting = error
119119
resharper_enforce_lock_statement_braces_highlighting = error
120120
resharper_enforce_using_statement_braces_highlighting = error
121121
resharper_enforce_while_statement_braces_highlighting = error
122+
resharper_unused_variable_highlighting = warning
122123
resharper_use_utf8_string_literal_highlighting = error
123124
resharper_use_verbatim_string_highlighting = error
124125

‎src/GreenDonut/test/GreenDonut.Data.EntityFramework.Tests/PagingHelperTests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ public async Task QueryContext_Simple_Selector_Include_Brand()
241241

242242
await using var context = new CatalogContext(connectionString);
243243

244-
var page = await context.Products
244+
await context.Products
245245
.With(query)
246246
.ToPageAsync(arguments);
247247

@@ -271,7 +271,7 @@ public async Task QueryContext_Simple_Selector_Include_Brand_Name()
271271

272272
await using var context = new CatalogContext(connectionString);
273273

274-
var page = await context.Products
274+
await context.Products
275275
.With(query)
276276
.ToPageAsync(arguments);
277277

@@ -301,7 +301,7 @@ public async Task QueryContext_Simple_Selector_Include_Product_List()
301301

302302
await using var context = new CatalogContext(connectionString);
303303

304-
var page = await context.Brands
304+
await context.Brands
305305
.With(query)
306306
.ToPageAsync(arguments);
307307

‎src/HotChocolate/Adapters/test/Adapters.OpenApi.Tests/OpenApi/OpenApiIntegrationTestBase.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ query GetUsers @http(method: GET, route: "/users") {
675675

676676
// act
677677
// assert
678-
var openApiDocument1 = await GetOpenApiDocumentAsync(client);
678+
await GetOpenApiDocumentAsync(client);
679679

680680
storage.AddOrUpdateDocument(
681681
"users",

‎src/HotChocolate/Core/src/Types.Analyzers/DataAttributeOrderAnalyzer.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private static void AnalyzeMethodDeclaration(SyntaxNodeAnalysisContext context)
6969

7070
// Check if the order is correct
7171
var previousOrder = -1;
72-
foreach (var (attribute, order, _) in dataAttributes)
72+
foreach (var (_, order, _) in dataAttributes)
7373
{
7474
if (order < previousOrder)
7575
{

‎src/HotChocolate/Core/src/Types.Analyzers/DataAttributeOrderCodeFixProvider.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private static async Task<Document> ReorderAttributesAsync(
119119

120120
// Add non-data attributes in their original relative order
121121
var processedLists = new HashSet<AttributeListSyntax>();
122-
foreach (var (attribute, originalList, _, _) in nonDataAttributes)
122+
foreach (var (_, originalList, _, _) in nonDataAttributes)
123123
{
124124
if (processedLists.Contains(originalList))
125125
{

‎src/HotChocolate/Core/src/Types.Analyzers/Helpers/TypeReferenceBuilder.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,6 @@ private static string MakeGraphQLCompliant(string typeName)
361361
var dimensions = 1;
362362
while (i < typeName.Length && typeName[i] == '[')
363363
{
364-
var start = i;
365364
while (i < typeName.Length && typeName[i] != ']')
366365
{
367366
i++;

‎src/HotChocolate/Core/test/Abstractions.Tests/FieldResultTests.cs‎

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public void Union_2_Cast_Error_Null()
187187
{
188188
void Error()
189189
{
190-
FieldResult<string, ErrorObj1> result = default(ErrorObj1)!;
190+
FieldResult<string, ErrorObj1> _ = default(ErrorObj1)!;
191191
}
192192

193193
Assert.Throws<ArgumentNullException>(Error);
@@ -426,7 +426,7 @@ public void Union_3_Cast_Error_1_Null()
426426
{
427427
void Error()
428428
{
429-
FieldResult<string, ErrorObj1, ErrorObj2> result = default(ErrorObj1)!;
429+
FieldResult<string, ErrorObj1, ErrorObj2> _ = default(ErrorObj1)!;
430430
}
431431

432432
Assert.Throws<ArgumentNullException>(Error);
@@ -545,7 +545,7 @@ public void Union_3_Cast_Error_2_Null()
545545
{
546546
void Error()
547547
{
548-
FieldResult<string, ErrorObj1, ErrorObj2> result = default(ErrorObj2)!;
548+
FieldResult<string, ErrorObj1, ErrorObj2> _ = default(ErrorObj2)!;
549549
}
550550

551551
Assert.Throws<ArgumentNullException>(Error);
@@ -798,7 +798,7 @@ public void Union_4_Cast_Error_1_Null()
798798
{
799799
void Error()
800800
{
801-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> result = default(ErrorObj1)!;
801+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> _ = default(ErrorObj1)!;
802802
}
803803

804804
Assert.Throws<ArgumentNullException>(Error);
@@ -926,7 +926,7 @@ public void Union_4_Cast_Error_2_Null()
926926
{
927927
void Error()
928928
{
929-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> result = default(ErrorObj2)!;
929+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> _ = default(ErrorObj2)!;
930930
}
931931

932932
Assert.Throws<ArgumentNullException>(Error);
@@ -1054,7 +1054,7 @@ public void Union_4_Cast_Error_3_Null()
10541054
{
10551055
void Error()
10561056
{
1057-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> result = default(ErrorObj3)!;
1057+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3> _ = default(ErrorObj3)!;
10581058
}
10591059

10601060
Assert.Throws<ArgumentNullException>(Error);
@@ -1323,8 +1323,7 @@ public void Union_5_Cast_Error_1_Null()
13231323
{
13241324
void Error()
13251325
{
1326-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> result =
1327-
default(ErrorObj1)!;
1326+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> _ = default(ErrorObj1)!;
13281327
}
13291328

13301329
Assert.Throws<ArgumentNullException>(Error);
@@ -1456,8 +1455,7 @@ public void Union_5_Cast_Error_2_Null()
14561455
{
14571456
void Error()
14581457
{
1459-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> result =
1460-
default(ErrorObj2)!;
1458+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> _ = default(ErrorObj2)!;
14611459
}
14621460

14631461
Assert.Throws<ArgumentNullException>(Error);
@@ -1589,8 +1587,7 @@ public void Union_5_Cast_Error_3_Null()
15891587
{
15901588
void Error()
15911589
{
1592-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> result =
1593-
default(ErrorObj3)!;
1590+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> _ = default(ErrorObj3)!;
15941591
}
15951592

15961593
Assert.Throws<ArgumentNullException>(Error);
@@ -1722,8 +1719,7 @@ public void Union_5_Cast_Error_4_Null()
17221719
{
17231720
void Error()
17241721
{
1725-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> result =
1726-
default(ErrorObj4)!;
1722+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4> _ = default(ErrorObj4)!;
17271723
}
17281724

17291725
Assert.Throws<ArgumentNullException>(Error);
@@ -2007,7 +2003,7 @@ public void Union_6_Cast_Error_1_Null()
20072003
{
20082004
void Error()
20092005
{
2010-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> result =
2006+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> _ =
20112007
default(ErrorObj1)!;
20122008
}
20132009

@@ -2146,7 +2142,7 @@ public void Union_6_Cast_Error_2_Null()
21462142
{
21472143
void Error()
21482144
{
2149-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> result =
2145+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> _ =
21502146
default(ErrorObj2)!;
21512147
}
21522148

@@ -2285,7 +2281,7 @@ public void Union_6_Cast_Error_3_Null()
22852281
{
22862282
void Error()
22872283
{
2288-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> result =
2284+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> _ =
22892285
default(ErrorObj3)!;
22902286
}
22912287

@@ -2424,7 +2420,7 @@ public void Union_6_Cast_Error_4_Null()
24242420
{
24252421
void Error()
24262422
{
2427-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> result =
2423+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> _ =
24282424
default(ErrorObj4)!;
24292425
}
24302426

@@ -2563,7 +2559,7 @@ public void Union_6_Cast_Error_5_Null()
25632559
{
25642560
void Error()
25652561
{
2566-
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> result =
2562+
FieldResult<string, ErrorObj1, ErrorObj2, ErrorObj3, ErrorObj4, ErrorObj5> _ =
25672563
default(ErrorObj5)!;
25682564
}
25692565

‎src/HotChocolate/Core/test/Types.Tests/Extensions/SchemaBuilderExtensions.Resolvers.Tests.cs‎

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ public class SchemaBuilderExtensionsResolversTests
99
[Fact]
1010
public void AddResolverContextObject_BuilderIsNull_ArgNullExcept()
1111
{
12-
// arrange
13-
var builder = SchemaBuilder.New();
14-
15-
// act
12+
// arrange & act
1613
Action action = () => SchemaBuilderExtensions
1714
.AddResolver(
1815
null!,
@@ -65,10 +62,7 @@ await builder.Create()
6562
[Fact]
6663
public void AddResolverContextTaskObject_BuilderIsNull_ArgNullExcept()
6764
{
68-
// arrange
69-
var builder = SchemaBuilder.New();
70-
71-
// act
65+
// arrange & act
7266
Action action = () => SchemaBuilderExtensions
7367
.AddResolver(
7468
null!,
@@ -124,10 +118,7 @@ await builder.Create()
124118
[Fact]
125119
public void AddResolverContextTResult_BuilderIsNull_ArgNullExcept()
126120
{
127-
// arrange
128-
var builder = SchemaBuilder.New();
129-
130-
// act
121+
// arrange & act
131122
Action action = () => SchemaBuilderExtensions
132123
.AddResolver(
133124
null!,
@@ -184,10 +175,7 @@ await builder.Create()
184175
[Fact]
185176
public void AddResolverContextTaskTResult_BuilderIsNull_ArgNullExcept()
186177
{
187-
// arrange
188-
var builder = SchemaBuilder.New();
189-
190-
// act
178+
// arrange & act
191179
Action action = () => SchemaBuilderExtensions
192180
.AddResolver(
193181
null!,
@@ -244,10 +232,7 @@ await builder.Create()
244232
[Fact]
245233
public void AddResolverObject_BuilderIsNull_ArgNullExcept()
246234
{
247-
// arrange
248-
var builder = SchemaBuilder.New();
249-
250-
// act
235+
// arrange & act
251236
Action action = () => SchemaBuilderExtensions
252237
.AddResolver(
253238
null!,

‎src/HotChocolate/Core/test/Types.Tests/Extensions/SchemaBuilderExtensions.Types.Tests.cs‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -493,10 +493,7 @@ public void AddSubscriptionTypeObjType_TypeIsFooType_SchemaIsCreated()
493493
[Fact]
494494
public void SetSchema_BuilderIsNull_ArgumentException()
495495
{
496-
// arrange
497-
var builder = SchemaBuilder.New();
498-
499-
// act
496+
// arrange & act
500497
Action action = () =>
501498
SchemaBuilderExtensions.SetSchema<MySchema>(null!);
502499

‎src/HotChocolate/Core/test/Types.Tests/SchemaBuilderTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1762,7 +1762,7 @@ public void ConventionExtension_Should_AddConvention_When_CalledWithInstance()
17621762
.AddConvention<IMockConvention>(convention)
17631763
.AddConvention<IMockConvention>(new MockConventionExtension())
17641764
.Create();
1765-
var result = context.GetConventionOrDefault<IMockConvention>(
1765+
context.GetConventionOrDefault<IMockConvention>(
17661766
() => throw new InvalidOperationException());
17671767

17681768
// assert

0 commit comments

Comments
 (0)