Fixed issue when sealing selections (#8426)

Author: michaelstaib

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Nodes/SelectionSet.cs

@@ -48,5 +48,10 @@ internal void Seal(Operation operation)
 
         _isSealed = true;
         DeclaringOperation = operation;
+
+        foreach (var selection in Selections)
+        {
+            selection.Seal(this);
+        }
     }
 }

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/FusionTestBase.cs

@@ -1,70 +1,17 @@
-using System.Diagnostics.CodeAnalysis;
 using HotChocolate.Execution;
 using HotChocolate.Execution.Configuration;
-using HotChocolate.Fusion.Configuration;
-using HotChocolate.Fusion.Execution;
-using HotChocolate.Fusion.Execution.Nodes;
 using HotChocolate.Fusion.Logging;
-using HotChocolate.Fusion.Planning;
-using HotChocolate.Fusion.Rewriters;
-using HotChocolate.Fusion.Types;
-using HotChocolate.Language;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.TestHost;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.ObjectPool;
 
 namespace HotChocolate.Fusion;
 
 public abstract class FusionTestBase : IDisposable
 {
-    private readonly TestServerSession _testServerSession = new();
+    internal readonly TestServerSession _testServerSession = new();
     private bool _disposed;
 
-    protected static FusionSchemaDefinition CreateCompositeSchema()
-    {
-        var compositeSchemaDoc = Utf8GraphQLParser.Parse(FileResource.Open("fusion1.graphql"));
-        return FusionSchemaDefinition.Create(compositeSchemaDoc);
-    }
-
-    protected static FusionSchemaDefinition CreateCompositeSchema(
-        [StringSyntax("graphql")] string schema)
-    {
-        var compositeSchemaDoc = Utf8GraphQLParser.Parse(schema);
-        return FusionSchemaDefinition.Create(compositeSchemaDoc);
-    }
-
-    protected static FusionSchemaDefinition ComposeSchema(
-        [StringSyntax("graphql")] params string[] schemas)
-    {
-        var compositionLog = new CompositionLog();
-        var composer = new SchemaComposer(schemas, compositionLog);
-        var result = composer.Compose();
-
-        if (!result.IsSuccess)
-        {
-            throw new InvalidOperationException(result.Errors[0].Message);
-        }
-
-        var compositeSchemaDoc = result.Value.ToSyntaxNode();
-        return FusionSchemaDefinition.Create(compositeSchemaDoc);
-    }
-
-    protected static DocumentNode ComposeSchemaDocument(
-        [StringSyntax("graphql")] params string[] schemas)
-    {
-        var compositionLog = new CompositionLog();
-        var composer = new SchemaComposer(schemas, compositionLog);
-        var result = composer.Compose();
-
-        if (!result.IsSuccess)
-        {
-            throw new InvalidOperationException(result.Errors[0].Message);
-        }
-
-        return result.Value.ToSyntaxNode();
-    }
-
     public TestServer CreateSourceSchema(
         string schemaName,
         Action<IRequestExecutorBuilder> configureBuilder,
@@ -141,33 +88,6 @@ public async Task<TestServer> CreateCompositeSchemaAsync(
             configureApplication);
     }
 
-    protected static OperationExecutionPlan PlanOperation(
-        FusionSchemaDefinition schema,
-        [StringSyntax("graphql")] string operationText)
-    {
-        var pool = new DefaultObjectPool<OrderedDictionary<string, List<FieldSelectionNode>>>(
-            new DefaultPooledObjectPolicy<OrderedDictionary<string, List<FieldSelectionNode>>>());
-
-        var operationDoc = Utf8GraphQLParser.Parse(operationText);
-
-        var rewriter = new InlineFragmentOperationRewriter(schema);
-        var rewritten = rewriter.RewriteDocument(operationDoc, operationName: null);
-        var operation = rewritten.Definitions.OfType<OperationDefinitionNode>().First();
-
-        var compiler = new OperationCompiler(schema, pool);
-        var planner = new OperationPlanner(schema, compiler);
-        return planner.CreatePlan("123", operation);
-    }
-
-    protected static void MatchInline(
-        OperationExecutionPlan plan,
-        [StringSyntax("yaml")] string expected)
-    {
-        var formatter = new YamlExecutionPlanFormatter();
-        var actual = formatter.Format(plan);
-        actual.MatchInlineSnapshot(expected + Environment.NewLine);
-    }
-
     public void Dispose()
     {
         if (_disposed)

src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/IntegrationTests.cs

@@ -1,12 +1,7 @@
-using System.Text;
-using HotChocolate.Buffers;
-using HotChocolate.Types;
-using HotChocolate.Execution;
-using HotChocolate.Transport.Formatters;
 using HotChocolate.Transport.Http;
-using Microsoft.AspNetCore.TestHost;
+using HotChocolate.Types;
+using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.DependencyInjection.Extensions;
 
 namespace HotChocolate.Fusion;
 
@@ -21,7 +16,7 @@ public async Task Foo()
             b => b.AddQueryType(
                 d => d.Name("Query")
                     .Field("foo")
-                    .Resolve("foo")) );
+                    .Resolve("foo")));
 
         using var server2 = CreateSourceSchema(
             "B",
@@ -51,4 +46,48 @@ public async Task Foo()
         using var response = await result.ReadAsResultAsync();
         response.MatchSnapshot();
     }
+
+    [Fact]
+    public async Task Bar()
+    {
+        var server = _testServerSession.CreateServer(
+            services =>
+            {
+                services.AddRouting();
+
+                services
+                    .AddHttpClient("SUBGRAPH1", c => c.BaseAddress = new Uri("http://localhost:5095/graphql"));
+
+                services
+                    .AddHttpClient("SUBGRAPH2", c => c.BaseAddress = new Uri("http://localhost:5096/graphql"));
+
+                services
+                    .AddGraphQLGatewayServer()
+                    .AddFileSystemConfiguration("/Users/michael/local/play/FusionServer/Gateway/gateway.graphql")
+                    .AddHttpClientConfiguration("SUBGRAPH1", new Uri("http://localhost:5095/graphql"))
+                    .AddHttpClientConfiguration("SUBGRAPH2", new Uri("http://localhost:5096/graphql"));
+            },
+            app =>
+            {
+                app.UseWebSockets();
+                app.UseRouting();
+                app.UseEndpoints(endpoint => endpoint.MapGraphQL());
+            });
+
+        using var client = GraphQLHttpClient.Create(server.CreateClient());
+
+        using var result = await client.PostAsync(
+            """
+            {
+                book {
+                  title
+                }
+            }
+            """,
+            new Uri("http://localhost:5000/graphql"));
+
+        // act
+        using var response = await result.ReadAsResultAsync();
+        response.MatchSnapshot();
+    }
 }