Added a watch mode for the composition tooling. (#8469)

michaelstaib · web-flow · commit 46148d28abd3 · 2025-07-28T23:44:57.000+02:00
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Inaccessible.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Inaccessible.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleDescriptorExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InaccessibleDescriptorExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Internal.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Internal.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InternalAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InternalAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InternalDirectiveExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/InternalDirectiveExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Is.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Is.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Fusion.Language;
 
 namespace HotChocolate.Types.Composite;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/IsAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/IsAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/IsDescriptorExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/IsDescriptorExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Fusion.Language;
 
 namespace HotChocolate.Types.Composite;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Key.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Key.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Language;
 
 namespace HotChocolate.Types.Composite;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/KeyAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/KeyAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/KeyDescriptorExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/KeyDescriptorExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Language;
 
 namespace HotChocolate.Types.Composite;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Lookup.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Lookup.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/LookupAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/LookupAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/LookupDirectiveExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/LookupDirectiveExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Provides.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Provides.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Language;
 using HotChocolate.Types.Descriptors;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Require.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Require.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Fusion.Language;
 
 namespace HotChocolate.Types.Composite;
@@ -16,7 +18,7 @@ namespace HotChocolate.Types.Composite;
 /// </para>
 /// </summary>
 [DirectiveType(
-    DirectiveNames.Lookup.Name,
+    DirectiveNames.Require.Name,
     DirectiveLocation.ArgumentDefinition,
     IsRepeatable = false)]
 public sealed class Require
@@ -50,6 +52,8 @@ public Require(string field)
     /// <summary>
     /// Gets the field selection map.
     /// </summary>
+    [GraphQLName(DirectiveNames.Require.Arguments.Field)]
+    [GraphQLDescription("The field selection map syntax.")]
     [GraphQLType<NonNullType<FieldSelectionMapType>>]
     public IValueSelectionNode Field { get; }
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/RequireAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/RequireAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
@@ -25,20 +27,29 @@ public class RequireAttribute : ArgumentDescriptorAttribute
     /// <exception cref="ArgumentNullException">
     /// The <paramref name="field"/> is <c>null</c>.
     /// </exception>
-    public RequireAttribute(string field)
+    public RequireAttribute(string? field = null)
     {
-        ArgumentNullException.ThrowIfNull(field);
         Field = field;
     }
 
     /// <summary>
     /// Gets the field selection map.
     /// </summary>
-    public string Field { get; }
+    public string? Field { get; }
 
     protected override void OnConfigure(
         IDescriptorContext context,
         IArgumentDescriptor descriptor,
         ParameterInfo parameter)
-        => descriptor.Require(Field);
+    {
+        var field = Field;
+
+        if (string.IsNullOrEmpty(field))
+        {
+            // todo : this works only for leafs, we need to validate this.
+            field = context.Naming.GetArgumentName(parameter);
+        }
+
+        descriptor.Require(field);
+    }
 }
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/RequireDescriptorExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/RequireDescriptorExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Fusion.Language;
 
 namespace HotChocolate.Types.Composite;
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Shareable.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/Shareable.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 namespace HotChocolate.Types.Composite;
 
 /// <summary>
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/ShareableAttribute.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/ShareableAttribute.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using System.Reflection;
 using HotChocolate.Types.Descriptors;
 
diff --git a/src/HotChocolate/Core/src/Types/Types/Composite/Directives/ShareableDirectiveExtensions.cs b/src/HotChocolate/Core/src/Types/Types/Composite/Directives/ShareableDirectiveExtensions.cs
@@ -1,3 +1,5 @@
+#nullable enable
+
 using HotChocolate.Types.Descriptors.Configurations;
 using HotChocolate.Types.Helpers;
 
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/Composite/LookupTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/Composite/LookupTests.cs
@@ -205,7 +205,7 @@ public static async Task Require_With_Explicit_Field()
             }
 
             type Book5 {
-              someField(author: String! @lookup(field: "author")): String!
+              someField(author: String! @require(field: "author")): String!
               id: Int!
               title: String!
             }
@@ -222,7 +222,7 @@ Arguments annotated with the @require directive are removed from the composite s
 
             directive @require(field: FieldSelectionMap!) on ARGUMENT_DEFINITION
             """
-            directive @lookup("Gets the field selection map." field: FieldSelectionMap!) on ARGUMENT_DEFINITION
+            directive @require("The field selection map syntax." field: FieldSelectionMap!) on ARGUMENT_DEFINITION
 
             scalar FieldSelectionMap
             """");
diff --git a/src/HotChocolate/Fusion-vnext/src/Fusion.CommandLine/Commands/ComposeCommand.cs b/src/HotChocolate/Fusion-vnext/src/Fusion.CommandLine/Commands/ComposeCommand.cs
diff --git a/src/HotChocolate/Primitives/src/Primitives/Types/WellKnownDirectives.cs b/src/HotChocolate/Primitives/src/Primitives/Types/WellKnownDirectives.cs

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#nullable enable`
	`2`	`+`
`1`	`3`	`namespace HotChocolate.Types.Composite;`
`2`	`4`
`3`	`5`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#nullable enable`
	`2`	`+`
`1`	`3`	`using System.Reflection;`
`2`	`4`	`using HotChocolate.Types.Descriptors;`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#nullable enable`
	`2`	`+`
`1`	`3`	`using HotChocolate.Fusion.Language;`
`2`	`4`
`3`	`5`	`namespace HotChocolate.Types.Composite;`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#nullable enable`
	`2`	`+`
`1`	`3`	`using HotChocolate.Language;`
`2`	`4`
`3`	`5`	`namespace HotChocolate.Types.Composite;`