Fixed nullability on some type descriptors. (#8542)

Author: PascalSenn

src/HotChocolate/Core/src/Types/Types/Attributes/DefaultValueSyntaxAttribute.cs

@@ -33,35 +33,35 @@ public sealed class DefaultValueSyntaxAttribute : DescriptorAttribute
     /// <summary>
     /// Creates a new instance of <see cref="DefaultValueSyntaxAttribute"/>.
     /// </summary>
-    public DefaultValueSyntaxAttribute(string? syntax)
+    public DefaultValueSyntaxAttribute(string syntax)
     {
         Syntax = syntax;
     }
 
     /// <summary>
     /// The GraphQL syntax of the default value.
     /// </summary>
-    public string? Syntax { get; }
+    public string Syntax { get; }
 
     /// <inheritdoc />
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
         ICustomAttributeProvider element)
     {
-        if (descriptor is IArgumentDescriptor arg)
+        switch (descriptor)
         {
-            arg.DefaultValueSyntax(Syntax);
-        }
+            case IArgumentDescriptor arg:
+                arg.DefaultValueSyntax(Syntax);
+                break;
 
-        if (descriptor is IDirectiveArgumentDescriptor darg)
-        {
-            darg.DefaultValueSyntax(Syntax);
-        }
+            case IDirectiveArgumentDescriptor arg:
+                arg.DefaultValueSyntax(Syntax);
+                break;
 
-        if (descriptor is IInputFieldDescriptor field)
-        {
-            field.DefaultValueSyntax(Syntax);
+            case IInputFieldDescriptor arg:
+                arg.DefaultValueSyntax(Syntax);
+                break;
         }
     }
 }

src/HotChocolate/Core/src/Types/Types/Extensions/DirectiveTypeDescriptorExtensions.cs

@@ -7,7 +7,7 @@ public static class DirectiveTypeDescriptorExtensions
 {
     public static IDirectiveTypeDescriptor<T> Ignore<T>(
         this IDirectiveTypeDescriptor<T> descriptor,
-        Expression<Func<T, object>> property)
+        Expression<Func<T, object?>> property)
     {
         ArgumentNullException.ThrowIfNull(descriptor);
         ArgumentNullException.ThrowIfNull(property);

src/HotChocolate/Core/src/Types/Types/Extensions/InputObjectTypeDescriptorExtensions.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Linq.Expressions;
 using HotChocolate.Language;
 using System.Diagnostics.CodeAnalysis;
@@ -32,7 +30,7 @@ public static class InputObjectTypeDescriptorExtensions
     /// </exception>
     public static IInputObjectTypeDescriptor<T> Ignore<T>(
         this IInputObjectTypeDescriptor<T> descriptor,
-        Expression<Func<T, object>> property)
+        Expression<Func<T, object?>> property)
     {
         ArgumentNullException.ThrowIfNull(descriptor);
         ArgumentNullException.ThrowIfNull(property);

src/HotChocolate/Core/src/Types/Types/Extensions/InterfaceTypeDescriptorExtensions.cs

@@ -7,7 +7,7 @@ public static class InterfaceTypeDescriptorExtensions
 {
     public static IInterfaceTypeDescriptor<T> Ignore<T>(
         this IInterfaceTypeDescriptor<T> descriptor,
-        Expression<Func<T, object>> propertyOrMethod)
+        Expression<Func<T, object?>> propertyOrMethod)
     {
         ArgumentNullException.ThrowIfNull(descriptor);
         ArgumentNullException.ThrowIfNull(propertyOrMethod);

src/HotChocolate/Core/src/Types/Types/Extensions/ObjectTypeDescriptorExtensions.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Linq.Expressions;
 using HotChocolate.Language;
 
@@ -12,7 +10,7 @@ public static class ObjectTypeDescriptorExtensions
 {
     public static IObjectTypeDescriptor<T> Ignore<T>(
         this IObjectTypeDescriptor<T> descriptor,
-        Expression<Func<T, object>> propertyOrMethod)
+        Expression<Func<T, object?>> propertyOrMethod)
     {
         ArgumentNullException.ThrowIfNull(descriptor);
         ArgumentNullException.ThrowIfNull(propertyOrMethod);

src/HotChocolate/Core/test/Types.Tests/Types/InputObjectTypeTests.cs

@@ -369,7 +369,7 @@ public void Ignore_DescriptorIsNull_ArgumentNullException()
         // arrange
         // act
         void Action()
-            => InputObjectTypeDescriptorExtensions.Ignore<SimpleInput>(null, t => t.Id);
+            => InputObjectTypeDescriptorExtensions.Ignore<SimpleInput>(null!, t => t.Id);
 
         // assert
         Assert.Throws<ArgumentNullException>(Action);
@@ -384,7 +384,7 @@ public void Ignore_ExpressionIsNull_ArgumentNullException()
                 DescriptorContext.Create());
 
         // act
-        void Action() => descriptor.Ignore(null);
+        void Action() => descriptor.Ignore(null!);
 
         // assert
         Assert.Throws<ArgumentNullException>(Action);
@@ -721,15 +721,15 @@ input Foo {
     [Fact]
     public void OneOf_descriptor_is_null()
     {
-        void Fail() => InputObjectTypeDescriptorExtensions.OneOf(null);
+        void Fail() => InputObjectTypeDescriptorExtensions.OneOf(null!);
 
         Assert.Throws<ArgumentNullException>(Fail);
     }
 
     [Fact]
     public void OneOf_generic_descriptor_is_null()
     {
-        void Fail() => InputObjectTypeDescriptorExtensions.OneOf<object>(null);
+        void Fail() => InputObjectTypeDescriptorExtensions.OneOf<object>(null!);
 
         Assert.Throws<ArgumentNullException>(Fail);
     }