Used compound assignment (#8390)

Author: glen-84

.editorconfig

@@ -183,10 +183,14 @@ dotnet_diagnostic.IDE0051.severity = warning
 dotnet_diagnostic.RCS1213.severity = none
 # Remove unread private member.
 dotnet_diagnostic.IDE0052.severity = warning
+# Use compound assignment.
+dotnet_diagnostic.IDE0054.severity = warning
 # Formatting rule.
 dotnet_diagnostic.IDE0055.severity = warning
 # Use range operator.
 dotnet_diagnostic.IDE0057.severity = warning
+# Use compound assignment.
+dotnet_diagnostic.IDE0074.severity = warning
 # Use pattern matching (not operator).
 dotnet_diagnostic.IDE0083.severity = warning
 # Use collection expression for array.

src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs

@@ -689,11 +689,7 @@ private sealed class InterceptorHolder
 
     internal static void SetQueryInterceptor(PagingQueryInterceptor pagingQueryInterceptor)
     {
-        if (s_interceptor.Value is null)
-        {
-            s_interceptor.Value = new InterceptorHolder();
-        }
-
+        s_interceptor.Value ??= new InterceptorHolder();
         s_interceptor.Value.Interceptor = pagingQueryInterceptor;
     }
 

src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions.IsolatedProcess/AzureHttpResponse.cs

@@ -27,10 +27,7 @@ internal HttpResponseData ResponseData
             {
                 lock (_sync)
                 {
-                    if (_responseData is null)
-                    {
-                        _responseData = _requestData.CreateResponse();
-                    }
+                    _responseData ??= _requestData.CreateResponse();
                 }
             }
 
@@ -54,10 +51,7 @@ public override IHeaderDictionary Headers
             {
                 lock (_sync)
                 {
-                    if (_headers is null)
-                    {
-                        _headers = new AzureHeaderDictionary(_response, ResponseData);
-                    }
+                    _headers ??= new AzureHeaderDictionary(_response, ResponseData);
                 }
             }
             return _headers;

src/HotChocolate/Core/src/Execution/Configuration/ConfigurationContext.cs

@@ -64,10 +64,7 @@ public IDescriptorContext DescriptorContext
     {
         get
         {
-            if (_descriptorContext is null)
-            {
-                _descriptorContext = SchemaBuilder.CreateContext();
-            }
+            _descriptorContext ??= SchemaBuilder.CreateContext();
 
             return _descriptorContext;
         }

src/HotChocolate/Core/src/Execution/DependencyInjection/Factories/DeferredWorkStateOwnerFactory.cs

@@ -30,10 +30,7 @@ public DeferredWorkStateOwner Create()
         {
             lock (_sync)
             {
-                if (_owner is null)
-                {
-                    _owner = new DeferredWorkStateOwner(_pool);
-                }
+                _owner ??= new DeferredWorkStateOwner(_pool);
             }
         }
 

src/HotChocolate/Core/src/Types.CursorPagination/Extensions/PagingObjectFieldDescriptorExtensions.cs

@@ -319,14 +319,11 @@ private static TypeReference CreateConnectionTypeRef(
     {
         var typeInspector = context.TypeInspector;
 
-        if (nodeType is null)
-        {
-            // if there is no explicit node type provided we will try and
-            // infer the schema type from the resolver member.
-            nodeType = TypeReference.Create(
-                PagingHelper.GetSchemaType(context, resolverMember),
-                TypeContext.Output);
-        }
+        // if there is no explicit node type provided we will try and
+        // infer the schema type from the resolver member.
+        nodeType ??= TypeReference.Create(
+            PagingHelper.GetSchemaType(context, resolverMember),
+            TypeContext.Output);
 
         // if the node type is a syntax type reference we will try to preserve the actual
         // runtime type for later usage.

src/HotChocolate/Core/src/Types/Internal/ExtendedType.Members.cs

@@ -95,10 +95,7 @@ private static ExtendedType Rewrite(
                     }
                 }
 
-                if (elementType is null)
-                {
-                    elementType = ExtendedType.FromType(itemType, cache);
-                }
+                elementType ??= ExtendedType.FromType(itemType, cache);
             }
 
             if (extendedType.IsArray && elementType is null)

src/HotChocolate/Core/src/Types/Resolvers/FieldMember.cs

@@ -138,10 +138,7 @@ public override string ToString()
 
     public FieldReference ToFieldReference()
     {
-        if (_fieldReference is null)
-        {
-            _fieldReference = new FieldReference(TypeName, FieldName);
-        }
+        _fieldReference ??= new FieldReference(TypeName, FieldName);
         return _fieldReference;
     }
 }

src/HotChocolate/Core/src/Types/SchemaErrorBuilder.cs

@@ -58,10 +58,7 @@ public SchemaErrorBuilder SetExtension(string key, object value)
     public SchemaErrorBuilder SetException(Exception exception)
     {
         _error.Exception = exception;
-        if (_error.Message is null)
-        {
-            _error.Message = exception.Message;
-        }
+        _error.Message ??= exception.Message;
         return this;
     }
 

src/HotChocolate/Core/src/Types/Types/Descriptors/Conventions/DescriptorContext.cs

@@ -66,17 +66,14 @@ public INamingConventions Naming
     {
         get
         {
-            if (_naming is null)
-            {
-                _naming = GetConventionOrDefault<INamingConventions>(() => Options.UseXmlDocumentation
-                    ? new DefaultNamingConventions(
-                        new XmlDocumentationProvider(
-                            new XmlDocumentationFileResolver(
-                                Options.ResolveXmlDocumentationFileName),
-                            _serviceHelper.GetStringBuilderPool()))
-                    : new DefaultNamingConventions(
-                        new NoopDocumentationProvider()));
-            }
+            _naming ??= GetConventionOrDefault<INamingConventions>(() => Options.UseXmlDocumentation
+                ? new DefaultNamingConventions(
+                    new XmlDocumentationProvider(
+                        new XmlDocumentationFileResolver(
+                            Options.ResolveXmlDocumentationFileName),
+                        _serviceHelper.GetStringBuilderPool()))
+                : new DefaultNamingConventions(
+                    new NoopDocumentationProvider()));
 
             return _naming;
         }
@@ -87,11 +84,8 @@ public ITypeInspector TypeInspector
     {
         get
         {
-            if (_inspector is null)
-            {
-                _inspector = this.GetConventionOrDefault<ITypeInspector>(
-                    new DefaultTypeInspector());
-            }
+            _inspector ??= this.GetConventionOrDefault<ITypeInspector>(
+                new DefaultTypeInspector());
 
             return _inspector;
         }