Skip to content

Commit 6d37437

Browse files
authored
Removed unnecessary usage of verbatim string literals (#8953)
1 parent 42da2fa commit 6d37437

File tree

11 files changed

+19
-17
lines changed

11 files changed

+19
-17
lines changed

.editorconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,8 @@ dotnet_diagnostic.IDE0031.severity = none
272272
dotnet_diagnostic.RCS1160.severity = warning
273273
# Use constant instead of field.
274274
dotnet_diagnostic.RCS1187.severity = warning
275+
# Unnecessary usage of verbatim string literal.
276+
dotnet_diagnostic.RCS1192.severity = warning
275277
# Order named arguments according to the order of parameters.
276278
dotnet_diagnostic.RCS1205.severity = warning
277279
# Convert interpolated string to concatenation.

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/TestOperationDocumentStorage.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ public TestOperationDocumentStorage()
1212
{
1313
_cache.Add(
1414
"60ddx_GGk4FDObSa6eK0sg",
15-
Utf8GraphQLParser.Parse(@"query GetHeroName { hero { name } }"));
15+
Utf8GraphQLParser.Parse("query GetHeroName { hero { name } }"));
1616

1717
_cache.Add(
1818
"abc123",
19-
Utf8GraphQLParser.Parse(@"query Test($if: Boolean!) { hero { name @skip(if: $if) } }"));
19+
Utf8GraphQLParser.Parse("query Test($if: Boolean!) { hero { name @skip(if: $if) } }"));
2020

2121
_cache.Add(
2222
"a73defcdf38e5891e91b9ba532cf4c36",
23-
Utf8GraphQLParser.Parse(@"query GetHeroName { hero { name } }"));
23+
Utf8GraphQLParser.Parse("query GetHeroName { hero { name } }"));
2424
}
2525

2626
public async ValueTask<IOperationDocument?> TryReadAsync(

src/HotChocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ await testServer.SendPostRequestAsync(
560560
await testServer.SendPostRequestAsync(
561561
new ClientQueryRequest
562562
{
563-
Query = @"mutation { complete(episode:NEW_HOPE) }"
563+
Query = "mutation { complete(episode:NEW_HOPE) }"
564564
});
565565

566566
// assert

src/HotChocolate/Core/src/Types/Utilities/ThrowHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ internal static class ThrowHelper
1414
{
1515
public static ArgumentException String_NullOrEmpty(string parameterName) =>
1616
new ArgumentException(
17-
$@"'{parameterName}' cannot be null or empty",
17+
$"'{parameterName}' cannot be null or empty",
1818
parameterName);
1919

2020
public static GraphQLException EventMessage_InvalidCast(

src/HotChocolate/Core/test/Types.Records.Tests/RecordsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public async Task Relay_Id_Middleware_Is_Correctly_Applied()
6060
{
6161
await ExpectValid
6262
(
63-
@"{ person { id name } }",
63+
"{ person { id name } }",
6464
b => b.AddQueryType<Query>().AddGlobalObjectIdentification(false)
6565
)
6666
.MatchSnapshotAsync();

src/HotChocolate/Core/test/Types.Tests/Types/ObjectTypeTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ public void SpecifyQueryTypeNameInSchemaFirstWithOptions()
517517
public void NoQueryType()
518518
{
519519
// arrange
520-
const string source = @"type A { field: String }";
520+
const string source = "type A { field: String }";
521521

522522
// act
523523
void Action()

src/HotChocolate/Fusion-vnext/src/Fusion.Packaging/SchemaNameValidator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ internal static partial class SchemaNameValidator
1212
// NameStart ::= Letter | `_`
1313
// NameContinue ::= Letter | Digit | `_` | `-`
1414

15-
[GeneratedRegex(@"^[A-Za-z_][A-Za-z0-9_-]*$")]
15+
[GeneratedRegex("^[A-Za-z_][A-Za-z0-9_-]*$")]
1616
private static partial Regex SchemaNameRegex();
1717

1818
/// <summary>

src/HotChocolate/Language/test/Language.Tests/Parser/GraphQLParserSyntaxTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,16 @@ public void Parse_ValueNode_From_Reader()
5757

5858
[Fact]
5959
public void Parse_ObjectValueNode_From_String() =>
60-
Utf8GraphQLParser.Syntax.ParseObjectLiteral(@"{ a: 1 }").MatchSnapshot();
60+
Utf8GraphQLParser.Syntax.ParseObjectLiteral("{ a: 1 }").MatchSnapshot();
6161

6262
[Fact]
6363
public void Parse_ObjectValueNode_From_ByteArray() =>
64-
Utf8GraphQLParser.Syntax.ParseObjectLiteral(GetUtf8Bytes(@"{ a: 1 }")).MatchSnapshot();
64+
Utf8GraphQLParser.Syntax.ParseObjectLiteral(GetUtf8Bytes("{ a: 1 }")).MatchSnapshot();
6565

6666
[Fact]
6767
public void Parse_ObjectValueNode_From_Reader()
6868
{
69-
var reader = new Utf8GraphQLReader(GetUtf8Bytes(@"{ a: 1 }"));
69+
var reader = new Utf8GraphQLReader(GetUtf8Bytes("{ a: 1 }"));
7070
reader.MoveNext();
7171

7272
Utf8GraphQLParser.Syntax.ParseObjectLiteral(reader).MatchSnapshot();

src/StrawberryShake/Client/test/Core.Tests/Json/JsonErrorParserTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public void Error_With_Message()
2121
public void Error_Has_No_Message()
2222
{
2323
// arrange
24-
var result = JsonDocument.Parse(@"[{ }]");
24+
var result = JsonDocument.Parse("[{ }]");
2525

2626
// act
2727
var errors = JsonErrorParser.ParseErrors(result.RootElement);

src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/OperationDocumentGenerator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected override void Generate(OperationDescriptor descriptor,
7878
.AddProperty("Hash")
7979
.SetType(TypeNames.DocumentHash)
8080
.SetValue(
81-
$@"new {TypeNames.DocumentHash}("
81+
$"new {TypeNames.DocumentHash}("
8282
+ $@"""{descriptor.HashAlgorithm}"", "
8383
+ $@"""{descriptor.HashValue}"")");
8484

0 commit comments

Comments
 (0)