Throw when trying to resolve unknown schema (#8771)

Author: tobias-tengler

src/HotChocolate/Core/src/Execution/RequestExecutorManager.cs

@@ -92,6 +92,11 @@ public async ValueTask<IRequestExecutor> GetExecutorAsync(
                 return re.Executor;
             }
 
+            if (!SchemaNames.Contains(schemaName))
+            {
+                throw new InvalidOperationException($"The requested schema '{schemaName}' does not exist.");
+            }
+
             var registeredExecutor = await CreateRequestExecutorAsync(schemaName, true, cancellationToken)
                 .ConfigureAwait(false);
 

src/HotChocolate/Core/test/Execution.Tests/RequestExecutorResolverTests.cs renamed to src/HotChocolate/Core/test/Execution.Tests/RequestExecutorManagerTests.cs

@@ -4,8 +4,28 @@
 
 namespace HotChocolate.Execution;
 
-public class RequestExecutorResolverTests
+public class RequestExecutorManagerTests
 {
+    [Fact]
+    public async Task GetExecutorAsync_Throws_If_Schema_Does_Not_Exist()
+    {
+        // arrange
+        var manager =
+            new ServiceCollection()
+                .AddGraphQL("some-name")
+                .AddQueryType(d => d.Field("foo").Resolve(""))
+                .Services
+                .BuildServiceProvider()
+                .GetRequiredService<RequestExecutorManager>();
+
+        // act
+        var act = async () => await manager.GetExecutorAsync("unknown-name");
+
+        // assert
+        var exception = await Assert.ThrowsAsync<InvalidOperationException>(act);
+        Assert.Equal($"The requested schema 'unknown-name' does not exist.", exception.Message);
+    }
+
     [Fact]
     public async Task Operation_Cache_Should_Be_Scoped_To_Executor()
     {

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/FusionRequestExecutorManager.cs

@@ -100,6 +100,11 @@ private async ValueTask<IRequestExecutor> GetOrCreateRequestExecutorAsync(
                 return registration.Executor;
             }
 
+            if (!SchemaNames.Contains(schemaName))
+            {
+                throw new InvalidOperationException($"The requested schema '{schemaName}' does not exist.");
+            }
+
             registration = await CreateInitialRegistrationAsync(schemaName, cancellationToken).ConfigureAwait(false);
             _registry.TryAdd(schemaName, registration);
             await _executorEvents.WriteCreatedAsync(registration.Executor, cancellationToken).ConfigureAwait(false);

src/HotChocolate/Fusion-vnext/test/Fusion.Execution.Tests/Execution/FusionRequestExecutorManagerTests.cs

@@ -12,6 +12,38 @@ namespace HotChocolate.Fusion.Execution;
 
 public class FusionRequestExecutorManagerTests : FusionTestBase
 {
+    [Fact]
+    public async Task GetExecutorAsync_Throws_If_Schema_Does_Not_Exist()
+    {
+        // arrange
+        var schemaDocument =
+            ComposeSchemaDocument(
+                """
+                schema {
+                    query: Query
+                }
+
+                type Query {
+                    foo: String
+                }
+                """);
+
+        var manager =
+            new ServiceCollection()
+                .AddGraphQLGateway("some-name")
+                .AddInMemoryConfiguration(schemaDocument)
+                .Services
+                .BuildServiceProvider()
+                .GetRequiredService<FusionRequestExecutorManager>();
+
+        // act
+        var act = async () => await manager.GetExecutorAsync("unknown-name");
+
+        // assert
+        var exception = await Assert.ThrowsAsync<InvalidOperationException>(act);
+        Assert.Equal($"The requested schema 'unknown-name' does not exist.", exception.Message);
+    }
+
     [Fact]
     public async Task CreateExecutor()
     {