Proper Invalidation handling

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/OperationPlanContext.cs

@@ -144,7 +144,7 @@ internal IOperationResult Complete()
 
         var result = resultBuilder
             .AddErrors(_resultStore.Errors)
-            .SetData(_resultStore.Data)
+            .SetData(_resultStore.Data.IsInvalidated ? null : _resultStore.Data)
             .RegisterForCleanup(_resultStore.MemoryOwners)
             .RegisterForCleanup(_resultPoolSessionHolder)
             .Build();

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Results/FetchResultStore.cs

@@ -130,26 +130,20 @@ public bool AddErrors(ReadOnlySpan<SourceSchemaError> errors, ReadOnlySpan<strin
 
             while (Unsafe.IsAddressLessThan(ref error, ref end))
             {
-                if (error.Path.IsRoot)
+                if (_root.IsInvalidated)
                 {
-                    if (!_valueCompletion.BuildResult(_root, responseNames, error))
-                    {
-                        // TODO: This is wrong
-                        _root = null!;
-                        return false;
-                    }
+                    return false;
                 }
-                else
+
+                var result = error.Path.IsRoot ? _root : GetStartObjectResult(error.Path);
+
+                if (result.IsInvalidated)
                 {
-                    var startResult = GetStartObjectResult(error.Path);
-                    if (!_valueCompletion.BuildResult(startResult, responseNames, error))
-                    {
-                        // TODO: This is wrong
-                        _root = null!;
-                        return false;
-                    }
+                    continue;
                 }
 
+                _valueCompletion.BuildResult(result, responseNames, error);
+
                 error = ref Unsafe.Add(ref error, 1)!;
             }
         }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Results/ResultData.cs

@@ -21,6 +21,8 @@ public abstract class ResultData : IResultDataJsonFormatter
     /// </summary>
     protected internal int ParentIndex { get; private set; }
 
+    public bool IsInvalidated { get; set; }
+
     /// <summary>
     /// Gets the path of the result.
     /// </summary>

src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Execution/Results/ValueCompletion.cs

@@ -80,32 +80,9 @@ public bool BuildResult(
 
                 if (!TryCompleteValue(selection, selection.Type, element, errorTrieForResponseName, 0, fieldResult))
                 {
-                    var parentIndex = fieldResult.ParentIndex;
-                    var parent = fieldResult.Parent;
-
                     if (_errorHandling is ErrorHandling.Propagate)
                     {
-                        while (parent is not null)
-                        {
-                            if (parent.TrySetValueNull(parentIndex))
-                            {
-                                break;
-                            }
-                            else
-                            {
-                                parentIndex = parent.ParentIndex;
-                                parent = parent.Parent;
-
-                                if (parent is null)
-                                {
-                                    return false;
-                                }
-                            }
-                        }
-                    }
-                    else
-                    {
-                        fieldResult?.TrySetValueNull(parentIndex);
+                        PropagateNullValues(objectResult);
                     }
                 }
             }
@@ -114,7 +91,7 @@ public bool BuildResult(
         return true;
     }
 
-    public bool BuildResult(
+    public void BuildResult(
         ObjectResult objectResult,
         ReadOnlySpan<string> responseNames,
         SourceSchemaError sourceSchemaError)
@@ -135,35 +112,43 @@ public bool BuildResult(
 
             _errors.Add(error);
 
-            if (_errorHandling is ErrorHandling.Propagate)
+            if (_errorHandling is ErrorHandling.Propagate && fieldResult.Selection.Type.IsNonNullType())
             {
-                // TODO: We need an invalidated state for the resultdata
-                if (!PropagateNullValues(fieldResult))
-                {
-                    return false;
-                }
+                PropagateNullValues(objectResult);
+
+                return;
             }
         }
-
-        return true;
     }
 
-    private static bool PropagateNullValues(ResultData result)
+    private static void PropagateNullValues(ResultData result)
     {
+        if (result.IsInvalidated)
+        {
+            return;
+        }
+
+        result.IsInvalidated = true;
+
         while (result.Parent is not null)
         {
             var index = result.ParentIndex;
             var parent = result.Parent;
 
+            if (parent.IsInvalidated)
+            {
+                return;
+            }
+
             if (parent.TrySetValueNull(index))
             {
-                return true;
+                return;
             }
 
+            parent.IsInvalidated = true;
+
             result = parent;
         }
-
-        return false;
     }
 
     private bool TryCompleteValue(