Skip to content

Commit 9ae7220

Browse files
authored
[Fusion] Removed temporary comments from TypeDefinitionExtensions (#8534)
1 parent 6ce7e84 commit 9ae7220

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Extensions/TypeDefinitionExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
using HotChocolate.Types;
22
using HotChocolate.Types.Mutable;
3+
using static HotChocolate.Fusion.Properties.CompositionResources;
34
using static HotChocolate.Fusion.WellKnownArgumentNames;
45
using static HotChocolate.Fusion.WellKnownDirectiveNames;
56

67
namespace HotChocolate.Fusion.Extensions;
78

89
internal static class TypeDefinitionExtensions
910
{
10-
// todo put all of this data in the execution schema.
1111
public static IEnumerable<MutableObjectTypeDefinition> GetPossibleTypes(
1212
this ITypeDefinition type,
1313
string schemaName,
@@ -16,7 +16,7 @@ public static IEnumerable<MutableObjectTypeDefinition> GetPossibleTypes(
1616
if (type.Kind is not TypeKind.Object and not TypeKind.Interface and not TypeKind.Union)
1717
{
1818
throw new ArgumentException(
19-
"The specified type is not an abstract type.", // tmp not very accurate message + loc
19+
TypeDefinitionExtensions_TheSpecifiedTypeIsNotAnAbstractType,
2020
nameof(type));
2121
}
2222

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,9 @@
414414
<data name="ShareableMutableDirectiveDefinition_Description" xml:space="preserve">
415415
<value>The @shareable directive allows multiple source schemas to define the same field, ensuring that this decision is both intentional and coordinated by requiring fields to be explicitly marked.</value>
416416
</data>
417+
<data name="TypeDefinitionExtensions_TheSpecifiedTypeIsNotAnAbstractType" xml:space="preserve">
418+
<value>The specified type is not an abstract type.</value>
419+
</data>
417420
<data name="TypeDefinitionInvalidRule_ArgumentMissing" xml:space="preserve">
418421
<value>The argument '{0}' is missing.</value>
419422
</data>

0 commit comments

Comments
 (0)