No bad kitty. No recursive!

Author: tobias-tengler

src/HotChocolate/Core/src/Validation/Rules/FieldVisitor.cs

@@ -384,47 +384,53 @@ private static bool AreArgumentsIdentical(FieldNode fieldA, FieldNode fieldB)
     }
 
     private static bool IsValueIdentical(
-        IValueNode? valueA,
-        IValueNode? valueB)
+        IValueNode valueA,
+        IValueNode valueB)
     {
-        if (valueA is null && valueB is null)
-        {
-            return true;
-        }
-
-        if (valueA is null || valueB is null)
-        {
-            return false;
-        }
+        var stack = new Stack<(IValueNode ValueA, IValueNode ValueB)>();
+        stack.Push((valueA, valueB));
 
-        if (valueA is ObjectValueNode objectA && valueB is ObjectValueNode objectB)
+        while (stack.Count > 0)
         {
-            var validPairs = 0;
+            var (currentA, currentB) = stack.Pop();
 
-            for (var i = 0; i < objectA.Fields.Count; i++)
+            if (currentA is ObjectValueNode objectA && currentB is ObjectValueNode objectB)
             {
-                var fieldA = objectA.Fields[i];
+                if (objectA.Fields.Count != objectB.Fields.Count)
+                {
+                    return false;
+                }
 
-                for (var j = 0; j < objectB.Fields.Count; j++)
+                for (var i = 0; i < objectA.Fields.Count; i++)
                 {
-                    var fieldB = objectB.Fields[j];
+                    var fieldA = objectA.Fields[i];
+                    var matchFound = false;
 
-                    if (BySyntax.Equals(fieldA.Name, fieldB.Name))
+                    for (var j = 0; j < objectB.Fields.Count; j++)
                     {
-                        if (IsValueIdentical(fieldA.Value, fieldB.Value))
+                        var fieldB = objectB.Fields[j];
+
+                        if (BySyntax.Equals(fieldA.Name, fieldB.Name))
                         {
-                            validPairs++;
+                            stack.Push((fieldA.Value, fieldB.Value));
+                            matchFound = true;
+                            break;
                         }
+                    }
 
-                        break;
+                    if (!matchFound)
+                    {
+                        return false;
                     }
                 }
             }
-
-            return objectA.Fields.Count == validPairs;
+            else if (!BySyntax.Equals(currentA, currentB))
+            {
+                return false;
+            }
         }
 
-        return BySyntax.Equals(valueA, valueB);
+        return true;
     }
 
     private static bool SameResponseShape(IType typeA, IType typeB)