Updated configuration for IDE0040 (#8782)

glen-84 · web-flow · commit a805ec05c853 · 2025-10-08T16:17:59.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -99,8 +99,6 @@ csharp_space_between_parentheses = false
 csharp_preserve_single_line_statements = false
 csharp_preserve_single_line_blocks = true
 
-dotnet_style_require_accessibility_modifiers = always
-
 # Public API
 dotnet_diagnostic.rs0016.severity = warning
 dotnet_diagnostic.rcs1194.severity = none
@@ -203,6 +201,9 @@ dotnet_diagnostic.IDE0028.severity = warning
 dotnet_diagnostic.IDE0036.severity = warning
 # Use inferred member names.
 dotnet_diagnostic.IDE0037.severity = warning
+# Add accessibility modifiers.
+dotnet_diagnostic.IDE0040.severity = warning
+dotnet_style_require_accessibility_modifiers = for_non_interface_members
 # Add readonly modifier.
 dotnet_diagnostic.IDE0044.severity = warning
 dotnet_diagnostic.RCS1169.severity = none
diff --git a/src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/EntitiesResolverForInterfaceTests.cs b/src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/EntitiesResolverForInterfaceTests.cs
@@ -309,7 +309,7 @@ public interface ITypeWithReferenceResolver
         string Id { get; set; }
         string SomeField { get; set; }
 
-        public static ITypeWithReferenceResolver Get([LocalState] ObjectValueNode data)
+        static ITypeWithReferenceResolver Get([LocalState] ObjectValueNode data)
         {
             return new TypeWithReferenceResolver { Id = "1", SomeField = "SomeField" };
         }
@@ -330,15 +330,15 @@ public static TypeWithReferenceResolver Get([LocalState] ObjectValueNode data)
     public interface IForeignType
     {
         [Key]
-        public string Id { get; }
+        string Id { get; }
 
         [External]
-        public string SomeExternalField { get; }
+        string SomeExternalField { get; }
 
-        public string InternalField => "InternalValue";
+        string InternalField => "InternalValue";
 
         [ReferenceResolver]
-        public static IForeignType GetById(string id, string someExternalField)
+        static IForeignType GetById(string id, string someExternalField)
             => new ForeignType(id, someExternalField);
     }
 
@@ -366,15 +366,15 @@ public static ForeignType GetById(string id, string someExternalField)
     public interface IMixedFieldTypes
     {
         [Key]
-        public string Id { get; }
+        string Id { get; }
 
         [External]
-        public int IntField { get; }
+        int IntField { get; }
 
-        public string InternalField { get; set; }
+        string InternalField { get; set; }
 
         [ReferenceResolver]
-        public static IMixedFieldTypes GetByExternal(string id, int intField)
+        static IMixedFieldTypes GetByExternal(string id, int intField)
             => new MixedFieldTypes(id, intField);
     }
 
@@ -407,7 +407,7 @@ public interface IFederatedType
         string SomeField { get; set; }
 
         [ReferenceResolver]
-        public static async Task<IFederatedType?> GetById(
+        static async Task<IFederatedType?> GetById(
             [LocalState] ObjectValueNode data,
             [Service] IFederatedTypeDataLoader loader)
         {
@@ -473,7 +473,7 @@ public interface IFederatedTypeWithRequiredDetail
         FederatedTypeDetail Detail { get; set; }
 
         [ReferenceResolver]
-        public static IFederatedTypeWithRequiredDetail ReferenceResolver([Map("detail.id")] string detailId)
+        static IFederatedTypeWithRequiredDetail ReferenceResolver([Map("detail.id")] string detailId)
             => new FederatedTypeWithRequiredDetail()
             {
                 Id = detailId,
@@ -509,7 +509,7 @@ public interface IFederatedTypeWithOptionalDetail
         FederatedTypeDetail? Detail { get; }
 
         [ReferenceResolver]
-        public static IFederatedTypeWithOptionalDetail ReferenceResolver([Map("detail.id")] string detailId)
+        static IFederatedTypeWithOptionalDetail ReferenceResolver([Map("detail.id")] string detailId)
             => new FederatedTypeWithOptionalDetail()
             {
                 Id = detailId,
diff --git a/src/HotChocolate/Caching/test/Caching.Tests/CacheControlDirectiveTypeTests.cs b/src/HotChocolate/Caching/test/Caching.Tests/CacheControlDirectiveTypeTests.cs
@@ -428,7 +428,7 @@ public class ObjectQuery
     public interface IInterfaceType
     {
         [CacheControl(500, Scope = CacheControlScope.Private, InheritMaxAge = true)]
-        public string? Field { get; set; }
+        string? Field { get; set; }
     }
 
     public class InterfaceObjectType : IInterfaceType
diff --git a/src/HotChocolate/Core/src/Execution.Abstractions/Execution/IRequestExecutorProvider.cs b/src/HotChocolate/Core/src/Execution.Abstractions/Execution/IRequestExecutorProvider.cs
@@ -24,7 +24,7 @@ public interface IRequestExecutorProvider
     /// <returns>
     /// Returns a GraphQL request executor.
     /// </returns>
-    public ValueTask<IRequestExecutor> GetExecutorAsync(
+    ValueTask<IRequestExecutor> GetExecutorAsync(
         string? schemaName = null,
         CancellationToken cancellationToken = default);
 }
diff --git a/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/IRabbitMQConncetion.cs b/src/HotChocolate/Core/src/Subscriptions.RabbitMQ/IRabbitMQConncetion.cs
@@ -4,5 +4,5 @@ namespace HotChocolate.Subscriptions.RabbitMQ;
 
 internal interface IRabbitMQConnection
 {
-    public Task<IModel> GetChannelAsync();
+    Task<IModel> GetChannelAsync();
 }
diff --git a/src/HotChocolate/Core/src/Subscriptions/ITopic.cs b/src/HotChocolate/Core/src/Subscriptions/ITopic.cs
@@ -8,7 +8,7 @@ public interface ITopic : IDisposable
     /// <summary>
     /// Gets the message type of this topic.
     /// </summary>
-    public Type MessageType { get; }
+    Type MessageType { get; }
 
     /// <summary>
     /// Allows completing a topic.
diff --git a/src/HotChocolate/Core/src/Types.Abstractions/IRootServiceProviderAccessor.cs b/src/HotChocolate/Core/src/Types.Abstractions/IRootServiceProviderAccessor.cs
@@ -9,5 +9,5 @@ public interface IRootServiceProviderAccessor
     /// <summary>
     /// Gets the root service provider.
     /// </summary>
-    public IServiceProvider ServiceProvider { get; }
+    IServiceProvider ServiceProvider { get; }
 }
diff --git a/src/HotChocolate/Core/src/Types.Abstractions/ISchemaDefinition.cs b/src/HotChocolate/Core/src/Types.Abstractions/ISchemaDefinition.cs
@@ -104,5 +104,5 @@ bool TryGetOperationType(
     /// <summary>
     /// The default name of a schema.
     /// </summary>
-    public static string DefaultName => "_Default";
+    static string DefaultName => "_Default";
 }
diff --git a/src/HotChocolate/Core/src/Types/Execution/Processing/IFragment.cs b/src/HotChocolate/Core/src/Types/Execution/Processing/IFragment.cs
@@ -11,7 +11,7 @@ public interface IFragment : IOptionalSelection
     /// <summary>
     /// Gets the internal fragment identifier.
     /// </summary>
-    public int Id { get; }
+    int Id { get; }
 
     /// <summary>
     /// Gets the type condition.
diff --git a/src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs b/src/HotChocolate/Core/src/Types/IReadOnlySchemaOptions.cs
@@ -178,12 +178,12 @@ public interface IReadOnlySchemaOptions
     /// <summary>
     /// Specifies the default dependency injection scope for query fields.
     /// </summary>
-    public DependencyInjectionScope DefaultQueryDependencyInjectionScope { get; }
+    DependencyInjectionScope DefaultQueryDependencyInjectionScope { get; }
 
     /// <summary>
     /// Specifies the default dependency injection scope for mutation fields.
     /// </summary>
-    public DependencyInjectionScope DefaultMutationDependencyInjectionScope { get; }
+    DependencyInjectionScope DefaultMutationDependencyInjectionScope { get; }
 
     /// <summary>
     /// Specifies if the elements of paginated root fields should be published
diff --git a/src/HotChocolate/Core/src/Types/Internal/IParameterBinding.cs b/src/HotChocolate/Core/src/Types/Internal/IParameterBinding.cs
@@ -21,7 +21,7 @@ public interface IParameterBindingFactory : IParameterHandler
 
 public interface IParameterBindingResolver
 {
-    public IParameterBinding GetBinding(ParameterInfo parameter);
+    IParameterBinding GetBinding(ParameterInfo parameter);
 }
 
 public readonly ref struct ParameterBindingContext(ParameterInfo parameter, string argumentName)
diff --git a/src/HotChocolate/Core/src/Types/Internal/ITypeAttribute.cs b/src/HotChocolate/Core/src/Types/Internal/ITypeAttribute.cs
@@ -11,15 +11,15 @@ public interface ITypeAttribute
     /// <summary>
     /// Defines if this attribute is inherited. The default is <c>false</c>.
     /// </summary>
-    public bool Inherited { get; set; }
+    bool Inherited { get; set; }
 
     /// <summary>
     /// Gets the kind of type represented by this attribute.
     /// </summary>
-    public TypeKind Kind { get; }
+    TypeKind Kind { get; }
 
     /// <summary>
     /// Defines if this attribute represents a type extension.
     /// </summary>
-    public bool IsTypeExtension { get; }
+    bool IsTypeExtension { get; }
 }
diff --git a/src/HotChocolate/Core/src/Types/Types/Descriptors/Configurations/IRepeatableConfiguration.cs b/src/HotChocolate/Core/src/Types/Types/Descriptors/Configurations/IRepeatableConfiguration.cs
@@ -9,10 +9,10 @@ public interface IRepeatableConfiguration
     /// Defines if the middleware or result converters is repeatable and
     /// the same middleware is allowed to be occur multiple times.
     /// </summary>
-    public bool IsRepeatable { get; }
+    bool IsRepeatable { get; }
 
     /// <summary>
     /// The key is optional and is used to identify a middleware.
     /// </summary>
-    public string? Key { get; }
+    string? Key { get; }
 }
diff --git a/src/HotChocolate/Core/src/Types/Types/Pagination/IPage.cs b/src/HotChocolate/Core/src/Types/Types/Pagination/IPage.cs
@@ -21,5 +21,5 @@ public interface IPage
     /// <param name="observer">
     /// The page observer.
     /// </param>
-    public void Accept(IPageObserver observer);
+    void Accept(IPageObserver observer);
 }
diff --git a/src/HotChocolate/Core/src/Types/Types/Pagination/IPageTotalCountProvider.cs b/src/HotChocolate/Core/src/Types/Types/Pagination/IPageTotalCountProvider.cs
@@ -2,5 +2,5 @@ namespace HotChocolate.Types.Pagination;
 
 public interface IPageTotalCountProvider
 {
-    public int TotalCount { get; }
+    int TotalCount { get; }
 }
diff --git a/src/HotChocolate/Core/test/Types.CursorPagination.Tests/IntegrationTests.cs b/src/HotChocolate/Core/test/Types.CursorPagination.Tests/IntegrationTests.cs
@@ -1224,13 +1224,13 @@ public List<List<Foo>> Foos() =>
 
     public interface ISome
     {
-        public string[] ExplicitType();
+        string[] ExplicitType();
     }
 
     public interface ISome2
     {
         [UsePaging(typeof(NonNullType<StringType>))]
-        public string[] ExplicitType();
+        string[] ExplicitType();
     }
 
     public class InferConnectionNameFromFieldType : ObjectType<InferConnectionNameFromField>
diff --git a/src/HotChocolate/Core/test/Types.Mutations.Tests/AnnotationBasedMutations.cs b/src/HotChocolate/Core/test/Types.Mutations.Tests/AnnotationBasedMutations.cs
@@ -1854,12 +1854,12 @@ public class ErrorAnnotatedAndNot : IErrorInterface, IInterfaceError2
 
     public interface IInterfaceError
     {
-        public string Name { get; }
+        string Name { get; }
     }
 
     public interface IInterfaceError2
     {
-        public string Name { get; }
+        string Name { get; }
     }
 
     public class ErrorWithInterface : IInterfaceError, IInterfaceError2
@@ -1871,7 +1871,7 @@ public class ErrorWithInterface : IInterfaceError, IInterfaceError2
 
     public interface IErrorInterface
     {
-        public string Message { get; }
+        string Message { get; }
     }
 
     public class MutationWithVoidResult
diff --git a/src/HotChocolate/Core/test/Types.NodaTime.Tests/InstantTypeDateTimeOffsetIntegrationTests.cs b/src/HotChocolate/Core/test/Types.NodaTime.Tests/InstantTypeDateTimeOffsetIntegrationTests.cs
@@ -9,7 +9,7 @@ namespace HotChocolate.Types.NodaTime.Tests;
 
 public class InstantTypeDateTimeOffsetIntegrationTests
 {
-    class InstantDateTimeOffsetPattern : IPattern<Instant>
+    private class InstantDateTimeOffsetPattern : IPattern<Instant>
     {
         public ParseResult<Instant> Parse(string text)
         {
diff --git a/src/HotChocolate/Core/test/Types.OffsetPagination.Tests/IntegrationTests.cs b/src/HotChocolate/Core/test/Types.OffsetPagination.Tests/IntegrationTests.cs
@@ -780,13 +780,13 @@ public List<List<Foo>> Foos() =>
 
     public interface ISome
     {
-        public string[] ExplicitType();
+        string[] ExplicitType();
     }
 
     public interface ISome2
     {
         [UseOffsetPaging(typeof(NonNullType<StringType>))]
-        public string[] ExplicitType();
+        string[] ExplicitType();
     }
 
     public class QueryEnumerableValueType
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/InputObjectTypeTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/InputObjectTypeTests.cs
@@ -794,7 +794,7 @@ public class InputWithInterface
 
     public interface IDoesNotWork
     {
-        public double? Member { get; set; }
+        double? Member { get; set; }
     }
 
     public class SimpleInput
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/Relay/IdAttributeTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/Relay/IdAttributeTests.cs
@@ -618,7 +618,7 @@ public interface IFooPayload
     {
         [ID] string SomeId { get; }
 
-        [ID] public string? SomeNullableId { get; }
+        [ID] string? SomeNullableId { get; }
 
         [ID] IReadOnlyList<int> SomeIds { get; }
 
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeFieldSupportTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeFieldSupportTests.cs
@@ -469,7 +469,7 @@ public class Bar9
 
     public interface IBar9Resolver
     {
-        public Bar9 GetBar9(string id);
+        Bar9 GetBar9(string id);
     }
 
     public class Bar9Resolver : IBar9Resolver
diff --git a/src/HotChocolate/Data/src/Data/Sorting/ISortFieldConfiguration.cs b/src/HotChocolate/Data/src/Data/Sorting/ISortFieldConfiguration.cs
@@ -11,9 +11,9 @@ public interface ISortFieldConfiguration
     , IIgnoreConfiguration
     , IHasScope
 {
-    public MemberInfo? Member { get; }
+    MemberInfo? Member { get; }
 
-    public ISortFieldHandler? Handler { get; }
+    ISortFieldHandler? Handler { get; }
 
-    public Expression? Expression { get; }
+    Expression? Expression { get; }
 }
diff --git a/src/HotChocolate/Data/src/Data/Sorting/Visitor/ISortVisitorContext~1.cs b/src/HotChocolate/Data/src/Data/Sorting/Visitor/ISortVisitorContext~1.cs
@@ -6,10 +6,10 @@ public interface ISortVisitorContext<T>
     ///<summary>
     /// Stores all sort operations
     ///</summary>
-    public Queue<T> Operations { get; }
+    Queue<T> Operations { get; }
 
     ///<summary>
     /// Stores the current instance. In case of an expression this would be x.Foo.Bar
     ///</summary>
-    public Stack<T> Instance { get; }
+    Stack<T> Instance { get; }
 }
diff --git a/src/HotChocolate/Data/test/Data.Filters.Tests/Expression/QueryableFilterVisitorObjectTests.cs b/src/HotChocolate/Data/test/Data.Filters.Tests/Expression/QueryableFilterVisitorObjectTests.cs
@@ -503,9 +503,9 @@ public class FooNullable
 
     public interface ITest
     {
-        public string? Prop { get; set; }
+        string? Prop { get; set; }
 
-        public string? Prop2 { get; set; }
+        string? Prop2 { get; set; }
     }
 
     public class InterfaceImpl1 : ITest
diff --git a/src/HotChocolate/Data/test/Data.Filters.Tests/FilterInputTypeTest.cs b/src/HotChocolate/Data/test/Data.Filters.Tests/FilterInputTypeTest.cs
@@ -542,9 +542,9 @@ public class User
 
     public interface ITest
     {
-        public string? Prop { get; set; }
+        string? Prop { get; set; }
 
-        public string? Prop2 { get; set; }
+        string? Prop2 { get; set; }
     }
 
     public interface ITest<T>
diff --git a/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/QueryableSortVisitorObjectTests.cs b/src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/QueryableSortVisitorObjectTests.cs
@@ -614,7 +614,7 @@ public enum BarEnum
         QUX
     }
 
-    class ComplexOrderSumHandler(ISortConvention convention, InputParser inputParser)
+    public class ComplexOrderSumHandler(ISortConvention convention, InputParser inputParser)
         : SortFieldHandler<QueryableSortContext, QueryableSortOperation>
     {
         private readonly Dictionary<string, PropertyInfo> _fieldMap = typeof(Foo)
@@ -674,7 +674,7 @@ public override bool TryHandleLeave(
         }
     }
 
-    class ComplexOrderSumFieldsHandler
+    public class ComplexOrderSumFieldsHandler
         : SortFieldHandler<QueryableSortContext, QueryableSortOperation>
     {
         public override bool CanHandle(
@@ -686,7 +686,7 @@ public override bool CanHandle(
         }
     }
 
-    class ComplexOrderSumSortHandler
+    public class ComplexOrderSumSortHandler
         : SortFieldHandler<QueryableSortContext, QueryableSortOperation>
     {
         public override bool CanHandle(
@@ -708,6 +708,6 @@ public override bool TryHandleEnter(
         }
     }
 
-    class MockProviderExtension(Action<ISortProviderDescriptor<QueryableSortContext>> configure)
+    public class MockProviderExtension(Action<ISortProviderDescriptor<QueryableSortContext>> configure)
         : SortProviderExtensions<QueryableSortContext>(configure);
 }
diff --git a/src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs b/src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs
diff --git a/src/Nitro/CommandLine/src/CommandLine.Cloud/Extensions/ApiClientCommandLineBuilderExtensions.cs b/src/Nitro/CommandLine/src/CommandLine.Cloud/Extensions/ApiClientCommandLineBuilderExtensions.cs
diff --git a/src/Nitro/CommandLine/src/CommandLine.Cloud/Services/Configuration/Configuration.cs b/src/Nitro/CommandLine/src/CommandLine.Cloud/Services/Configuration/Configuration.cs
diff --git a/src/Nitro/CommandLine/src/CommandLine.Core/Result/IExtendedConsole.cs b/src/Nitro/CommandLine/src/CommandLine.Core/Result/IExtendedConsole.cs
diff --git a/src/StrawberryShake/Client/src/Core/IClientBuilder.cs b/src/StrawberryShake/Client/src/Core/IClientBuilder.cs
diff --git a/src/StrawberryShake/Client/src/Core/IEntityUpdateSession.cs b/src/StrawberryShake/Client/src/Core/IEntityUpdateSession.cs
diff --git a/src/StrawberryShake/Client/src/Core/IStoredOperation.cs b/src/StrawberryShake/Client/src/Core/IStoredOperation.cs
diff --git a/src/StrawberryShake/Client/src/Transport.WebSockets/ISocketConnectionInterceptor.cs b/src/StrawberryShake/Client/src/Transport.WebSockets/ISocketConnectionInterceptor.cs
diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/ICodeContainer.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/ICodeContainer.cs
diff --git a/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Descriptors/TypeDescriptors/ITypeDescriptor.cs b/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Descriptors/TypeDescriptors/ITypeDescriptor.cs

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,7 @@ public class ObjectQuery`
`428`	`428`	`public interface IInterfaceType`
`429`	`429`	`{`
`430`	`430`	`[CacheControl(500, Scope = CacheControlScope.Private, InheritMaxAge = true)]`
`431`		`- public string? Field { get; set; }`
	`431`	`+ string? Field { get; set; }`
`432`	`432`	`}`
`433`	`433`
`434`	`434`	`public class InterfaceObjectType : IInterfaceType`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public interface IRequestExecutorProvider`
`24`	`24`	`/// <returns>`
`25`	`25`	`/// Returns a GraphQL request executor.`
`26`	`26`	`/// </returns>`
`27`		`- public ValueTask<IRequestExecutor> GetExecutorAsync(`
	`27`	`+ ValueTask<IRequestExecutor> GetExecutorAsync(`
`28`	`28`	`string? schemaName = null,`
`29`	`29`	`CancellationToken cancellationToken = default);`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ namespace HotChocolate.Subscriptions.RabbitMQ;`
`4`	`4`
`5`	`5`	`internal interface IRabbitMQConnection`
`6`	`6`	`{`
`7`		`- public Task<IModel> GetChannelAsync();`
	`7`	`+ Task<IModel> GetChannelAsync();`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,5 +9,5 @@ public interface IRootServiceProviderAccessor`
`9`	`9`	`/// <summary>`
`10`	`10`	`/// Gets the root service provider.`
`11`	`11`	`/// </summary>`
`12`		`- public IServiceProvider ServiceProvider { get; }`
	`12`	`+ IServiceProvider ServiceProvider { get; }`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,5 +104,5 @@ bool TryGetOperationType(`
`104`	`104`	`/// <summary>`
`105`	`105`	`/// The default name of a schema.`
`106`	`106`	`/// </summary>`
`107`		`- public static string DefaultName => "_Default";`
	`107`	`+ static string DefaultName => "_Default";`
`108`	`108`	`}`