Removed unnecessary lambda expressions (#8402)

glen-84 · web-flow · commit ad587ac16393 · 2025-06-26T18:20:42.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -218,6 +218,8 @@ dotnet_diagnostic.IDE0079.severity = warning
 dotnet_remove_unnecessary_suppression_exclusions = CA1822, InconsistentNaming, RCS1102, xUnit1044
 # Use pattern matching (not operator).
 dotnet_diagnostic.IDE0083.severity = warning
+# Remove unnecessary lambda expression.
+dotnet_diagnostic.IDE0200.severity = warning
 # Use collection expression for array.
 dotnet_diagnostic.IDE0300.severity = warning
 # Use collection expression for empty.
diff --git a/src/HotChocolate/Core/src/Execution/Processing/Tasks/StreamHelper.cs b/src/HotChocolate/Core/src/Execution/Processing/Tasks/StreamHelper.cs
@@ -22,7 +22,7 @@ internal static class StreamHelper
     public static IAsyncEnumerable<object?> CreateStream(object result)
     {
         var resultType = result.GetType();
-        var factory = s_streamFactories.GetOrAdd(resultType, t => CreateFactory(t));
+        var factory = s_streamFactories.GetOrAdd(resultType, CreateFactory);
         return factory.Invoke(result);
     }
 
diff --git a/src/HotChocolate/Core/src/Subscriptions.Postgres/PostgresChannel.cs b/src/HotChocolate/Core/src/Subscriptions.Postgres/PostgresChannel.cs
@@ -78,9 +78,7 @@ private async ValueTask OnConnect(CancellationToken cancellationToken = default)
         _subscription = new ChannelSubscription(_channelName, connection, OnNotification);
         await _subscription.ConnectAsync(cancellationToken);
 
-        _waitOnNotificationTask = new ContinuousTask(
-            ct => connection.WaitAsync(ct),
-            TimeProvider.System);
+        _waitOnNotificationTask = new ContinuousTask(connection.WaitAsync, TimeProvider.System);
 
         _diagnosticEvents.ProviderInfo(PostgresChannel_ConnectionEstablished);
     }
diff --git a/src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs b/src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs
@@ -219,7 +219,7 @@ private void CompleteNames()
     {
         _interceptor.OnBeforeCompleteTypeNames();
 
-        if (ProcessTypes(Named, type => CompleteTypeName(type)))
+        if (ProcessTypes(Named, CompleteTypeName))
         {
             _interceptor.OnTypesCompletedName();
         }
@@ -575,7 +575,7 @@ private void CompleteTypes()
     {
         _interceptor.OnBeforeCompleteTypes();
 
-        if (ProcessTypes(Completed, type => CompleteType(type)))
+        if (ProcessTypes(Completed, CompleteType))
         {
             _interceptor.OnTypesCompleted();
         }
diff --git a/src/HotChocolate/Core/src/Types/Utilities/DefaultTypeConverter.Setup.cs b/src/HotChocolate/Core/src/Types/Utilities/DefaultTypeConverter.Setup.cs
diff --git a/src/HotChocolate/Core/test/Features.Tests/FeatureCollectionExtensionsTests.cs b/src/HotChocolate/Core/test/Features.Tests/FeatureCollectionExtensionsTests.cs
@@ -29,6 +29,6 @@ public void ExceptionThrown_WhenAskedForUnknownFeature()
         features.Set<IThing>(thing);
 
         // Assert
-        Assert.Throws<InvalidOperationException>(() => features.GetRequired<object>());
+        Assert.Throws<InvalidOperationException>(features.GetRequired<object>);
     }
 }
diff --git a/src/HotChocolate/Core/test/StarWars/Resolvers/SharedResolvers.cs b/src/HotChocolate/Core/test/StarWars/Resolvers/SharedResolvers.cs
@@ -28,7 +28,7 @@ public IEnumerable<ICharacter> GetCharacter(
             return null;
         }
         return character.Friends
-            .Select(t => repository.GetCharacter(t))
+            .Select(repository.GetCharacter)
             .OfType<Human>()
             .FirstOrDefault();
     }
diff --git a/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/AsyncAutoResetEventTests.cs b/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/AsyncAutoResetEventTests.cs
@@ -25,7 +25,7 @@ public void Set_Should_Throw_When_Disposed()
         autoResetEvent.Dispose();
 
         // Act & Assert
-        Assert.Throws<ObjectDisposedException>(() => autoResetEvent.Set());
+        Assert.Throws<ObjectDisposedException>(autoResetEvent.Set);
     }
 
     [Fact]
diff --git a/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/AsyncTaskDispatcherTests.cs b/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/AsyncTaskDispatcherTests.cs
@@ -38,7 +38,7 @@ public async Task Dispatch_Should_Throw_When_CalledAfterDispose()
         await asyncEventHandler.DisposeAsync();
 
         // Assert
-        Assert.Throws<ObjectDisposedException>(() => asyncEventHandler.Dispatch());
+        Assert.Throws<ObjectDisposedException>(asyncEventHandler.Dispatch);
     }
 
     [Fact]
diff --git a/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/PostgresChannelTests.cs b/src/HotChocolate/Core/test/Subscriptions.Postgres.Tests/PostgresChannelTests.cs
@@ -38,7 +38,7 @@ public async Task Subscribe_Should_ReceiveMessage_When_MessageIsSent()
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new List<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
 
         // Act
         channel.Subscribe(listener);
@@ -83,7 +83,7 @@ public async Task Subscribe_Should_ReceiveManySequential_Messages()
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new ConcurrentBag<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
 
         // Act
         channel.Subscribe(listener);
@@ -113,7 +113,7 @@ public async Task Subscribe_Should_ReceiveManyConcurrentMessages_From_ManyConnec
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new ConcurrentBag<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
 
         // Act
         channel.Subscribe(listener);
@@ -145,7 +145,7 @@ public async Task Subscribe_Should_ReceiveManyConcurrentMessages_From_SinlgeConn
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new ConcurrentBag<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
 
         // Act
         channel.Subscribe(listener);
@@ -177,7 +177,7 @@ public async Task SendAsync_Should_SendAndReceive()
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new ConcurrentBag<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
         channel.Subscribe(listener);
 
         // Act
@@ -201,7 +201,7 @@ public async Task SendAsync_Should_SendAllMessages_When_CalledConcurrently()
         await channel.EnsureInitialized(CancellationToken.None);
 
         var receivedMessages = new ConcurrentBag<string>();
-        var listener = new PostgresChannelObserver(topicName, e => receivedMessages.Add(e));
+        var listener = new PostgresChannelObserver(topicName, receivedMessages.Add);
         channel.Subscribe(listener);
 
         // Act
@@ -235,7 +235,7 @@ public async Task Subscribe_Should_AllowForManySubscribers()
 
         for (var i = 0; i < 100; i++)
         {
-            channel.Subscribe(new PostgresChannelObserver(topicName, e => receivedMessages.Add(e)));
+            channel.Subscribe(new PostgresChannelObserver(topicName, receivedMessages.Add));
         }
 
         // Act
@@ -259,7 +259,7 @@ public async Task Usubscribe_Should_StopListeningToMessages()
 
         var receivedMessages = new ConcurrentBag<string>();
         var disposable =
-            channel.Subscribe(new PostgresChannelObserver(topicName, e => receivedMessages.Add(e)));
+            channel.Subscribe(new PostgresChannelObserver(topicName, receivedMessages.Add));
 
         using var testChannel = new TestChannel(SyncConnectionFactory, _channelName);
         await testChannel.SendMessageAsync("aaaaaaaaaaaaaaaaaaaaaaaa:dGVzdA==:foobar");
@@ -303,7 +303,7 @@ public async Task Observable_Should_StayIntact_When_ReconnectAfterConnectionDrop
         using var testChannel = new TestChannel(SyncConnectionFactory, _channelName);
 
         var receivedMessages = new ConcurrentBag<string>();
-        channel.Subscribe(new PostgresChannelObserver(topicName, e => receivedMessages.Add(e)));
+        channel.Subscribe(new PostgresChannelObserver(topicName, receivedMessages.Add));
 
         // Act
         SpinWait.SpinUntil(() => connection is not null, TimeSpan.FromSeconds(1));
@@ -362,7 +362,7 @@ public async Task Observable_Should_StayIntact_When_ReconnectAfterConnectionDrop
         using var testChannel = new TestChannel(SyncConnectionFactory, _channelName);
 
         var receivedMessages = new ConcurrentBag<string>();
-        channel.Subscribe(new PostgresChannelObserver(topicName, e => receivedMessages.Add(e)));
+        channel.Subscribe(new PostgresChannelObserver(topicName, receivedMessages.Add));
 
         // Act
         SpinWait.SpinUntil(() => connection is not null, TimeSpan.FromSeconds(1));
diff --git a/src/HotChocolate/Core/test/Types.Tests/SchemaErrorTests.cs b/src/HotChocolate/Core/test/Types.Tests/SchemaErrorTests.cs
@@ -159,7 +159,7 @@ public void IncorrectType_In_Parameters_ShouldThrow()
             .Use(_ => _ => default);
 
         // act
-        var ex = Assert.Throws<SchemaException>(() => schema.Create());
+        var ex = Assert.Throws<SchemaException>(schema.Create);
 
         // assert
         Assert.Equal(2, ex.Errors.Count);
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/Descriptors/Conventions/DefaultTypeInspectorTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/Descriptors/Conventions/DefaultTypeInspectorTests.cs
@@ -585,7 +585,7 @@ public void CollectNullability_Nullable_StringType()
         var nullability = typeInspector.CollectNullability(extendedType);
 
         // assert
-        Assert.Collection(nullability, item => Assert.True(item));
+        Assert.Collection(nullability, Assert.True);
     }
 
     [Fact]
@@ -599,7 +599,7 @@ public void CollectNullability_NonNull_StringType()
         var nullability = typeInspector.CollectNullability(extendedType);
 
         // assert
-        Assert.Collection(nullability, item => Assert.False(item));
+        Assert.Collection(nullability, Assert.False);
     }
 
     [Fact]
diff --git a/src/HotChocolate/Core/test/Types.Tests/Types/TypeExtensionsTests.cs b/src/HotChocolate/Core/test/Types.Tests/Types/TypeExtensionsTests.cs
@@ -130,7 +130,7 @@ public static void NamedType_Of_T_Is_Not_Of_T()
                     new StringType())));
 
         // act & assert
-        Assert.Throws<ArgumentException>(() => type.NamedType<ObjectType>());
+        Assert.Throws<ArgumentException>(type.NamedType<ObjectType>);
     }
 
     [Fact]
diff --git a/src/HotChocolate/Data/test/Data.Filters.Tests/FilterInputTypeTest.cs b/src/HotChocolate/Data/test/Data.Filters.Tests/FilterInputTypeTest.cs
@@ -262,7 +262,7 @@ public void FilterInputType_Should_ThrowException_WhenNoConventionIsRegistered()
 
         // act
         // assert
-        var exception = Assert.Throws<SchemaException>(() => builder.Create());
+        var exception = Assert.Throws<SchemaException>(builder.Create);
         exception.Message.MatchSnapshot();
     }
 
@@ -280,7 +280,7 @@ public void FilterInputType_Should_ThrowException_WhenNoConventionIsRegisteredDe
 
         // act
         // assert
-        var exception = Assert.Throws<SchemaException>(() => builder.Create());
+        var exception = Assert.Throws<SchemaException>(builder.Create);
         exception.Message.MatchSnapshot();
     }
 
diff --git a/src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs b/src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs
@@ -161,7 +161,7 @@ public void SortInputType_Should_ThrowException_WhenNoConventionIsRegistered()
 
         // act
         // assert
-        var exception = Assert.Throws<SchemaException>(() => builder.Create());
+        var exception = Assert.Throws<SchemaException>(builder.Create);
         exception.Message.MatchSnapshot();
     }
 
@@ -179,7 +179,7 @@ public void SortInputType_Should_ThrowException_WhenNoConventionIsRegisteredDefa
 
         // act
         // assert
-        var exception = Assert.Throws<SchemaException>(() => builder.Create());
+        var exception = Assert.Throws<SchemaException>(builder.Create);
         exception.Message.MatchSnapshot();
     }
 
diff --git a/src/HotChocolate/MongoDb/src/Data/Driver/AndFilterDefinition.cs b/src/HotChocolate/MongoDb/src/Data/Driver/AndFilterDefinition.cs
@@ -77,7 +77,7 @@ private static void AddClause(BsonDocument document, BsonElement clause)
                 var clauseOperator = clauseValue.ElementCount > 0
                     ? clauseValue.GetElement(0).Name
                     : null;
-                if (clauseValue.Names.Any(op => existingClauseValue.Contains(op)) ||
+                if (clauseValue.Names.Any(existingClauseValue.Contains) ||
                     s_operatorsThatCannotBeCombined.Contains(clauseOperator))
                 {
                     PromoteFilterToDollarForm(document, clause);
diff --git a/src/HotChocolate/Spatial/test/Types.Tests/TransformationIntegrationTests.cs b/src/HotChocolate/Spatial/test/Types.Tests/TransformationIntegrationTests.cs
@@ -37,7 +37,7 @@ public void Execute_UnknownDefaultCRS()
             .TryAddTypeInterceptor<RoundTypeIntercetor>();
 
         // act
-        var ex = Record.Exception(() => builder.Create());
+        var ex = Record.Exception(builder.Create);
 
         // assert
         Assert.IsType<SchemaException>(ex).MatchSnapshot();
diff --git a/src/StrawberryShake/Client/src/Persistence.SQLite/SQLitePersistence.cs b/src/StrawberryShake/Client/src/Persistence.SQLite/SQLitePersistence.cs
@@ -115,13 +115,13 @@ private void BeginWrite()
             .Watch()
             .Subscribe(
                 onNext: update => _queue.Writer.TryWrite(update),
-                onCompleted: () => _cts.Cancel());
+                onCompleted: _cts.Cancel);
 
         _operationStoreSubscription = _storeAccessor.OperationStore
             .Watch()
             .Subscribe(
                 onNext: update => _queue.Writer.TryWrite(update),
-                onCompleted: () => _cts.Cancel());
+                onCompleted: _cts.Cancel);
 
         Task.Run(async () => await WriteAsync(_cts.Token).ConfigureAwait(false));
     }
diff --git a/src/StrawberryShake/Client/test/Transport.InMemory.Tests/InMemoryClientBuilderExtensionsTests.cs b/src/StrawberryShake/Client/test/Transport.InMemory.Tests/InMemoryClientBuilderExtensionsTests.cs
@@ -305,8 +305,7 @@ public void ConfigureRequestInterceptorGeneric_NoServices_ThrowException()
         IInMemoryClientBuilder builder = null!;
 
         // act
-        var ex =
-            Record.Exception(() => builder.ConfigureRequestInterceptor<StubInterceptor>());
+        var ex = Record.Exception(builder.ConfigureRequestInterceptor<StubInterceptor>);
 
         // assert
         Assert.IsType<ArgumentNullException>(ex);
diff --git a/src/StrawberryShake/Client/test/Transport.WebSocket.Tests/DependencyInjection/WebSocketClientFactoryServiceCollectionExtensionsTests.cs b/src/StrawberryShake/Client/test/Transport.WebSocket.Tests/DependencyInjection/WebSocketClientFactoryServiceCollectionExtensionsTests.cs
@@ -27,8 +27,7 @@ public void AddProtocol_ServicesNull_ThrowException()
         ServiceCollection services = null!;
 
         // act
-        var ex =
-            Record.Exception(() => services.AddProtocol<GraphQLWebSocketProtocolFactory>());
+        var ex = Record.Exception(services.AddProtocol<GraphQLWebSocketProtocolFactory>);
 
         // assert
         Assert.IsType<ArgumentNullException>(ex);
diff --git a/src/StrawberryShake/Client/test/Transport.WebSocket.Tests/DependencyInjection/WebSocketClientPoolServiceCollectionExtensionsTests.cs b/src/StrawberryShake/Client/test/Transport.WebSocket.Tests/DependencyInjection/WebSocketClientPoolServiceCollectionExtensionsTests.cs
@@ -30,8 +30,7 @@ public void AddWebSocketClientPool_ServicesNull_ThrowException()
         ServiceCollection services = null!;
 
         // act
-        var ex =
-            Record.Exception(() => services.AddWebSocketClientPool());
+        var ex = Record.Exception(services.AddWebSocketClientPool);
 
         // assert
         Assert.IsType<ArgumentNullException>(ex);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ internal static class StreamHelper`
`22`	`22`	`public static IAsyncEnumerable<object?> CreateStream(object result)`
`23`	`23`	`{`
`24`	`24`	`var resultType = result.GetType();`
`25`		`- var factory = s_streamFactories.GetOrAdd(resultType, t => CreateFactory(t));`
	`25`	`+ var factory = s_streamFactories.GetOrAdd(resultType, CreateFactory);`
`26`	`26`	`return factory.Invoke(result);`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ private async ValueTask OnConnect(CancellationToken cancellationToken = default)`
`78`	`78`	`_subscription = new ChannelSubscription(_channelName, connection, OnNotification);`
`79`	`79`	`await _subscription.ConnectAsync(cancellationToken);`
`80`	`80`
`81`		`- _waitOnNotificationTask = new ContinuousTask(`
`82`		`- ct => connection.WaitAsync(ct),`
`83`		`- TimeProvider.System);`
	`81`	`+ _waitOnNotificationTask = new ContinuousTask(connection.WaitAsync, TimeProvider.System);`
`84`	`82`
`85`	`83`	`_diagnosticEvents.ProviderInfo(PostgresChannel_ConnectionEstablished);`
`86`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ private void CompleteNames()`
`219`	`219`	`{`
`220`	`220`	`_interceptor.OnBeforeCompleteTypeNames();`
`221`	`221`
`222`		`- if (ProcessTypes(Named, type => CompleteTypeName(type)))`
	`222`	`+ if (ProcessTypes(Named, CompleteTypeName))`
`223`	`223`	`{`
`224`	`224`	`_interceptor.OnTypesCompletedName();`
`225`	`225`	`}`
`@@ -575,7 +575,7 @@ private void CompleteTypes()`
`575`	`575`	`{`
`576`	`576`	`_interceptor.OnBeforeCompleteTypes();`
`577`	`577`
`578`		`- if (ProcessTypes(Completed, type => CompleteType(type)))`
	`578`	`+ if (ProcessTypes(Completed, CompleteType))`
`579`	`579`	`{`
`580`	`580`	`_interceptor.OnTypesCompleted();`
`581`	`581`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,6 @@ public void ExceptionThrown_WhenAskedForUnknownFeature()`
`29`	`29`	`features.Set<IThing>(thing);`
`30`	`30`
`31`	`31`	`// Assert`
`32`		`- Assert.Throws<InvalidOperationException>(() => features.GetRequired<object>());`
	`32`	`+ Assert.Throws<InvalidOperationException>(features.GetRequired<object>);`
`33`	`33`	`}`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public IEnumerable<ICharacter> GetCharacter(`
`28`	`28`	`return null;`
`29`	`29`	`}`
`30`	`30`	`return character.Friends`
`31`		`- .Select(t => repository.GetCharacter(t))`
	`31`	`+ .Select(repository.GetCharacter)`
`32`	`32`	`.OfType<Human>()`
`33`	`33`	`.FirstOrDefault();`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public void Set_Should_Throw_When_Disposed()`
`25`	`25`	`autoResetEvent.Dispose();`
`26`	`26`
`27`	`27`	`// Act & Assert`
`28`		`- Assert.Throws<ObjectDisposedException>(() => autoResetEvent.Set());`
	`28`	`+ Assert.Throws<ObjectDisposedException>(autoResetEvent.Set);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public async Task Dispatch_Should_Throw_When_CalledAfterDispose()`
`38`	`38`	`await asyncEventHandler.DisposeAsync();`
`39`	`39`
`40`	`40`	`// Assert`
`41`		`- Assert.Throws<ObjectDisposedException>(() => asyncEventHandler.Dispatch());`
	`41`	`+ Assert.Throws<ObjectDisposedException>(asyncEventHandler.Dispatch);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`[Fact]`