Fix ensure that node id serializer registration has no order requirements (#8216)

Author: michaelstaib

src/HotChocolate/Core/src/Execution/DependencyInjection/RequestExecutorBuilderExtensions.IdSerializer.cs

@@ -38,18 +38,31 @@ public static IRequestExecutorBuilder AddDefaultNodeIdSerializer(
     {
         ArgumentNullException.ThrowIfNull(builder);
 
-        if (!builder.Services.Any(t =>
-            t.ServiceType == typeof(INodeIdValueSerializer)
-            && t.ImplementationType == typeof(StringNodeIdValueSerializer)))
+        if (!builder.Services.IsImplementationTypeRegistered<StringNodeIdValueSerializer>())
         {
             builder.Services.AddSingleton<INodeIdValueSerializer, StringNodeIdValueSerializer>();
             builder.Services.AddSingleton<INodeIdValueSerializer, Int16NodeIdValueSerializer>();
             builder.Services.AddSingleton<INodeIdValueSerializer, Int32NodeIdValueSerializer>();
             builder.Services.AddSingleton<INodeIdValueSerializer, Int64NodeIdValueSerializer>();
-            builder.Services.AddSingleton<INodeIdValueSerializer>(new GuidNodeIdValueSerializer(compress: outputNewIdFormat));
             builder.Services.AddSingleton<INodeIdValueSerializer, DecimalNodeIdValueSerializer>();
             builder.Services.AddSingleton<INodeIdValueSerializer, SingleNodeIdValueSerializer>();
             builder.Services.AddSingleton<INodeIdValueSerializer, DoubleNodeIdValueSerializer>();
+            builder.Services.AddSingleton<INodeIdValueSerializer>(new GuidNodeIdValueSerializer(compress: outputNewIdFormat));
+        }
+        else
+        {
+            // if serializers are already registered we need to replace the
+            // default guid serializer with the new one in order to make sure
+            // that we have the right settings configured for it.
+            var serviceRegistration = builder.Services.FirstOrDefault(
+                t => t.ServiceType == typeof(INodeIdValueSerializer)
+                    && t.ImplementationType == typeof(GuidNodeIdValueSerializer));
+            if (serviceRegistration is not null)
+            {
+                builder.Services.Remove(serviceRegistration);
+                builder.Services.AddSingleton<INodeIdValueSerializer>(
+                    new GuidNodeIdValueSerializer(compress: outputNewIdFormat));
+            }
         }
 
         builder.Services.RemoveService<INodeIdSerializer>();
@@ -120,18 +133,14 @@ public static IRequestExecutorBuilder AddDefaultNodeIdSerializer(
     /// <param name="builder">
     /// The request executor builder.
     /// </param>
-    /// <param name="maxIdLength">
-    /// The maximum allowed length of a node id.
-    /// </param>
     /// <returns>
     /// Returns the request executor builder.
     /// </returns>
     /// <exception cref="ArgumentNullException">
     /// <paramref name="builder"/> is <see langword="null"/>.
     /// </exception>
     public static IRequestExecutorBuilder AddLegacyNodeIdSerializer(
-        this IRequestExecutorBuilder builder,
-        int maxIdLength = 1024)
+        this IRequestExecutorBuilder builder)
     {
         ArgumentNullException.ThrowIfNull(builder);