Sort nodes alphabetically when generating selection expressions (#8551)

Cyberboss · michaelstaib · michaelstaib · commit c1e009f72930 · 2025-08-27T11:35:36.000+02:00
Co-authored-by: Michael Staib &lt;michael@chillicream.com&gt;
diff --git a/src/HotChocolate/Core/src/Execution.Projections/SelectionExpressionBuilder.cs b/src/HotChocolate/Core/src/Execution.Projections/SelectionExpressionBuilder.cs
@@ -170,7 +170,8 @@ private void CollectTypes(Context context, ISelection selection, TypeContainer p
     {
         var assignments = ImmutableArray.CreateBuilder<MemberAssignment>();
 
-        foreach (var property in parent.Nodes)
+        // order by property name so expressions evalutate to the same hash regardless of selection order
+        foreach (var property in parent.Nodes.OrderBy(node => node.Property.Name))
         {
             var assignment = BuildAssignmentExpression(property, context);
             if (assignment is not null)

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,8 @@ private void CollectTypes(Context context, ISelection selection, TypeContainer p`
`170`	`170`	`{`
`171`	`171`	`var assignments = ImmutableArray.CreateBuilder<MemberAssignment>();`
`172`	`172`
`173`		`- foreach (var property in parent.Nodes)`
	`173`	`+ // order by property name so expressions evalutate to the same hash regardless of selection order`
	`174`	`+ foreach (var property in parent.Nodes.OrderBy(node => node.Property.Name))`
`174`	`175`	`{`
`175`	`176`	`var assignment = BuildAssignmentExpression(property, context);`
`176`	`177`	`if (assignment is not null)`