Updated code to remove unnecessary conditional access (#8339)

Author: glen-84

.editorconfig

@@ -190,6 +190,8 @@ dotnet_diagnostic.RCS1251.severity = warning
 # Add/remove trailing comma.
 dotnet_diagnostic.RCS1260.severity = warning
 roslynator_trailing_comma_style = omit
+# Unnecessary conditional access.
+dotnet_diagnostic.RCS9003.severity = warning
 
 # netstandard2.0
 [src/HotChocolate/{Core/src/Types.Analyzers,Language}/**/*.cs]

src/GreenDonut/src/GreenDonut.Data/Extensions/GreenDonutQueryableExtensions.cs

@@ -314,7 +314,7 @@ public static IQueryable<T> With<T>(
         if(modifySortDefinition is not null)
         {
             sorting ??= SortDefinition<T>.Empty;
-            sorting = modifySortDefinition?.Invoke(sorting);
+            sorting = modifySortDefinition(sorting);
         }
 
         if (queryContext.Predicate is not null)

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/Subscriptions/Apollo/SubscriptionTestBase.cs

@@ -97,7 +97,7 @@ protected async Task<WebSocket> ConnectToServerAsync(
         await webSocket.SendConnectionInitializeAsync(cancellationToken);
         var message = await webSocket.ReceiveServerMessageAsync(cancellationToken);
         Assert.NotNull(message);
-        Assert.Equal("connection_ack", message?[MessageProperties.Type]);
+        Assert.Equal("connection_ack", message[MessageProperties.Type]);
         return webSocket;
     }
 

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/SubscriptionTestBase.cs

@@ -97,7 +97,7 @@ protected async Task<WebSocket> ConnectToServerAsync(
         await webSocket.SendConnectionInitAsync(cancellationToken);
         var message = await webSocket.ReceiveServerMessageAsync(cancellationToken);
         Assert.NotNull(message);
-        Assert.Equal("connection_ack", message?["type"]);
+        Assert.Equal("connection_ack", message["type"]);
         return webSocket;
     }
 

src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/TestServerFactory.cs

@@ -18,7 +18,7 @@ public TestServer Create(
             .ConfigureServices(services =>
             {
                 services.AddHttpContextAccessor();
-                configureServices?.Invoke(services);
+                configureServices(services);
             });
 
         var server = new TestServer(builder);

src/HotChocolate/AzureFunctions/test/HotChocolate.AzureFunctions.Tests/Helpers/HttpContextExtensions.cs

@@ -29,7 +29,7 @@ public static class HttpContextExtensions
 
     public static async Task<string?> ReadResponseContentAsync(this HttpContext? httpContext)
     {
-        var responseStream = httpContext?.Response?.Body;
+        var responseStream = httpContext?.Response.Body;
         return responseStream != null
             ? await responseStream.ReadStreamAsStringAsync().ConfigureAwait(false)
             : null;

src/HotChocolate/Caching/test/Caching.Tests/TestServerFactory.cs

@@ -17,7 +17,7 @@ public TestServer Create(
             .Configure(configureApplication)
             .ConfigureServices(services =>
             {
-                configureServices?.Invoke(services);
+                configureServices(services);
             });
 
         var server = new TestServer(builder);

src/HotChocolate/Core/src/Execution.Abstractions/GraphQLException.cs

@@ -18,11 +18,9 @@ public GraphQLException(string message)
     /// </summary>
     /// <param name="error">The error.</param>
     public GraphQLException(IError error)
-        : base(error?.Message)
+        : base(error.Message)
     {
-        Errors = error is null
-            ? Array.Empty<IError>()
-            : [error];
+        Errors = [error];
     }
 
     /// <summary>

src/HotChocolate/Core/src/Types/Types/Extensions/DirectiveCollectionExtensions.cs

@@ -11,7 +11,7 @@ namespace HotChocolate.Types;
 
 public static class DirectiveCollectionExtensions
 {
-    public static T SingleOrDefault<T>(this DirectiveCollection directives) where T : notnull
+    public static T? SingleOrDefault<T>(this DirectiveCollection directives) where T : notnull
     {
         foreach (var directive in directives)
         {
@@ -21,7 +21,7 @@ public static T SingleOrDefault<T>(this DirectiveCollection directives) where T
             }
         }
 
-        return default!;
+        return default;
     }
 
     internal static IValueNode? SkipValue(this IReadOnlyList<DirectiveNode> directives)

src/HotChocolate/Core/test/Types.Tests/Regressions/NestedOptionalInt_2114.cs

@@ -93,17 +93,17 @@ mutation a($input: ButterPickleInput!)
     private static void Verify(ToppingInput? input)
     {
         Assert.NotNull(input);
-        var pickle = input?.Pickles!.First()?.ButterPickle;
+        var pickle = input.Pickles!.First().ButterPickle;
         Assert.NotNull(pickle);
-        Assert.Equal(5, pickle?.Size);
-        Assert.False(pickle?.Width.HasValue);
-        Assert.False(pickle?.ComplexUnassigned.HasValue);
-        Assert.True(pickle?.ComplexAssigned.HasValue);
-        Assert.Equal(3, pickle?.ComplexAssigned.Value?.Value);
-        Assert.True(pickle?.ComplexAssignedNull.HasValue);
-        Assert.Null(pickle?.ComplexAssignedNull.Value);
-        Assert.True(pickle?.ComplexList.HasValue);
-        Assert.Equal(2, pickle?.ComplexList.Value?.First().Value);
+        Assert.Equal(5, pickle.Size.Value);
+        Assert.False(pickle.Width.HasValue);
+        Assert.False(pickle.ComplexUnassigned.HasValue);
+        Assert.True(pickle.ComplexAssigned.HasValue);
+        Assert.Equal(3, pickle.ComplexAssigned.Value?.Value);
+        Assert.True(pickle.ComplexAssignedNull.HasValue);
+        Assert.Null(pickle.ComplexAssignedNull.Value);
+        Assert.True(pickle.ComplexList.HasValue);
+        Assert.Equal(2, pickle.ComplexList.Value?.First().Value);
     }
 
     private static IRequestExecutor CreateExecutor(Func<ToppingInput, bool>? onEat = null)