Cleanup Build

Author: michaelstaib

.editorconfig

@@ -97,6 +97,7 @@ dotnet_style_require_accessibility_modifiers = always
 
 # Public API
 dotnet_diagnostic.rs0016.severity = warning
+dotnet_diagnostic.rcs1194.severity = none
 
 # Require braces on all control statements
 resharper_braces_for_for = required

.vscode/settings.json

@@ -13,8 +13,5 @@
     "*.targets": "xml",
     "*.tasks": "xml"
   },
-  "cSpell.words": [
-    "Nats"
-  ],
   "dotnet.defaultSolution": "src/All.sln"
 }

.vscode/tasks.json

@@ -17,22 +17,53 @@
       }
     },
     {
-      "label": "Build entire repository (Debug)",
+      "label": "Build src/All.sln",
       "command": "dotnet",
       "type": "shell",
       "args": [
         "build",
         "src/All.sln",
-        // Ask dotnet build to generate full paths for file names.
         "/property:GenerateFullPaths=true",
-        // Do not generate summary otherwise it leads to duplicate errors in Problems panel
-        "/consoleloggerparameters:NoSummary",
+        "/consoleloggerparameters:NoSummary"
       ],
       "group": "build",
       "presentation": {
         "reveal": "silent"
       },
       "problemMatcher": "$msCompile"
-    }
+    },
+    {
+      "label": "Build src/HotChocolate/Core/HotChocolate.Core.sln",
+      "command": "dotnet",
+      "type": "shell",
+      "args": [
+        "build",
+        "src/HotChocolate/Core/HotChocolate.Core.sln",
+        "/property:GenerateFullPaths=true",
+        "/consoleloggerparameters:NoSummary"
+      ],
+      "group": "build",
+      "presentation": {
+        "reveal": "silent"
+      },
+      "problemMatcher": "$msCompile"
+    },
+    {
+      "label": "Test src/All.sln",
+      "command": "dotnet",
+      "type": "shell",
+      "args": [
+        "test",
+        "src/All.sln",
+        "--verbosity q",
+        "/property:GenerateFullPaths=true",
+        "/consoleloggerparameters:NoSummary"
+      ],
+      "group": "build",
+      "presentation": {
+        "reveal": "silent"
+      },
+      "problemMatcher": "$msCompile"
+    },
   ]
 }

src/Directory.Build.props

@@ -64,4 +64,10 @@
     <None Include="$(MSBuildThisFileDirectory)..\LICEN*" Pack="true" PackagePath="" Visible="false" />
   </ItemGroup>
 
+  <ItemGroup Condition="'$(Configuration)' == 'debug'">
+    <PackageReference Include="Roslynator.Analyzers" Version="4.12.3" />
+    <PackageReference Include="Roslynator.CodeAnalysis.Analyzers" Version="4.12.3" />
+    <PackageReference Include="Roslynator.Formatting.Analyzers" Version="4.12.3" />
+  </ItemGroup>
+
 </Project>

src/HotChocolate/ApolloFederation/test/ApolloFederation.Tests/Directives/ComposeDirectiveTests.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Threading.Tasks;
 using CookieCrumble;
 using HotChocolate.ApolloFederation.Types;
@@ -45,6 +46,7 @@ public class Address
     [DirectiveType(DirectiveLocation.FieldDefinition)]
     public sealed class Custom;
 
+    [AttributeUsage(AttributeTargets.All, AllowMultiple = false)]
     public sealed class CustomDirectiveAttribute()
         : DirectiveAttribute<Custom>(new Custom());
 }

src/HotChocolate/AspNetCore/test/AspNetCore.Tests/Extensions/ServiceCollectionExtensionTests.cs

@@ -2,7 +2,7 @@
 
 namespace Microsoft.Extensions.DependencyInjection;
 
-public class ServiceCollectionExtensionTests
+public static class ServiceCollectionExtensionTests
 {
     [Fact]
     public static void AddHttpRequestSerializer_OfT()

src/HotChocolate/Caching/src/Caching/CacheControlAttribute.cs

@@ -23,6 +23,9 @@ public CacheControlAttribute()
     {
     }
 
+    /// <summary>
+    /// Initializes a new instance of the <see cref="CacheControlAttribute"/> class with the specified maximum age.
+    /// </summary>
     /// <param name="maxAge">
     /// The maximum time, in seconds, the resource can be cached.
     /// </param>

src/HotChocolate/Core/src/Abstractions/DiagnosticEventSourceAttribute.cs

@@ -6,6 +6,7 @@ namespace HotChocolate;
 /// This attribute can be used by custom diagnostic event listeners
 /// to specify the source to which a listener shall be bound to.
 /// </summary>
+[AttributeUsage(AttributeTargets.Class, AllowMultiple = false)]
 public class DiagnosticEventSourceAttribute : Attribute
 {
     /// <summary>

src/HotChocolate/Core/src/Abstractions/Execution/IExecutionResult.cs

@@ -32,4 +32,4 @@ public interface IExecutionResult : IAsyncDisposable
     /// A cleanup task that will be executed when this result is disposed.
     /// </param>
     void RegisterForCleanup(Func<ValueTask> clean);
-}
+}

src/HotChocolate/Core/src/Execution/IRequestExecutor.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;