Skip to content

Commit e2039d1

Browse files
glen-84glen-84
authored
Removed unnecessary value assignments (#8418)
1 parent 0e9d78f commit e2039d1

File tree

23 files changed

+57
-75
lines changed

23 files changed

+57
-75
lines changed

‎.editorconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,8 @@ dotnet_diagnostic.IDE0054.severity = warning
210210
dotnet_diagnostic.IDE0055.severity = warning
211211
# Use range operator.
212212
dotnet_diagnostic.IDE0057.severity = warning
213+
# Remove unnecessary value assignment.
214+
dotnet_diagnostic.IDE0059.severity = warning
213215
# Use compound assignment.
214216
dotnet_diagnostic.IDE0074.severity = warning
215217
# Remove unnecessary suppression.

‎src/GreenDonut/src/GreenDonut.Data/Cursors/CursorParser.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,17 +133,17 @@ private static CursorPageInfo ParsePageInfo(ref Span<byte> span)
133133

134134
var separatorIndex = ExpectSeparator(span, separator);
135135
var part = span[..separatorIndex];
136-
ParseNumber(part, out var offset, out var consumed);
136+
ParseNumber(part, out var offset, out _);
137137
var start = separatorIndex + 1;
138138

139139
separatorIndex = ExpectSeparator(span[start..], separator);
140140
part = span.Slice(start, separatorIndex);
141-
ParseNumber(part, out var page, out consumed);
141+
ParseNumber(part, out var page, out _);
142142
start += separatorIndex + 1;
143143

144144
separatorIndex = ExpectSeparator(span[start..], close);
145145
part = span.Slice(start, separatorIndex);
146-
ParseNumber(part, out var totalCount, out consumed);
146+
ParseNumber(part, out var totalCount, out _);
147147
start += separatorIndex + 1;
148148

149149
// Advance span beyond closing `}`

‎src/HotChocolate/AspNetCore/src/Transport.Http/GraphQLHttpEventStreamEnumerable.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,6 @@ private static ReadState TryReadResult(ReadOnlySpan<byte> message, out Operation
172172

173173
private static EventType ParseEventType(ref ReadOnlySpan<byte> span)
174174
{
175-
var debug = Encoding.UTF8.GetString(span);
176-
177175
if (ExpectEvent(ref span))
178176
{
179177
if (ExpectNext(ref span))

‎src/HotChocolate/Core/src/Types/Types/Relay/Serialization/LegacyNodeIdSerializer.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,16 +138,16 @@ public static byte GetLegacyValueCode(object value)
138138
{
139139
switch (value)
140140
{
141-
case Guid g:
141+
case System.Guid:
142142
return Guid;
143143

144-
case short s:
144+
case short:
145145
return Short;
146146

147-
case int i:
147+
case int:
148148
return Int;
149149

150-
case long l:
150+
case long:
151151
return Long;
152152

153153
default:

‎src/HotChocolate/Core/src/Types/Types/Scalars/Iso8601Duration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ internal static bool TryParse(string s, out TimeSpan? result)
223223
days = value;
224224
if (++pos <= length)
225225
{
226-
if (!TryParseDigits(s, ref pos, false, out value, out numDigits))
226+
if (!TryParseDigits(s, ref pos, false, out _, out numDigits))
227227
{
228228
return false;
229229
}

‎src/HotChocolate/Core/test/Execution.Tests/Processing/WorkQueueTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ public void Take_All()
6565
queue.Push(task2);
6666

6767
// act
68-
queue.TryTake(out var task);
69-
var success = queue.TryTake(out task);
68+
queue.TryTake(out _);
69+
var success = queue.TryTake(out var task);
7070

7171
// assert
7272
Assert.Same(task1, task);
@@ -86,9 +86,9 @@ public void Complete_All()
8686
queue.Push(task2);
8787

8888
// act
89-
queue.TryTake(out var task);
89+
queue.TryTake(out _);
9090
queue.Complete();
91-
queue.TryTake(out task);
91+
queue.TryTake(out var task);
9292
queue.Complete();
9393

9494
// assert

‎src/HotChocolate/Core/test/Subscriptions.Tests/SubscriptionIntegrationTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ public virtual async Task Subscribe_And_Complete_Topic()
310310
await Task.Delay(2000, cts.Token);
311311
await sender.CompleteAsync("OnMessage");
312312

313-
await foreach (var unused in results.WithCancellation(cts.Token).ConfigureAwait(false))
313+
await foreach (var _ in results.WithCancellation(cts.Token).ConfigureAwait(false))
314314
{
315315
Assert.Fail("Should not have any messages.");
316316
}
@@ -337,7 +337,7 @@ public virtual async Task Subscribe_And_Complete_Topic_With_ValueTypeMessage()
337337
await Task.Delay(2000, cts.Token);
338338
await sender.CompleteAsync("OnMessage3");
339339

340-
await foreach (var unused in results.WithCancellation(cts.Token).ConfigureAwait(false))
340+
await foreach (var _ in results.WithCancellation(cts.Token).ConfigureAwait(false))
341341
{
342342
Assert.Fail("Should not have any messages.");
343343
}

‎src/HotChocolate/Core/test/Types.Mutations.Tests/AnnotationBasedMutations.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1411,7 +1411,7 @@ public override void OnBeforeCompleteType(
14111411
ITypeCompletionContext completionContext,
14121412
TypeSystemConfiguration configuration)
14131413
{
1414-
if (configuration is not ObjectTypeConfiguration objTypeDef)
1414+
if (configuration is not ObjectTypeConfiguration _)
14151415
{
14161416
return;
14171417
}

‎src/HotChocolate/Core/test/Types.Tests/SchemaCoordinateTests.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ public void TryGetMember_Object_Invalid_FieldName()
399399
var schema = CreateSchema();
400400

401401
// act
402-
var success = schema.TryGetMember("Baz.foo", out var member);
402+
var success = schema.TryGetMember("Baz.foo", out _);
403403

404404
// assert
405405
Assert.False(success);
@@ -412,7 +412,7 @@ public void TryGetMember_Object_Invalid_FieldArgName()
412412
var schema = CreateSchema();
413413

414414
// act
415-
var success = schema.TryGetMember("Baz.name(bar:)", out var member);
415+
var success = schema.TryGetMember("Baz.name(bar:)", out _);
416416

417417
// assert
418418
Assert.False(success);
@@ -472,7 +472,7 @@ public void TryGetMember_Interface_Invalid_FieldName()
472472
var schema = CreateSchema();
473473

474474
// act
475-
var success = schema.TryGetMember("Baz.xyz", out var member);
475+
var success = schema.TryGetMember("Baz.xyz", out _);
476476

477477
// assert
478478
Assert.False(success);
@@ -485,7 +485,7 @@ public void TryGetMember_Interface_Invalid_FieldArgName()
485485
var schema = CreateSchema();
486486

487487
// act
488-
var success = schema.TryGetMember("Bar.name(bar:)", out var member);
488+
var success = schema.TryGetMember("Bar.name(bar:)", out _);
489489

490490
// assert
491491
Assert.False(success);
@@ -498,7 +498,7 @@ public void TryGetMember_UnionType()
498498
var schema = CreateSchema();
499499

500500
// act
501-
var success = schema.TryGetMember("FooOrBaz", out var member);
501+
var success = schema.TryGetMember("FooOrBaz", out _);
502502

503503
// assert
504504
Assert.True(success);
@@ -511,7 +511,7 @@ public void TryGetMember_UnionType_Invalid_MemberName()
511511
var schema = CreateSchema();
512512

513513
// act
514-
var success = schema.TryGetMember("FooOrBaz.Foo", out var member);
514+
var success = schema.TryGetMember("FooOrBaz.Foo", out _);
515515

516516
// assert
517517
Assert.False(success);
@@ -554,7 +554,7 @@ public void TryGetMember_InputObjectType_Invalid_FieldName()
554554
var schema = CreateSchema();
555555

556556
// act
557-
var success = schema.TryGetMember("BazInput.abc", out var member);
557+
var success = schema.TryGetMember("BazInput.abc", out _);
558558

559559
// assert
560560
Assert.False(success);
@@ -567,7 +567,7 @@ public void TryGetMember_InputObjectType_Invalid_FieldArgName()
567567
var schema = CreateSchema();
568568

569569
// act
570-
var success = schema.TryGetMember("BazInput.name(a:)", out var member);
570+
var success = schema.TryGetMember("BazInput.name(a:)", out _);
571571

572572
// assert
573573
Assert.False(success);
@@ -608,7 +608,7 @@ public void TryGetMember_EnumType_Invalid_Value()
608608
var schema = CreateSchema();
609609

610610
// act
611-
var success = schema.TryGetMember("Abc.XYZ", out var member);
611+
var success = schema.TryGetMember("Abc.XYZ", out _);
612612

613613
// assert
614614
Assert.False(success);
@@ -665,7 +665,7 @@ public void TryGetMember_DirectiveType_Invalid_ArgumentName()
665665
var schema = CreateSchema();
666666

667667
// act
668-
var success = schema.TryGetMember("@qux(b:)", out var member);
668+
var success = schema.TryGetMember("@qux(b:)", out _);
669669

670670
// assert
671671
Assert.False(success);
@@ -678,7 +678,7 @@ public void TryGetMember_Invalid_TypeName()
678678
var schema = CreateSchema();
679679

680680
// act
681-
var success = schema.TryGetMember("Abc123", out var member);
681+
var success = schema.TryGetMember("Abc123", out _);
682682

683683
// assert
684684
Assert.False(success);
@@ -691,7 +691,7 @@ public void TryGetMember_Invalid_DirectiveName()
691691
var schema = CreateSchema();
692692

693693
// act
694-
var success = schema.TryGetMember("@abc", out var member);
694+
var success = schema.TryGetMember("@abc", out _);
695695

696696
// assert
697697
Assert.False(success);

‎src/HotChocolate/Core/test/Types.Tests/Types/Descriptors/ObjectTypeDescriptorTests.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,19 @@ public class ObjectTypeDescriptorTests : DescriptorTestBase
99
[Fact]
1010
public void InferNameFromType()
1111
{
12-
// arrange
12+
// arrange & act
1313
var descriptor = new ObjectTypeDescriptor<Foo>(Context);
1414

15-
// act
16-
IObjectTypeDescriptor<Foo> desc = descriptor;
17-
1815
// assert
1916
Assert.Equal("Foo", descriptor.CreateConfiguration().Name);
2017
}
2118

2219
[Fact]
2320
public void GetNameFromAttribute()
2421
{
25-
// arrange
22+
// arrange & act
2623
var descriptor = new ObjectTypeDescriptor<Foo2>(Context);
2724

28-
// act
29-
IObjectTypeDescriptor<Foo2> desc = descriptor;
30-
3125
// assert
3226
Assert.Equal("FooAttr", descriptor.CreateConfiguration().Name);
3327
}

0 commit comments

Comments
 (0)