Updated code to use the ArgumentNullException throw helper (#8319)

Author: glen-84

.editorconfig

@@ -149,3 +149,9 @@ dotnet_naming_symbols.static_fields.required_modifiers = static
 dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal, private_protected
 dotnet_naming_style.static_prefix_style.required_prefix = s_
 dotnet_naming_style.static_prefix_style.capitalization = camel_case
+
+# Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance.
+dotnet_diagnostic.CA1510.severity = warning
+
+[src/HotChocolate/Language/**/*.cs]
+dotnet_diagnostic.CA1510.severity = none

src/CookieCrumble/src/CookieCrumble.HotChocolate/Formatters/ExecutionResultSnapshotValueFormatter.cs

@@ -109,10 +109,7 @@ internal sealed class JsonResultPatcher
 
     public void SetResponse(JsonDocument response)
     {
-        if (response is null)
-        {
-            throw new ArgumentNullException(nameof(response));
-        }
+        ArgumentNullException.ThrowIfNull(response);
 
         _json = JsonObject.Create(response.RootElement);
     }

src/CookieCrumble/src/CookieCrumble/Snapshot.cs

@@ -96,10 +96,7 @@ public static void Match(
     public static void RegisterTestFramework(
         ITestFramework testFramework)
     {
-        if (testFramework is null)
-        {
-            throw new ArgumentNullException(nameof(testFramework));
-        }
+        ArgumentNullException.ThrowIfNull(testFramework);
 
         lock (_sync)
         {
@@ -110,10 +107,7 @@ public static void RegisterTestFramework(
     public static void RegisterFormatter(
         ISnapshotValueFormatter formatter)
     {
-        if (formatter is null)
-        {
-            throw new ArgumentNullException(nameof(formatter));
-        }
+        ArgumentNullException.ThrowIfNull(formatter);
 
         lock (_sync)
         {
@@ -125,10 +119,7 @@ public static void TryRegisterFormatter(
         ISnapshotValueFormatter formatter,
         bool typeCheck = true)
     {
-        if (formatter is null)
-        {
-            throw new ArgumentNullException(nameof(formatter));
-        }
+        ArgumentNullException.ThrowIfNull(formatter);
 
         lock (_sync)
         {
@@ -184,10 +175,7 @@ public Snapshot Add(
 
     public Snapshot Add(SnapshotValue value)
     {
-        if (value == null)
-        {
-            throw new ArgumentNullException(nameof(value));
-        }
+        ArgumentNullException.ThrowIfNull(value);
 
         _segments.Add(value);
         return this;

src/GreenDonut/src/GreenDonut.Data.EntityFramework/Expressions/ExpressionHelpers.cs

@@ -306,10 +306,7 @@ static MethodInfo GetEnumerableMethod(string methodName, Type elementType, Lambd
     /// <exception cref="ArgumentNullException"></exception>
     public static OrderRewriterResult ExtractAndRemoveOrder(Expression expression)
     {
-        if (expression is null)
-        {
-            throw new ArgumentNullException(nameof(expression));
-        }
+        ArgumentNullException.ThrowIfNull(expression);
 
         var rewriter = new OrderByRemovalRewriter();
         var (result, orderExpressions, orderMethods) = rewriter.Rewrite(expression);

src/GreenDonut/src/GreenDonut.Data.Primitives/SortBy.cs

@@ -48,10 +48,7 @@ public SortBy(Expression<Func<TEntity, TValue>> keySelector, bool ascending = tr
     /// </returns>
     public IOrderedQueryable<TEntity> ApplyOrderBy(IQueryable<TEntity> queryable)
     {
-        if (queryable is null)
-        {
-            throw new ArgumentNullException(nameof(queryable));
-        }
+        ArgumentNullException.ThrowIfNull(queryable);
 
         if (Ascending)
         {
@@ -107,10 +104,7 @@ public static class SortBy<TEntity>
     public static SortBy<TEntity, TValue> Ascending<TValue>(
         Expression<Func<TEntity, TValue>> keySelector)
     {
-        if (keySelector is null)
-        {
-            throw new ArgumentNullException(nameof(keySelector));
-        }
+        ArgumentNullException.ThrowIfNull(keySelector);
 
         return new SortBy<TEntity, TValue>(keySelector, true);
     }
@@ -133,10 +127,7 @@ public static SortBy<TEntity, TValue> Ascending<TValue>(
     public static SortBy<TEntity, TValue> Descending<TValue>(
         Expression<Func<TEntity, TValue>> keySelector)
     {
-        if (keySelector is null)
-        {
-            throw new ArgumentNullException(nameof(keySelector));
-        }
+        ArgumentNullException.ThrowIfNull(keySelector);
 
         return new SortBy<TEntity, TValue>(keySelector, false);
     }

src/GreenDonut/src/GreenDonut.Data.Primitives/SortDefinition.cs

@@ -63,10 +63,7 @@ public void Deconstruct(out ImmutableArray<ISortBy<T>> operations)
     public SortDefinition<T> AddAscending<TResult>(
         Expression<Func<T, TResult>> keySelector)
     {
-        if (keySelector == null)
-        {
-            throw new ArgumentNullException(nameof(keySelector));
-        }
+        ArgumentNullException.ThrowIfNull(keySelector);
 
         var operations = Operations.Add(SortBy<T>.Ascending(keySelector));
         return new SortDefinition<T>(operations);
@@ -87,10 +84,7 @@ public SortDefinition<T> AddAscending<TResult>(
     public SortDefinition<T> AddDescending<TResult>(
         Expression<Func<T, TResult>> keySelector)
     {
-        if (keySelector == null)
-        {
-            throw new ArgumentNullException(nameof(keySelector));
-        }
+        ArgumentNullException.ThrowIfNull(keySelector);
 
         var operations = Operations.Add(SortBy<T>.Descending(keySelector));
         return new SortDefinition<T>(operations);
@@ -111,10 +105,7 @@ public SortDefinition<T> AddDescending<TResult>(
     public SortDefinition<T> IfEmpty(
         Func<SortDefinition<T>, SortDefinition<T>> applyIfEmpty)
     {
-        if (applyIfEmpty == null)
-        {
-            throw new ArgumentNullException(nameof(applyIfEmpty));
-        }
+        ArgumentNullException.ThrowIfNull(applyIfEmpty);
 
         if (Operations.Length == 0)
         {

src/GreenDonut/src/GreenDonut.Data/Cursors/CursorFormatter.cs

@@ -43,10 +43,7 @@ public static string Format<T>(T entity, CursorKey[] keys, CursorPageInfo pageIn
             throw new ArgumentNullException(nameof(entity));
         }
 
-        if (keys == null)
-        {
-            throw new ArgumentNullException(nameof(keys));
-        }
+        ArgumentNullException.ThrowIfNull(keys);
 
         if (keys.Length == 0)
         {

src/GreenDonut/src/GreenDonut.Data/Cursors/CursorParser.cs

@@ -34,10 +34,7 @@ public static class CursorParser
     /// </exception>
     public static Cursor Parse(string cursor, ReadOnlySpan<CursorKey> keys)
     {
-        if (cursor == null)
-        {
-            throw new ArgumentNullException(nameof(cursor));
-        }
+        ArgumentNullException.ThrowIfNull(cursor);
 
         if (keys.Length == 0)
         {

src/GreenDonut/src/GreenDonut.Data/Extensions/GreenDonutPageExtensions.cs

@@ -34,10 +34,7 @@ public static class GreenDonutPageExtensions
     /// </remarks>
     public static ImmutableArray<PageCursor> CreateRelativeBackwardCursors<T>(this Page<T> page, int maxCursors = 5)
     {
-        if (page == null)
-        {
-            throw new ArgumentNullException(nameof(page));
-        }
+        ArgumentNullException.ThrowIfNull(page);
 
         if (maxCursors < 0)
         {
@@ -95,10 +92,7 @@ public static ImmutableArray<PageCursor> CreateRelativeBackwardCursors<T>(this P
     /// </remarks>
     public static ImmutableArray<PageCursor> CreateRelativeForwardCursors<T>(this Page<T> page, int maxCursors = 5)
     {
-        if (page == null)
-        {
-            throw new ArgumentNullException(nameof(page));
-        }
+        ArgumentNullException.ThrowIfNull(page);
 
         if (maxCursors < 0)
         {

src/GreenDonut/src/GreenDonut.Data/Extensions/GreenDonutPaginationBatchingDataLoaderExtensions.cs

@@ -77,10 +77,7 @@ private static IDataLoader<TKey, Page<TValue>> WithInternal<TKey, TValue>(
         QueryContext<TValue>? context)
         where TKey : notnull
     {
-        if (dataLoader is null)
-        {
-            throw new ArgumentNullException(nameof(dataLoader));
-        }
+        ArgumentNullException.ThrowIfNull(dataLoader);
 
         var branchKey = pagingArguments.ComputeHash(context);
         var state = new PagingState<TValue>(pagingArguments, context);
@@ -113,10 +110,7 @@ public static IDataLoader<TKey, Page<TValue>> Select<TKey, TValue>(
         Expression<Func<TValue, TValue>>? selector)
         where TKey : notnull
     {
-        if (dataLoader is null)
-        {
-            throw new ArgumentNullException(nameof(dataLoader));
-        }
+        ArgumentNullException.ThrowIfNull(dataLoader);
 
         if (selector is null)
         {
@@ -162,10 +156,7 @@ public static IDataLoader<TKey, Page<TValue>> Where<TKey, TValue>(
         Expression<Func<TValue, bool>>? predicate)
         where TKey : notnull
     {
-        if (dataLoader is null)
-        {
-            throw new ArgumentNullException(nameof(dataLoader));
-        }
+        ArgumentNullException.ThrowIfNull(dataLoader);
 
         if (predicate is null)
         {
@@ -205,10 +196,7 @@ public static IDataLoader<TKey, Page<TValue>> OrderBy<TKey, TValue>(
         SortDefinition<TValue>? sortDefinition)
         where TKey : notnull
     {
-        if (dataLoader is null)
-        {
-            throw new ArgumentNullException(nameof(dataLoader));
-        }
+        ArgumentNullException.ThrowIfNull(dataLoader);
 
         if (sortDefinition is null)
         {